Skip to content

Commit 700323d

Browse files
Philimon/gecko_fix_l10n (#878)
* remove gecko workaround for l10n runs * test l10n run * test demo l10n run * run tests again
1 parent 23a7835 commit 700323d

File tree

4 files changed

+5
-2
lines changed

4 files changed

+5
-2
lines changed

.github/workflows/l10n.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ jobs:
195195
echo $gecko_url
196196
Invoke-WebRequest -Uri $gecko_url -OutFile "geckodriver.zip"
197197
unzip geckodriver.zip
198+
echo "$env:GITHUB_WORKSPACE" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
198199
shell: pwsh
199200
- name: Download Beta
200201
if: ${{ !inputs.win_installer_link }}
@@ -228,7 +229,7 @@ jobs:
228229
$line = $_
229230
Write-Host "Running tests for: $line"
230231
try {
231-
pipenv run python -m l10n_CM.run_l10n --geckodriver=geckodriver.exe --fx-executable="$env:FX_EXECUTABLE" $line
232+
pipenv run python -m l10n_CM.run_l10n --fx-executable="$env:FX_EXECUTABLE" $line
232233
} catch {
233234
$SCRIPT_EXIT_CODE = $_.Exception.HResult
234235
}

l10n_CM/constants/demo/demo_ad.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"email": "email",
1212
"telephone": "tel"
1313
},
14+
1415
"fields": [
1516
"name",
1617
"organization",

l10n_CM/region/AT.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"libro",
1111
"mediamarkt"
1212
],
13+
1314
"tests": [
1415
]
1516
}

l10n_CM/run_l10n.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ class MyHttpRequestHandler(SimpleHTTPRequestHandler):
122122
region = None
123123

124124
def translate_path(self, path):
125-
"""switch the default directory where the html files are served from."""
125+
"""switch the default directory where the HTML files are served from."""
126126
base_dir = os.path.join(current_dir, "sites", self.live_site, self.region)
127127
return os.path.join(base_dir, path.lstrip("/"))
128128

0 commit comments

Comments
 (0)