Skip to content

Commit 71d0fc9

Browse files
committed
test 1976523 with revised changes
1 parent 1cc3622 commit 71d0fc9

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

SELECTOR_INFO.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1775,6 +1775,13 @@ Location: Toolbar - any bookmark context menu
17751775
Path to .json: modules/data/context_menu.components.json
17761776
```
17771777
```
1778+
Selector Name: context-menu-toolbar-open-in-new-tab
1779+
Selector Data: selectorData": "placesContext_open:newtab"
1780+
Description: Context menu option from a Toolbar bookmark
1781+
Location: Toolbar - any bookmark context menu
1782+
Path to .json: modules/data/context_menu.components.json
1783+
```
1784+
```
17781785
Selector Name: context-menu-toolbar-open-all-bookmarks
17791786
Selector Data: placesContext_openBookmarkContainer:tabs
17801787
Description: Open all bookmarks from the context menu option from a Toolbar bookmark

modules/browser_object_navigation.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -583,14 +583,7 @@ def open_bookmark_in_new_tab_via_context_menu(
583583
self.panel_ui.element_clickable("bookmark-by-title", labels=[bookmark_title])
584584
self.panel_ui.context_click("bookmark-by-title", labels=[bookmark_title])
585585

586-
# Find the menu item we want to click
587-
# We use .fetch() here to get the element without clicking it yet
588-
menu_item = self.context_menu.fetch("context-menu-toolbar-open-in-new-tab")
589-
590-
# Use ActionChains to perform a more reliable click
591-
actions = ActionChains(self.driver)
592-
actions.move_to_element(menu_item).click().perform()
593-
586+
self.context_menu.click_on("context-menu-toolbar-open-in-new-tab")
594587
return self
595588

596589
@BasePage.context_chrome

modules/data/context_menu.components.json

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,6 @@
115115
"groups": []
116116
},
117117

118-
"context-menu-toolbar-open-in-new-tab": {
119-
"selectorData": "placesContext_open:newtab",
120-
"strategy": "id",
121-
"groups": ["doNotCache"]
122-
},
123-
124118
"context-menu-open-link-in-new-window": {
125119
"selectorData": "context-openlink",
126120
"strategy": "id",
@@ -211,6 +205,13 @@
211205
"groups": []
212206
},
213207

208+
"context-menu-toolbar-open-in-new-tab": {
209+
"selectorData": "placesContext_open:newtab",
210+
"strategy": "id",
211+
"groups": ["doNotCache"]
212+
},
213+
214+
214215
"context-menu-toolbar-open-all-bookmarks": {
215216
"selectorData": "placesContext_openBookmarkContainer:tabs",
216217
"strategy": "id",

0 commit comments

Comments
 (0)