testing further

Author: philimon-reset

l10n_CM/constants/fnac/FR/fnac_cc.json

@@ -13,10 +13,5 @@
     "3181324d-01b3-4665-bdd9-5de4be475336",
     "bc2807a3-960e-4071-9cf0-5713b340911a"
   ],
-  "skipped": [
-    "test_demo_cc_1_dropdown.py",
-    "test_demo_cc_2_preview.py",
-    "test_demo_cc_3_autofill.py",
-    "test_demo_cc_5_clear.py"
-  ]
+  "skipped": []
 }

modules/browser_object_autofill_popup.py

@@ -31,7 +31,13 @@ def ensure_autofill_dropdown_not_visible(self):
         checks if the parent pop up component has hidden attribute.
         """
         self.element_exists("pop-up-component")
-        self.expect_element_attribute_contains("pop-up-component", "hidden", "true")
+        popup_component = self.get_element("pop-up-component")
+        if len(popup_component.get_attribute("innerHTML")) > 1:
+            self.expect_element_attribute_contains(
+                "pop-up-component-box", "style", "0px;"
+            )
+        else:
+            self.expect_element_attribute_contains("pop-up-component", "hidden", "true")
         return self
 
     @BasePage.context_chrome
@@ -40,15 +46,7 @@ def ensure_autofill_dropdown_visible(self):
         Verifies that the autofill dropdown appears
         checks if the parent pop up component has hidden attribute.
         """
-        self.expect(
-            lambda _: len(
-                self.get_element("pop-up-component").get_attribute("innerHTML")
-            )
-            > 1
-        )
-        assert self.get_element("pop-up-component").get_attribute("hidden") is None, (
-            "Pop up autofill panel hidden."
-        )
+        self.element_clickable("pop-up-component-box")
         return self
 
     @BasePage.context_chrome
@@ -109,19 +107,16 @@ def select_nth_element(self, index: int):
         Arguments:
             index (int): The index of the element to retrieve (1-based)
         """
-        self.wait.until(
-            EC.element_to_be_clickable(
-                self.get_element("select-form-option-by-index", labels=[str(index)])
-            )
-        )
-        self.get_element("select-form-option-by-index", labels=[str(index)]).click()
+        self.element_clickable("select-form-option-by-index", labels=[str(index)])
+        self.click_on("select-form-option-by-index", labels=[str(index)])
 
     @BasePage.context_chrome
     def select_autofill_panel(self):
         """
         Select the first autofill panel in the autocomplete list.
         """
-        self.get_element("select-form-option-autofill").click()
+        self.element_clickable("select-form-option-autofill")
+        self.click_on("select-form-option-autofill")
         return self
 
     @BasePage.context_chrome

modules/data/autofill_popup.components.json

@@ -43,6 +43,11 @@
       "doNotCache"
     ]
   },
+  "pop-up-component-box": {
+    "selectorData": "#PopupAutoComplete richlistbox",
+    "strategy": "css",
+    "groups": []
+  },
   "select-form-option": {
     "selectorData": "#PopupAutoComplete .autocomplete-richlistitem",
     "strategy": "css",

modules/page_object_autofill.py

@@ -523,7 +523,7 @@ def sanitize_preview_data(self, field, value, region):
             value = self.util.normalize_regional_phone_numbers(value, region)
         return value
 
-    def select_autofill_option(self, field, index: int = 1):
+    def select_autofill_option(self, field):
         """
         Presses the autofill panel that pops up after you double-click an input field
 
@@ -537,7 +537,7 @@ def select_autofill_option(self, field, index: int = 1):
             autofill_field.clear()
             self.double_click("form-field", labels=[field])
             self.autofill_popup.ensure_autofill_dropdown_visible()
-            self.autofill_popup.select_nth_element(index)
+            self.autofill_popup.select_autofill_panel()
         else:
             logging.info(f"Field: {field} is a select element. No autofill option.")
         return self