vs/ test pdf download

Author: vsangereanMOZ

conftest.py

@@ -172,13 +172,13 @@ def downloads_folder(sys_platform):
     """Return the downloads folder location for this OS"""
     if sys_platform == "Windows":
         user = os.environ.get("USERNAME")
-        return f"C:\\Users\\{user}\\Downloads\\{file_name}"
+        return f"C:\\Users\\{user}\\Downloads"
     elif sys_platform == "Darwin":  # MacOS
         user = os.environ.get("USER")
-        return f"/Users/{user}/Downloads/{file_name}"
+        return f"/Users/{user}/Downloads"
     elif sys_platform == "Linux":
         user = os.environ.get("USER")
-        return f"/home/{user}/Downloads/{file_name}"
+        return f"/home/{user}/Downloads"
 
 
 @pytest.fixture()

modules/data/generic_pdf.components.json

@@ -33,7 +33,7 @@
         "groups": []
     },
 
-    "download": {
+    "download-button": {
         "selectorData": "download",
         "strategy": "id",
         "groups": []

tests/pdf_viewer/test_pdf_download.py

@@ -1,13 +1,9 @@
 import os
-import platform
 import time
 
 import pytest
-from pynput.keyboard import Controller, Key
-from selenium.webdriver import Firefox
-from selenium.webdriver.common.by import By
 
-from modules.browser_object_navigation import Navigation
+from selenium.webdriver import Firefox
 from modules.page_object import GenericPdf
 
 
@@ -16,45 +12,51 @@ def add_prefs():
     return []
 
 
-def test_pdf_download(driver: Firefox, fillable_pdf_url: str):
+@pytest.mark.headed
+def test_pdf_download(driver: Firefox, fillable_pdf_url: str, downloads_folder: str, sys_platform):
     """
     C3932: PDF files can be successfully downloaded via pdf.js
     """
-    GenericPdf(driver, pdf_url=fillable_pdf_url).open()
+    from pynput.keyboard import Controller, Key
+
+    pdf = GenericPdf(driver, pdf_url=fillable_pdf_url).open()
     keyboard = Controller()
 
     # Click the download button
-    download_button = driver.find_element(By.ID, "download")
+    download_button = pdf.get_element("download-button")
     download_button.click()
 
     # Allow time for the download dialog m to appear and pressing enter to download
     time.sleep(2)
+
+    if sys_platform == "Linux":
+        keyboard.press(Key.alt)
+        keyboard.press(Key.tab)
+        keyboard.release(Key.tab)
+        keyboard.release(Key.alt)
+        time.sleep(1)
+        keyboard.press(Key.alt)
+        keyboard.press(Key.tab)
+        keyboard.release(Key.tab)
+        keyboard.release(Key.alt)
+        time.sleep(1)
+        keyboard.press(Key.tab)
+        keyboard.release(Key.tab)
+        time.sleep(1)
+        keyboard.press(Key.tab)
+        keyboard.release(Key.tab)
+
     keyboard.press(Key.enter)
     keyboard.release(Key.enter)
 
     # Allow time for the download to complete
     time.sleep(2)
 
-    # Determine the platform and set the expected download path
-    this_platform = platform.system()
-    saved_pdf_location = ""
+    # Set the expected download path and the expected PDF name
     file_name = "i-9.pdf"
-
-    if this_platform == "Windows":
-        user = os.environ.get("USERNAME")
-        saved_pdf_location = f"C:\\Users\\{user}\\Downloads\\{file_name}"
-    elif this_platform == "Darwin":  # MacOS
-        user = os.environ.get("USER")
-        saved_pdf_location = f"/Users/{user}/Downloads/{file_name}"
-    elif this_platform == "Linux":
-        user = os.environ.get("USER")
-        saved_pdf_location = f"/home/{user}/Downloads/{file_name}"
+    saved_pdf_location = os.path.join(downloads_folder, file_name)
 
     # Verify if the file exists
-    assert os.path.exists(
-        saved_pdf_location
-    ), f"The file was not downloaded to {saved_pdf_location}."
+    assert os.path.exists(saved_pdf_location), f"The file was not downloaded to {saved_pdf_location}."
 
-    print(
-        f"Test passed: The file {file_name} has been downloaded and is present at {saved_pdf_location}."
-    )
+    print(f"Test passed: The file {file_name} has been downloaded and is present at {saved_pdf_location}.")