Add refactored test 118799

Author: soncuteanca

tests/bookmarks_and_history/test_history_menu_from_different_places.py

@@ -7,6 +7,7 @@
 from modules.browser_object_navigation import Navigation
 from modules.browser_object_panel_ui import PanelUi
 from modules.browser_object_tabbar import TabBar
+from modules.page_base import BasePage
 from modules.page_object_customize_firefox import CustomizeFirefox
 
 
@@ -15,11 +16,15 @@ def test_case():
     return "118799"
 
 
+# Single-use helper kept in test file (YAGNI). Avoids duplication and/or overengineering
+@BasePage.context_chrome
 def assert_elements_visibility(ui_object, elements: dict, source: str):
-    """Helper function to assert visibility of elements in a given UI source."""
+    """
+    Helper function to assert visibility of elements in a given UI source.
+    """
     for name, locator in elements.items():
         element = ui_object.get_element(locator)
-        assert element.is_displayed(), f"{name} should be visible in {source}"
+        assert element.is_displayed()
 
 
 def test_history_menu_in_different_places(driver: Firefox):
@@ -28,77 +33,74 @@ def test_history_menu_in_different_places(driver: Firefox):
     Toolbar)
     """
 
-    # 1. History options from Hamburger Menu
-    panel_ui = PanelUi(driver)
-    panel_ui.open_history_menu()
-
-    with driver.context(driver.CONTEXT_CHROME):
-        hamburger_menu_elements = {
-            "Back Button": "history-back-button",
-            "History Title": "history_title",
-            "Recently Closed Tabs": "panel-ui-history-recently-closed",
-            "Recently Closed Windows": "recently_closed_windows",
-            "Search History": "search_history",
-            "Clear Recent History": "clear-recent-history",
-            "Recent History": "recent_history",
-            "Manage History": "manage_history",
-        }
-        assert_elements_visibility(panel_ui, hamburger_menu_elements, "Hamburger Menu")
-
-    # 2. History options from Menu Bar
+    # 1. Verify History options from Hamburger Menu
+    panel = PanelUi(driver)
+    panel.open_history_menu()
+
+    hamburger_menu_elements = {
+        "Back Button": "history-back-button",
+        "History Title": "history_title",
+        "Recently Closed Tabs": "panel-ui-history-recently-closed",
+        "Recently Closed Windows": "recently_closed_windows",
+        "Search History": "search_history",
+        "Clear Recent History": "clear-recent-history",
+        "Recent History": "recent_history",
+        "Manage History": "manage_history",
+    }
+    assert_elements_visibility(panel, hamburger_menu_elements, "Hamburger Menu")
+
+    # 2. Verify History options from Menu Bar
     menu_bar = MenuBar(driver)
 
     if platform.system() != "Darwin":
         menu_bar.open_menu("History")
 
-        with driver.context(driver.CONTEXT_CHROME):
-            menu_bar_elements = {
-                "Show All History": "menu-bar-show-all-history",
-                "Clear Recent History": "menu-bar-clear-recent-history",
-                "Restore Previous Session": "menu-bar-restore-previous-session",
-                "Search History": "menu-bar-search-history",
-                "Recently Closed Tabs": "menu-bar-recently-closed-tabs",
-                "Recently Closed Windows": "menu-bar-recently-closed-windows",
-            }
-            assert_elements_visibility(menu_bar, menu_bar_elements, "Menu Bar")
+        menu_bar_elements = {
+            "Show All History": "menu-bar-show-all-history",
+            "Clear Recent History": "menu-bar-clear-recent-history",
+            "Restore Previous Session": "menu-bar-restore-previous-session",
+            "Search History": "menu-bar-search-history",
+            "Recently Closed Tabs": "menu-bar-recently-closed-tabs",
+            "Recently Closed Windows": "menu-bar-recently-closed-windows",
+        }
+        assert_elements_visibility(menu_bar, menu_bar_elements, "Menu Bar")
     else:
         print("Skipping Menu Bar verification on macOS")
 
-    # 3. History options from Toolbar (History and Library)
+    # 3. Verify History options from Toolbar (History and Library)
     customize_firefox = CustomizeFirefox(driver)
     tabs = TabBar(driver)
     nav = Navigation(driver)
 
-    panel_ui.navigate_to_customize_toolbar()
+    panel.navigate_to_customize_toolbar()
     customize_firefox.add_widget_to_toolbar("history")
 
     tabs.new_tab_by_button()
     tabs.switch_to_new_tab()
 
-    with driver.context(driver.CONTEXT_CHROME):
-        nav.click_on("history-button")
+    nav.click_on("history-button")
 
-        history_toolbar_elements = {
-            "Recently Closed Tabs": "toolbar-history-recently-closed-tabs",
-            "Recently Closed Windows": "toolbar-history-recently-closed-windows",
-            "Search History": "toolbar-history-search-history",
-            "Clear Recent History": "toolbar-history-clear-recent-history",
-            "Recent History": "toolbar-history-recent_history",
-            "Manage History": "toolbar-history-manage_history",
-        }
-        assert_elements_visibility(nav, history_toolbar_elements, "Toolbar History")
+    history_toolbar_elements = {
+        "Recently Closed Tabs": "toolbar-history-recently-closed-tabs",
+        "Recently Closed Windows": "toolbar-history-recently-closed-windows",
+        "Search History": "toolbar-history-search-history",
+        "Clear Recent History": "toolbar-history-clear-recent-history",
+        "Recent History": "toolbar-history-recent_history",
+        "Manage History": "toolbar-history-manage_history",
+    }
+    assert_elements_visibility(nav, history_toolbar_elements, "Toolbar History")
 
-        panel_ui.open_panel_menu()
-        panel_ui.navigate_to_customize_toolbar()
-        customize_firefox.add_widget_to_toolbar("library")
+    panel.open_panel_menu()
+    panel.navigate_to_customize_toolbar()
+    customize_firefox.add_widget_to_toolbar("library")
 
-        tabs.new_tab_by_button()
-        tabs.switch_to_new_tab()
+    tabs.new_tab_by_button()
+    tabs.switch_to_new_tab()
 
-        nav.click_on("library-button")
-        nav.click_on("library-history-submenu-button")
+    nav.click_on("library-button")
+    nav.click_on("library-history-submenu-button")
 
-        library_toolbar_elements = (
-            history_toolbar_elements  # Reuse the same locators from a different path
-        )
-        assert_elements_visibility(nav, library_toolbar_elements, "Toolbar Library")
+    library_toolbar_elements = (
+        history_toolbar_elements  # Reuse the same locators from a different path
+    )
+    assert_elements_visibility(nav, library_toolbar_elements, "Toolbar Library")