Merge pull request #728 from mozilla/philimon/remove_calvinklein

Philimon/remove_skip_in_calvinklein_US

Author: philimon-reset

choose_l10n_ci_set.py

@@ -89,7 +89,8 @@ def select_l10n_mappings(beta_version):
     beta_split = (beta_version % 3) + 1
     if os.path.exists(f"l10n_CM/beta_run_splits/l10n_split_{beta_split}.json"):
         with open(f"l10n_CM/beta_run_splits/l10n_split_{beta_split}.json", "r") as f:
-            return json.load(f)
+            current_split_mappings = {k: set(v) for k, v in json.load(f).items()}
+            return current_split_mappings
     else:
         return valid_l10n_mappings()
 

l10n_CM/README.md

@@ -31,6 +31,8 @@ The harness relies on several configuration files:
     ]
 }
 ```
+**NOTE**: If both the address and credit card tests are skipped for the site, do not add it to the region files.
+
 - **Site Test Configuration**: Located in `constants/{site_name}.json` or `constants/{site_name}/{region}.json`, defining site-specific test configurations and skipped tests. Here we map the attributes for either `AutofillAddressBase` or `CreditCardBase` to the corresponding selectors.
 
 ```aiignore

l10n_CM/constants/calvinklein/US/calvinklein_ad.json

@@ -10,9 +10,7 @@
     "email": "0c994dc2-4e0b-4734-8582-74ce9a1bff55",
     "telephone": "e1f86567-396f-473c-8666-47447f52d722"
   },
-
   "form_field": "*[data-moz-autofill-inspect-id='{given_name}']",
-  "skip": "True",
   "fields": [
     "5d2af5cb-8f6d-4fdc-8ae5-21c7e5e97a43",
     "82900c67-963c-40f8-b0ef-c986a2accc43",

l10n_CM/run_l10n.py

@@ -54,7 +54,7 @@
     "thenorthface",
     "zooplus",
     "zara",
-    "cocolita"
+    "cocolita",
 }
 
 loaded_valid_sites = valid_l10n_mappings().keys()

tests/tabs/test_open_new_bg_tab_via_mouse_and_keyboard.py

@@ -35,4 +35,4 @@ def test_open_new_bg_tab_via_mouse_and_keyboard(driver: Firefox):
     example.wait_for_num_tabs(2)
     example.switch_to_new_tab()
 
-    assert driver.current_url == test_url
+    assert driver.current_url == test_url