Skip to content

Commit 94cd5f3

Browse files
committed
fix missing logic
1 parent 6dd1127 commit 94cd5f3

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

l10n_CM/run_l10n.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"yellowkorner",
4040
"wish",
4141
"bijoubrigitte",
42-
"whittard"
42+
"whittard",
4343
}
4444

4545
loaded_valid_sites = valid_l10n_mappings().keys()

modules/testrail.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,12 @@ def create_new_plan_entry(
350350
payload["runs"] = runs
351351
return self.client.send_post(f"/add_plan_entry/{plan_id}", payload)
352352

353+
def update_plan(self, plan_id, **kwargs):
354+
"""Given a plan id, update the plan per kwargs"""
355+
if not kwargs:
356+
return False
357+
return self.client.send_post(f"/update_plan/{plan_id}", kwargs)
358+
353359
def update_plan_entry(self, plan_id, entry_id, **kwargs):
354360
"""Given a plan id and entry id, update the entry per kwargs"""
355361
if not kwargs:

modules/testrail_integration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def get_execution_link() -> str:
2828
if "TASKCLUSTER_PROXY_URL" in os.environ:
2929
link = TC_EXECUTION_TEMPLATE
3030
for item in ["RUN_ID", "TASK_ID"]:
31-
link = link.replace(f"%{item}", os.environ.get(item))
31+
link = link.replace(f"%{item}%", os.environ.get(item))
3232
return link
3333

3434

@@ -355,7 +355,7 @@ def organize_l10n_entries(
355355

356356
os_name = config.split(" ")[0]
357357
description = replace_link_in_description(expected_plan["description"], os_name)
358-
tr.update_plan_entry(plan_id, entry["id"], description)
358+
tr.update_plan(plan_id, description=description)
359359

360360
# There should only be one entry per site per plan
361361
# Check that this entry has a run with the correct config

0 commit comments

Comments
 (0)