fix for test_downloads_from_private_not_leaked

Author: philimon-reset

modules/browser_object_navigation.py

@@ -267,6 +267,12 @@ def open_tracker_panel(self) -> BasePage:
         self.get_element("shield-icon").click()
         return self
 
+    @BasePage.context_chrome
+    def click_file_download_warning_panel(self) -> BasePage:
+        """ exit file download warning panel if present """
+        self.element_clickable("file-download-warning-button")
+        self.click_on("file-download-warning-button")
+        return self
     def wait_for_item_to_download(self, filename: str) -> BasePage:
         """
         Check the downloads tool in the toolbar to wait for a given file to download

modules/data/navigation.components.json

@@ -393,6 +393,18 @@
         "groups": []
     },
 
+    "file-download-warning-panel": {
+        "selectorData": "downloadsPanel-privateBrowsing",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "file-download-warning-button": {
+        "selectorData": "button[data-l10n-id='downloads-private-browsing-accept-button']",
+        "strategy": "css",
+        "groups": []
+    },
+
     "bookmark-in-bar": {
         "selectorData": "toolbarbutton.bookmark-item",
         "strategy": "css",

tests/security_and_privacy/conftest.py

@@ -12,7 +12,7 @@ def suite_id():
 @pytest.fixture()
 def prefs_list(add_to_prefs_list: dict):
     """List of prefs to send to main conftest.py driver fixture"""
-    prefs = [("browser.urlbar.scotchBonnet.enableOverride", True)]
+    prefs = [("browser.urlbar.scotchBonnet.enableOverride", True), ("devtools.debugger.remote-enabled", True), ("devtools.chrome.enabled", True), ("ui.popup.disable_autohide", True)]
     prefs.extend(add_to_prefs_list)
     return prefs
 

tests/security_and_privacy/test_downloads_from_private_not_leaked.py

@@ -59,11 +59,16 @@ def test_downloads_from_private_not_leaked(driver: Firefox, delete_files, screen
         and el.is_displayed()
     ]
     # first link is large, skip it
+    panel_skipped = False
     for link in valid_links[1 : (NUM_LINKS + 1)]:
         target = link.get_attribute("href")
         logging.info(f"Downloading target {target}:")
         logging.info(link.text)
         link.click()
+        if not panel_skipped:
+            # skip download warning panel once.
+            nav.click_file_download_warning_panel()
+            panel_skipped = True
         nav.wait_for_item_to_download(target.split("/")[-1])
 
     # Check that everything looks good in About:Downloads