Method and docstring changes

Author: soncuteanca

tests/downloads/test_add_mime_type_doc.py

@@ -25,7 +25,7 @@ def delete_files_regex_string():
 
 def expected_app_name(sys_platform: str, opt_ci: bool) -> str:
     """
-    Decide which default application should be used to open .doc files, based on OS and CI environment
+    Decide which default application should be used to open .doc files, based on OS
     """
     if sys_platform == "Darwin":
         return "TextEdit" if opt_ci else "Pages"

tests/downloads/test_download_pdf.py

@@ -30,7 +30,7 @@ def test_download_pdf(
     C1756769 - Verify that the user can Download a PDF
 
     Notes:
-        - Firefox is launched with a **new profile** that has default download settings.
+        - Firefox is launched with a new profile (also a test case precondition) that has default download settings.
         - This means the OS-level "Save File" dialog will appear for every download.
         - Selenium cannot interact with this native dialog directly, so the test
           must rely on fixed waits to give the OS time to render the dialog and to
@@ -43,8 +43,7 @@ def test_download_pdf(
 
     # Click the download button
     pdf.open()
-    download_button = pdf.get_element("download-button")
-    download_button.click()
+    pdf.click_download_button()
 
     # Allow time for the download dialog to appear and pressing handle the prompt
     time.sleep(2)

tests/downloads/test_download_pdf_from_context_menu.py

@@ -28,18 +28,27 @@ def test_download_pdf_from_context_menu(
 ):
     """
     C1756790: Verify that Telemetry is Recorded when Saving a PDF from the Context menu
+
+     Notes:
+        - Firefox is launched with a new profile (also a test case precondition) that has default download settings.
+        - This means the OS-level "Save File" dialog will appear for every download.
+        - Selenium cannot interact with this native dialog directly, so the test
+          must rely on fixed waits to give the OS time to render the dialog and to
+          finish writing the file.
     """
 
     from pynput.keyboard import Controller
 
+    # Initialize objects
     pdf = GenericPdf(driver, pdf_url=fillable_pdf_url)
-    pdf.open()
     keyboard = Controller()
-    body = pdf.get_element("pdf-body")
+    context_menu = ContextMenu(driver)
+    about_telemetry = AboutTelemetry(driver)
 
-    # Right-click on the body of the file and select Save page as
+    # Open the PDF file, right-click on the body of the file and select "Save page as"
+    pdf.open()
+    body = pdf.get_element("pdf-body")
     pdf.context_click(body)
-    context_menu = ContextMenu(driver)
     context_menu.click_and_hide_menu("context-menu-save-page-as")
 
     # Allow time for the save dialog to appear and handle prompt
@@ -51,8 +60,8 @@ def test_download_pdf_from_context_menu(
     sleep(3)
 
     # Open about:telemetry and go to events tab
-    about_telemetry = AboutTelemetry(driver).open()
-    about_telemetry.get_element("events-tab").click()
+    about_telemetry.open()
+    about_telemetry.click_on("events-tab")
 
     # Verify that Telemetry is recorded
     pdf_telemetry_data = ["downloads", "added", "fileExtension", "pdf"]