add linux to workflow run

philimon-reset · philimon-reset · commit 9d708a78ee6e · 2025-07-03T17:59:17.000+02:00
diff --git a/.github/workflows/check-beta.yml b/.github/workflows/check-beta.yml
@@ -16,6 +16,7 @@ jobs:
       mac_reportable: ${{ steps.reportable.outputs.mac }}
       mac_l10n_reportable: ${{ steps.reportable.outputs.mac_l10n }}
       win_l10n_reportable: ${{ steps.reportable.outputs.win_l10n }}
+      linux_l10n_reportable: ${{ steps.reportable.outputs.linux_l10n }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -42,6 +43,7 @@ jobs:
         run: |
           echo win_l10n=$(pipenv run python -c 'from modules import testrail_integration as tri; print(tri.reportable("Windows"))') >> "$GITHUB_OUTPUT"
           echo mac_l10n=$(pipenv run python -c 'from modules import testrail_integration as tri; print(tri.reportable("Darwin"))') >> "$GITHUB_OUTPUT"
+          echo linux_l10n=$(pipenv run python -c 'from modules import testrail_integration as tri; print(tri.reportable("Linux"))') >> "$GITHUB_OUTPUT"
 
   Run-Win-Smoke:
     needs: Check-Beta-Version
@@ -73,4 +75,12 @@ jobs:
     uses: ./.github/workflows/l10n.yml
     with:
       job_to_run: L10N-Windows
+    secrets: inherit
+
+  Run-L10N-Linux-Smoke:
+    needs: Check-Beta-Version
+    if: ${{ needs.Check-Beta-Version.outputs.linux_l10n_reportable == 'True' }}
+    uses: ./.github/workflows/l10n.yml
+    with:
+      job_to_run: L10N-Linux
     secrets: inherit
diff --git a/.github/workflows/l10n.yml b/.github/workflows/l10n.yml
@@ -37,7 +37,7 @@ env:
 
 jobs:
   L10N-MacOS:
-    if: ${{ inputs.job_to_run == 'L10N-MacOS' || inputs.mac_installer_link }}
+    if: ${{ github.event_name == 'pull_request' || inputs.job_to_run == 'L10N-MacOS' || inputs.mac_installer_link }}
     runs-on: macos-latest
     steps:
       - name: Create app token
@@ -71,57 +71,57 @@ jobs:
           pip3 install 'ruff>=0.4.8,<0.5';
           rm ./pyproject.toml;
           mv ./ci_pyproject.toml ./pyproject.toml;
-          pipenv install
+          pipenv install;
       - name: Install Fx
         id: setup
         env:
           MANUAL_DOWNLOAD_LINK: ${{ inputs.mac_installer_link }}
         run:
-          echo app_name=$(bash ./collect_executables.sh | xargs -0 ./parse_executables.sh) >> "$GITHUB_OUTPUT"
+          echo app_name=$(bash ./collect_executables.sh | xargs -0 ./parse_executables.sh) >> "$GITHUB_OUTPUT";
       - name: Run L10N Tests in MacOS
         if: steps.setup.conclusion == 'success'
         env:
           FX_EXECUTABLE: /Volumes/${{ steps.setup.outputs.app_name }}/${{ steps.setup.outputs.app_name }}.app/Contents/MacOS/firefox
         run: |
-          "$FX_EXECUTABLE" --version
-          echo "0" > TEST_EXIT_CODE
-          pipenv run python check_l10n_test_cases.py
+          "$FX_EXECUTABLE" --version;
+          echo "0" > TEST_EXIT_CODE;
+          pipenv run python check_l10n_test_cases.py;
           while IFS= read -r line; do
-            echo "Running tests for: $line"
-            pipenv run python l10n_CM/run_l10n.py --fx-executable="$FX_EXECUTABLE" $line || SCRIPT_EXIT_CODE=$?
-          done < selected_l10n_mappings
-          mv artifacts artifacts-mac || true
-          EXIT_CODE=$(cat TEST_EXIT_CODE)
+            echo "Running tests for: $line";
+            pipenv run python l10n_CM/run_l10n.py --fx-executable="$FX_EXECUTABLE" $line || SCRIPT_EXIT_CODE=$?;
+          done < selected_l10n_mappings;
+          mv artifacts artifacts-mac || true;
+          EXIT_CODE=$(cat TEST_EXIT_CODE);
           if [ $EXIT_CODE != 0 ]; then
-            exit $EXIT_CODE
+            exit $EXIT_CODE;
           fi
-          exit $SCRIPT_EXIT_CODE
+          exit $SCRIPT_EXIT_CODE;
       - name: Run L10N Tests in MacOS (Headed)
         if: steps.setup.conclusion == 'success' && always()
         env:
           FX_EXECUTABLE: /Volumes/${{ steps.setup.outputs.app_name }}/${{ steps.setup.outputs.app_name }}.app/Contents/MacOS/firefox
           REPORTABLE: ${{ env.TESTRAIL_REPORT == 'true' }}
         run: |
           mv ./ci_l10n_pyproject_headed.toml ./pyproject.toml;
-          echo "0" > TEST_EXIT_CODE
+          echo "0" > TEST_EXIT_CODE;
           while IFS= read -r line; do
-            echo "Running tests for: $line"
-            pipenv run python l10n_CM/run_l10n.py --fx-executable="$FX_EXECUTABLE" $line || SCRIPT_EXIT_CODE=$?
-          done < selected_l10n_mappings
-          mv -n artifacts/* artifacts-mac/ || true
-          EXIT_CODE=$(cat TEST_EXIT_CODE)
+            echo "Running tests for: $line";
+            pipenv run python l10n_CM/run_l10n.py --fx-executable="$FX_EXECUTABLE" $line || SCRIPT_EXIT_CODE=$?;
+          done < selected_l10n_mappings;
+          mv -n artifacts/* artifacts-mac/ || true;
+          EXIT_CODE=$(cat TEST_EXIT_CODE);
           if [ $EXIT_CODE != 0 ]; then
-            exit $EXIT_CODE
+            exit $EXIT_CODE;
           fi
-          exit $SCRIPT_EXIT_CODE
+          exit $SCRIPT_EXIT_CODE;
       - name: Upload artifacts
         if: ${{ always() && github.event_name == 'pull_request' }}
         uses: actions/upload-artifact@v4
         with:
           name: artifacts-mac
           path: artifacts-mac
   L10N-Linux:
-    if: ${{ inputs.linux_tarball_link }}
+    if: ${{ github.event_name == 'pull_request' || inputs.job_to_run == 'L10N-Linux' || inputs.linux_tarball_link }}
     runs-on: ubuntu-latest
     steps:
       - name: Create app token
@@ -145,58 +145,60 @@ jobs:
         run: |
           echo "MANUAL='true'" >> "$GITHUB_ENV";
           echo "Running l10n tests on supplied executable";
-          sudo apt install gnome-screenshot
+          sudo apt install gnome-screenshot;
           uname -m;
           mkdir -p artifacts;
           pip3 install 'pipenv==2023.11.15';
           pip3 install 'ruff>=0.4.8,<0.5';
           rm ./pyproject.toml;
           mv ./ci_xvfb_pyproject.toml ./pyproject.toml;
           pipenv install;
-          ./collect_executables.sh
+          ./collect_executables.sh;
           ./firefox/firefox --version;
-          #. ./keyring-unlock.sh;
       - name: Run L10N Tests in Ubuntu
         if: steps.setup.conclusion == 'success'
         env:
           FX_EXECUTABLE: ./firefox/firefox
         run: |
-          "$FX_EXECUTABLE" --version
-          echo "0" > TEST_EXIT_CODE
-          pipenv run python check_l10n_test_cases.py
+          "$FX_EXECUTABLE" --version;
+          echo "0" > TEST_EXIT_CODE;
+          pipenv run python check_l10n_test_cases.py;
           Xvfb :99 -screen 0 '1600x1200x24' > artifacts/xvfb.log &
           while IFS= read -r line; do
-            echo "Running tests for: $line"
-            DISPLAY=:99 pipenv run python l10n_CM/run_l10n.py --fx-executable="$FX_EXECUTABLE" $line || SCRIPT_EXIT_CODE=$?
-          done < selected_l10n_mappings
-          mv artifacts artifacts-mac || true
-          EXIT_CODE=$(cat TEST_EXIT_CODE)
+            echo "Running tests for: $line";
+            DISPLAY=:99 pipenv run python l10n_CM/run_l10n.py --fx-executable="$FX_EXECUTABLE" $line || SCRIPT_EXIT_CODE=$?;
+          done < selected_l10n_mappings;
+          mv artifacts artifacts-linux || true;
+          EXIT_CODE=$(cat TEST_EXIT_CODE);
           if [ $EXIT_CODE != 0 ]; then
-            exit $EXIT_CODE
+            exit $EXIT_CODE;
           fi
-          exit $SCRIPT_EXIT_CODE
+          exit $SCRIPT_EXIT_CODE;
       - name: Run Smoke Tests in Ubuntu (Headed)
         if: steps.setup.conclusion == 'success' && always()
         env:
           FX_EXECUTABLE: ./firefox/firefox
         run: |
           mv ./ci_xvfb_pyproject_headed.toml ./pyproject.toml;
-          echo "0" > TEST_EXIT_CODE
+          echo "0" > TEST_EXIT_CODE;
           while IFS= read -r line; do
-            echo "Running tests for: $line"
-            DISPLAY=:99 pipenv run python l10n_CM/run_l10n.py --fx-executable="$FX_EXECUTABLE" $line || SCRIPT_EXIT_CODE=$?
-          done < selected_l10n_mappings
-          mv -n artifacts/* artifacts-mac/ || true
-          EXIT_CODE=$(cat TEST_EXIT_CODE)
+            echo "Running tests for: $line";
+            DISPLAY=:99 pipenv run python l10n_CM/run_l10n.py --fx-executable="$FX_EXECUTABLE" $line || SCRIPT_EXIT_CODE=$?;
+          done < selected_l10n_mappings;
+          mv -n artifacts/* artifacts-linux/ || true;
+          EXIT_CODE=$(cat TEST_EXIT_CODE);
           if [ $EXIT_CODE != 0 ]; then
-            exit $EXIT_CODE
+            exit $EXIT_CODE;
           fi
-          exit $SCRIPT_EXIT_CODE
-
-
-
+          exit $SCRIPT_EXIT_CODE;
+      - name: Upload artifacts
+        if: ${{ always() && github.event_name == 'pull_request' }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: artifacts-linux
+          path: artifacts-linux
   L10N-Windows:
-    if: ${{ inputs.job_to_run == 'L10N-Windows' || inputs.win_installer_link }}
+    if: ${{ github.event_name == 'pull_request' || inputs.job_to_run == 'L10N-Windows' || inputs.win_installer_link }}
     runs-on: windows-latest
     steps:
       - name: Create app token
@@ -338,6 +340,7 @@ jobs:
     needs:
       - L10N-Windows
       - L10N-MacOS
+      - L10N-Linux
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -354,13 +357,20 @@ jobs:
         with:
           name: artifacts-win
           path: artifacts-win
+      - name: Download Windows artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: artifacts-linux
+          path: artifacts-linux
       - name: Download MacOS artifact
         uses: actions/download-artifact@v4
         with:
           name: artifacts-mac
           path: artifacts-mac
-      - name: List downloaded files
+      - name: List downloaded Windows files
         run: ls artifacts-win/
+      - name: List downloaded Linux files
+        run: ls artifacts-linux/
       - name: List downloaded MacOS files
         run: ls artifacts-mac/
       - name: Run script with secret
diff --git a/notifier.py b/notifier.py
@@ -74,10 +74,13 @@ def list_and_write(source_directory: str, links: List[str]):
                 f.write(contents)
 
 
-def compile_link_file(links_win: List[str], links_mac: List[str]):
+def compile_link_file(
+    links_win: List[str], links_mac: List[str], links_linux: List[str] = []
+):
     print("Compiling the current artifact link file...")
     links_mac.sort()
     links_win.sort()
+    links_linux.sort()
 
     output_file_path = os.path.join(time_now, "full_report.txt")
     content_type = get_content_type(output_file_path)
@@ -94,12 +97,18 @@ def compile_link_file(links_win: List[str], links_mac: List[str]):
 
         for url in links_mac:
             f.write(url + "\n")
+
+        f.write("\nLinux Artifacts:\n\n")
+
+        for url in links_linux:
+            f.write(url + "\n")
     return f"{root_url}{time_now}/full_report.txt"
 
 
 time_now = get_current_timestamp()
 links_win = []
 links_mac = []
+links_linux = []
 root_url = "https://storage.googleapis.com/notifier-artifact-bucket/"
 report_file = ""
 
@@ -114,12 +123,13 @@ def compile_link_file(links_win: List[str], links_mac: List[str]):
     bucket = storage_client.bucket(bucket_name)
     list_and_write("artifacts-mac", links_mac)
     list_and_write("artifacts-win", links_win)
+    list_and_write("artifacts-linux", links_linux)
 except Exception as e:
     print("The artifact upload process ran into some issues: ", e)
 
 
 try:
-    report_file = compile_link_file(links_win, links_mac)
+    report_file = compile_link_file(links_win, links_mac, links_linux)
 except Exception as e:
     print(f"The link compilation had some issues: {e}")
 
