Skip to content

Commit abbf8f2

Browse files
committed
changes from another test
1 parent 9cee0ad commit abbf8f2

File tree

1 file changed

+25
-31
lines changed

1 file changed

+25
-31
lines changed

modules/browser_object_reader_view.py

Lines changed: 25 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -14,72 +14,66 @@ def open_reader_view_searchbar(self) -> BasePage:
1414
"""
1515
Opens the reader view using the search bar
1616
"""
17+
before_page_source = self.driver.page_source
1718
with self.driver.context(self.driver.CONTEXT_CHROME):
1819
self.get_element("reader-view-button").click()
20+
self.wait.until(lambda _: self.driver.page_source != before_page_source)
1921
self.wait_for_reader_view_open()
2022
return self
2123

2224
def open_reader_view_keys(self) -> BasePage:
2325
"""
2426
Opens the reader view using keys
2527
"""
26-
if self.sys_platform() == "Darwin":
27-
self.actions.key_down(Keys.COMMAND).key_down(Keys.ALT).send_keys(
28-
"r"
29-
).key_up(Keys.ALT).key_up(Keys.COMMAND).perform()
30-
elif self.sys_platform() == "Linux":
31-
self.actions.key_down(Keys.CONTROL).key_down(Keys.ALT).send_keys(
32-
"r"
33-
).key_up(Keys.ALT).key_up(Keys.CONTROL).perform()
34-
else:
35-
self.actions.send_keys(Keys.F9).perform()
28+
before_page_source = self.driver.page_source
29+
with self.driver.context(self.driver.CONTEXT_CHROME):
30+
if self.sys_platform() == "Darwin":
31+
self.perform_key_combo(Keys.COMMAND, Keys.ALT, "r")
32+
elif self.sys_platform() == "Linux":
33+
self.perform_key_combo(Keys.CONTROL, Keys.ALT, "r")
34+
else:
35+
self.perform_key_combo(Keys.F9)
36+
self.wait.until(lambda _: self.driver.page_source != before_page_source)
3637
self.wait_for_reader_view_open()
3738
return self
3839

3940
def close_reader_view_searchbar(self) -> BasePage:
4041
"""
4142
Closes the reader view using the search bar
4243
"""
44+
before_page_source = self.driver.page_source
4345
with self.driver.context(self.driver.CONTEXT_CHROME):
4446
self.get_element("reader-view-button").click()
47+
self.wait.until(lambda _: self.driver.page_source != before_page_source)
4548
self.wait_for_reader_view_closed()
4649
return self
4750

48-
def close_reader_view_toolbar(self) -> BasePage:
49-
"""
50-
Closes the reader view using the toolbar
51-
"""
52-
self.get_element("reader-toolbar-close").click()
53-
self.wait_for_reader_view_closed()
54-
return self
55-
56-
def close_reader_view_keys(self, sys_platform: str) -> BasePage:
51+
def close_reader_view_keys(self) -> BasePage:
5752
"""
5853
Closes the reader view using keys
5954
"""
60-
if sys_platform == "Darwin":
61-
self.actions.key_down(Keys.COMMAND).key_down(Keys.ALT).send_keys(
62-
"r"
63-
).key_up(Keys.ALT).key_up(Keys.COMMAND).perform()
64-
elif sys_platform == "Linux":
65-
self.actions.key_down(Keys.CONTROL).key_down(Keys.ALT).send_keys(
66-
"r"
67-
).key_up(Keys.ALT).key_up(Keys.CONTROL).perform()
68-
else:
69-
self.actions.send_keys(Keys.F9).perform()
55+
before_page_source = self.driver.page_source
56+
with self.driver.context(self.driver.CONTEXT_CHROME):
57+
if self.sys_platform() == "Darwin":
58+
self.perform_key_combo(Keys.COMMAND, Keys.ALT, "r")
59+
elif self.sys_platform() == "Linux":
60+
self.perform_key_combo(Keys.CONTROL, Keys.ALT, "r")
61+
else:
62+
self.perform_key_combo(Keys.F9)
63+
self.wait.until(lambda _: self.driver.page_source != before_page_source)
7064
self.wait_for_reader_view_closed()
7165
return self
7266

7367
def wait_for_reader_view_open(self) -> BasePage:
7468
"""
7569
Checks to see if the reader view toolbar is present demonstrating that the reader view is open.
7670
"""
77-
self.wait.until(lambda _: self.element_exists("reader-toolbar"))
71+
self.element_exists("reader-toolbar")
7872
return self
7973

8074
def wait_for_reader_view_closed(self) -> BasePage:
8175
"""
8276
Checks to see if the reader view toolbar is not present, demonstrating that reader view is not open.
8377
"""
84-
self.wait.until(lambda _: self.element_does_not_exist("reader-toolbar"))
78+
self.element_does_not_exist("reader-toolbar")
8579
return self

0 commit comments

Comments
 (0)