parameterize and comment

Author: sarinali

modules/data/about_prefs.components.json

@@ -220,5 +220,11 @@
         "selectorData": "menuitem[data-l10n-id=\"home-mode-choice-default-fx\"]",
         "strategy": "css",
         "groups": []
+    },
+
+    "language-dropdown": {
+        "selectorData": "primaryBrowserLocale",
+        "strategy": "id",
+        "groups": []
     }
 }

modules/page_object_about_prefs.py

@@ -46,7 +46,7 @@ def __init__(self, page, **kwargs):
         def loaded(self):
             return self.root if EC.element_to_be_clickable(self.root) else False
 
-        def select_option(self, option_name: str):
+        def select_option(self, option_name: str, double_click=False):
             """Select an option in the dropdown. Does not return self."""
             if not self.dropmarker.get_attribute("open") == "true":
                 self.root.click()
@@ -58,8 +58,11 @@ def select_option(self, option_name: str):
             if len(matching_menuitems) == 0:
                 return False
             elif len(matching_menuitems) == 1:
-                matching_menuitems[0].click()
-                self.wait.until(EC.element_to_be_selected(matching_menuitems[0]))
+                if double_click:
+                    AboutPrefs(self.driver).double_click(reference=matching_menuitems[0])
+                else:
+                    matching_menuitems[0].click()
+                    self.wait.until(EC.element_to_be_selected(matching_menuitems[0]))
                 return self
             else:
                 raise ValueError("More than one menu item matched search string")

tests/language_packs/test_language_pack_install_addons.py

@@ -1,27 +1,27 @@
+import pytest
 from selenium.webdriver import Firefox
 
-# from modules.page_object import AboutAddons, AboutPrefs
-from modules.page_object import AboutAddons, GenericPage
+from modules.page_object import AboutAddons, GenericPage, AboutPrefs
 
-# from modules.util import Utilities
 
 LANGUAGE_ADDONS_LINK = "https://addons.mozilla.org/en-US/firefox/language-tools/"
+LANGUAGES = [("Italiano", "it", "Imposta alternative…")]
 
-
-def test_language_pack_install_from_addons(driver: Firefox):
+@pytest.mark.parametrize("drop_down_name, shortform, localized_text", LANGUAGES)
+def test_language_pack_install_from_addons(driver: Firefox, drop_down_name: str, shortform: str, localized_text: str):
     """
     C1549408: verify that installing a language pack from about:addons will correctly change the locale
     """
-    # about_prefs = AboutPrefs(driver, category="general")
+    # declaring objects and navigating
     generic_page = GenericPage(driver)
-    # util = Utilities()
-
     driver.get(LANGUAGE_ADDONS_LINK)
 
+    # ensuring the page was loaded
     generic_page.custom_wait(timeout=20).until(
         lambda _: generic_page.get_element("language-addons-title") is not None
     )
 
+    # grab the appropriate link and wait until the page is loaded
     language_row = generic_page.get_element("language-addons-row")
     generic_page.get_element(
         "language-addons-row-link", parent_element=language_row
@@ -38,13 +38,24 @@ def test_language_pack_install_from_addons(driver: Firefox):
         # click second time for "Okay", the button is not cached which allows for two different buttons to be different
         generic_page.get_element("language-install-popup-add").click()
 
+    # ensure that the about:addons has the language listed
     about_addons = AboutAddons(driver).open()
     about_addons.choose_sidebar_option("locale")
-
     addon_list_parent = about_addons.get_element("languages-addon-list")
     addon_language_cards = about_addons.get_element(
         "languages-addon-list-card", multiple=True, parent_element=addon_list_parent
     )
 
     # making sure that 1 language was installed
     assert len(addon_language_cards) == 1
+
+    # perform language changing and assertions in about_prefs
+    about_prefs = AboutPrefs(driver, category="general").open()
+    language_dropdown = about_prefs.get_element("language-dropdown")
+    dropdown = about_prefs.Dropdown(page=about_prefs, root=language_dropdown)
+    dropdown.select_option(drop_down_name, double_click=True)
+
+    about_prefs.custom_wait(timeout=15).until(
+        lambda _: about_prefs.get_element("html-root").get_attribute("lang") == shortform
+    )
+    assert about_prefs.get_element("language-set-alternatives-button").get_attribute("label") == localized_text

tests/language_packs/test_language_pack_install_preferences.py

@@ -1,10 +1,13 @@
+import pytest
 from selenium.webdriver import Firefox
 
 from modules.page_object import AboutPrefs
 from modules.util import BrowserActions
 
+LANGUAGES = [("it", "Imposta alternative…")]
 
-def test_language_pack_install_about_preferences(driver: Firefox):
+@pytest.mark.parametrize("shortform, localized_text", LANGUAGES)
+def test_language_pack_install_about_preferences(driver: Firefox, shortform: str, localized_text: str):
     """
     C1549409: language packs can be installed from about:preferences and firefox is correctly localized
     """
@@ -49,5 +52,7 @@ def test_language_pack_install_about_preferences(driver: Firefox):
 
     # final asserts to ensure language is set
     ba.switch_to_content_context()
-    assert about_prefs.get_element("html-root").get_attribute("lang") == "it"
-    assert alternative_button.get_attribute("label") == "Imposta alternative…"
+    about_prefs.custom_wait(timeout=15).until(
+        lambda _: about_prefs.get_element("html-root").get_attribute("lang") == shortform
+    )
+    assert alternative_button.get_attribute("label") == localized_text