Bc/papercuts from batch 2 (#102)

* fix search sugg pref test, papercuts

* from time import sleep

* spelling in tabs suite

* fix the fixes

Author: ben-c-at-moz

modules/data/about_newtab.components.json

@@ -2,9 +2,7 @@
     "incontent-search-input": {
         "selectorData": "fake-editable",
         "strategy": "class",
-        "groups": [
-            "requiredForPage"
-        ]
+        "groups": []
     },
 
     "loaded-image": {
@@ -25,20 +23,40 @@
         "groups": []
     },
 
-    "top-sites-list": {
-        "selectorData": "top-sites-list",
+    "sponsored-site-card": {
+        "selectorData": "top-site-outer",
         "strategy": "class",
         "groups": [
-            "requiredForPage"
+            "requiredForPage",
+            "doNotCache"
         ]
     },
 
+    "top-site-image-by-index": {
+        "selectorData": ".top-sites-list li:nth-of-type({index}) .top-site-icon.rich-icon",
+        "strategy": "css",
+        "groups": []
+    },
+
+    "sponsored-site-card-menu-button": {
+        "selectorData": "button[class=\"context-menu-button icon\"]",
+        "strategy": "css",
+        "groups": [
+            "doNotCache"
+        ]
+    },
+
+
+    "top-sites-list": {
+        "selectorData": "top-sites-list",
+        "strategy": "class",
+        "groups": []
+    },
+
     "recommended-by-pocket-list": {
         "selectorData": "ds-card-grid-include-descriptions",
         "strategy": "class",
-        "groups": [
-            "requiredForPage"
-        ]
+        "groups": []
     },
 
     "article-description": {
@@ -58,9 +76,7 @@
     "popular-topics-list": {
         "selectorData": ".ds-navigation > ul",
         "strategy": "css",
-        "groups": [
-            "requiredForPage"
-        ]
+        "groups": []
     },
 
     "recent-activity-section": {
@@ -73,5 +89,21 @@
         "selectorData": "//div[following-sibling::div[@class='section-top-bar']]",
         "strategy": "xpath",
         "groups": []
+    },
+
+    "sponsored-site-context-menu": {
+        "selectorData": "context-menu",
+        "strategy": "class",
+        "groups": [
+            "doNotCache"
+        ]
+    },
+
+    "sponsored-site-context-menu-list": {
+        "selectorData": "ul[class=\"context-menu-list\"]",
+        "strategy": "css",
+        "groups": [
+            "doNotCache"
+        ]
     }
 }

modules/data/about_prefs.components.json

@@ -135,6 +135,12 @@
         "groups": []
     },
 
+    "show-suggestions": {
+        "selectorData": "checkbox[data-l10n-id='search-show-suggestions-option']",
+        "strategy": "css",
+        "groups": []
+    },
+
     "firefox-suggest-nonsponsored": {
         "selectorData": "firefoxSuggestNonsponsored",
         "strategy": "id",

modules/data/navigation.components.json

@@ -169,9 +169,9 @@
     },
 
     "firefox-suggest": {
-    "selectorData": "div.urlbarView-row[label=\"Firefox Suggest\"] > span.urlbarView-row-inner",
-    "strategy": "css",
-    "groups": []
+        "selectorData": "div.urlbarView-row[label=\"Firefox Suggest\"] > span.urlbarView-row-inner",
+        "strategy": "css",
+        "groups": []
     },
 
     "search-result-autofill-adaptive-element": {
@@ -180,33 +180,9 @@
         "groups": []
     },
 
-    "sponsored-site-card": {
-        "selectorData": "top-site-outer",
-        "strategy": "class",
-        "groups": []
-    },
-
-    "sponsored-site-card-menu-button": {
-        "selectorData": "button[class=\"context-menu-button icon\"]",
-        "strategy": "css",
-        "groups": []
-    },
-
-    "sponsored-site-context-menu": {
-        "selectorData": "context-menu",
-        "strategy": "class",
-        "groups": []
-    },
-
-    "sponsored-site-context-menu-list": {
-        "selectorData": "ul[class=\"context-menu-list\"]",
-        "strategy": "css",
-        "groups": []
-    },
-
     "search-result": {
-    "selectorData": "//div[@data-text-ad]//a",
-    "strategy": "xpath",
-    "groups": []
+        "selectorData": "//div[@data-text-ad]//a",
+        "strategy": "xpath",
+        "groups": []
     }
 }

modules/page_object_about_config.py

@@ -49,4 +49,3 @@ def change_pref_value(self, term: str, value) -> BasePage:
         pref_edit.send_keys(value)
         pref_edit_button.click()
         return self
-