Bc/ergo menus and tabs (#126)

* write test

* fix broken context split in menus

* stop hiding by child

* click and hide

* finish test

* change click_and_hide to basepage

* skip new fxa for now

* clean up ergo for context menu clicking

Author: ben-c-at-moz

modules/browser_object.py

@@ -3,6 +3,7 @@
 from modules.browser_object_credit_card_popup import *
 from modules.browser_object_devtools import *
 from modules.browser_object_find_toolbar import *
+from modules.browser_object_hyperlink_context_menu import *
 from modules.browser_object_image_context_menu import *
 from modules.browser_object_navigation import *
 from modules.browser_object_panel_ui import *

modules/browser_object_context_menu.py

@@ -12,13 +12,7 @@ class ContextMenu(BasePage):
 
     URL_TEMPLATE = ""
 
-    def get_context_item(self, item: str) -> WebElement:
-        """
-        Gets the context menu item from the context menu
-        """
-        with self.driver.context(self.driver.CONTEXT_CHROME):
-            return self.get_element(item)
-
+    
     def click_context_item(
         self, reference: Union[str, tuple, WebElement], labels=[]
     ) -> BasePage:
@@ -27,12 +21,4 @@ def click_context_item(
         """
         with self.driver.context(self.driver.CONTEXT_CHROME):
             self.fetch(reference, labels=labels).click()
-            return self
-
-    def click_and_hide(
-        self, reference: Union[str, tuple, WebElement], labels=[]
-    ) -> BasePage:
-        with self.driver.context(self.driver.CONTEXT_CHROME):
-            self.fetch(reference, labels=labels).click()
-            self.hide_popup_by_child_node(reference, labels=labels)
-            return self
+            return self

modules/browser_object_tabbar.py

@@ -104,10 +104,19 @@ def get_tab(self, identifier: Union[str, int]) -> Union[WebElement, None]:
             else:
                 # if we get an unexpected type, we shouldn't assume that the user wants sys exit
                 # but we have to cause problems for them nonetheless
-                assert False
+                assert False, "Error getting tab root"
                 tab = None
             return tab
 
+    def is_pinned(self, tab_root: WebElement) -> bool:
+        """Is this tab pinned?"""
+        with self.driver.context(self.driver.CONTEXT_CHROME):
+            pinned = tab_root.get_attribute("pinned")
+            if pinned in ["true", "false"]:
+                return pinned == "true"
+            else:
+                assert False, "Error checking tab pinned status"
+
     def click_tab_mute_button(self, identifier: Union[str, int]) -> BasePage:
         """Click the tab icon overlay, no matter what's happening with media"""
         logging.info(f"toggling tab mute for {identifier}")

modules/data/hyperlink_context_menu.components.json

@@ -1,4 +1,5 @@
 {
+    "context": "chrome",
     "do-not-cache": true,
     "context-menu-open-in-new-window": {
         "selectorData": "context-openlink",

modules/page_base.py

@@ -508,6 +508,15 @@ def context_click(
             self.actions.context_click(el).perform()
         return self
 
+    def click_and_hide_menu(
+        self, reference: Union[str, tuple, WebElement], labels=[]
+    ) -> Page:
+        """Click an option in a context menu, then hide it"""
+        with self.driver.context(self.driver.CONTEXT_CHROME):
+            self.fetch(reference, labels=labels).click()
+            self.hide_popup_by_child_node(reference, labels=labels)
+            return self
+
     def hover(self, reference: Union[str, tuple, WebElement], labels=[]):
         """
         Hover over the specified element.

tests/address_bar_and_search/test_search_code_google_non_us.py

@@ -61,8 +61,7 @@ def search_code_assert():
         h1_tag = (By.TAG_NAME, "h1")
         example.triple_click(h1_tag)
         example.context_click(h1_tag)
-    context_menu.get_context_item("context-menu-search-selected-text").click()
-    nav.hide_popup("contentAreaContextMenu")
+    context_menu.click_and_hide_menu("context-menu-search-selected-text")
 
     # Switch to the newly opened tab and run the code check
     window_handles = driver.window_handles

tests/address_bar_and_search/test_search_code_google_us.py

@@ -51,8 +51,7 @@ def search_code_assert():
         h1_tag = (By.TAG_NAME, "h1")
         example.triple_click(h1_tag)
         example.context_click(h1_tag)
-    context_menu.get_context_item("context-menu-search-selected-text").click()
-    nav.hide_popup("contentAreaContextMenu")
+    context_menu.click_and_hide_menu("context-menu-search-selected-text")
 
     # Switch to the newly opened tab and run the code check
     window_handles = driver.window_handles

tests/menus/test_copy_paste_actions.py

@@ -27,18 +27,14 @@ def test_login_form_copy_paste(driver: Firefox):
     # triple click and copy text
     login_fill.triple_click("login-input-field", labels=["current-password"])
     login_fill.context_click(password_field)
-    with driver.context(driver.CONTEXT_CHROME):
-        context_menu.get_context_item("context-menu-copy").click()
-        login_fill.hide_popup("contentAreaContextMenu")
+    context_menu.click_and_hide_menu("context-menu-copy")
 
     # delete all text
     password_field.send_keys(Keys.BACK_SPACE)
     assert password_field.get_attribute("value") == ""
 
     login_fill.context_click(password_field)
-    with driver.context(driver.CONTEXT_CHROME):
-        context_menu.get_context_item("context-menu-paste").click()
-        login_fill.hide_popup("contentAreaContextMenu")
+    context_menu.click_and_hide_menu("context-menu-paste")
 
     # final assertion
     assert password_field.get_attribute("value") != random_text
@@ -59,18 +55,14 @@ def test_text_area_copy_paste(driver: Firefox):
     # copy the text
     text_area_fill.triple_click("street-address-textarea")
     text_area_fill.context_click(text_area)
-    with driver.context(driver.CONTEXT_CHROME):
-        context_menu.get_context_item("context-menu-copy").click()
-        text_area_fill.hide_popup("contentAreaContextMenu")
+    context_menu.click_and_hide_menu("context-menu-copy")
 
     # delete all the text and paste
     text_area.send_keys(Keys.BACK_SPACE)
     assert text_area.get_attribute("value") == ""
 
     text_area_fill.context_click(text_area)
-    with driver.context(driver.CONTEXT_CHROME):
-        context_menu.get_context_item("context-menu-paste").click()
-        text_area_fill.hide_popup("contentAreaContextMenu")
+    context_menu.click_and_hide_menu("context-menu-paste")
 
     # check value
     assert text_area.get_attribute("value") == random_text
@@ -93,19 +85,15 @@ def test_search_field_copy_paste(driver: Firefox):
 
     # context click
     google_search.context_click(search_bar)
-    with driver.context(driver.CONTEXT_CHROME):
-        context_menu.get_context_item("context-menu-copy").click()
-        google_search.hide_popup("contentAreaContextMenu")
+    context_menu.click_and_hide_menu("context-menu-copy")
 
     # delete the current text
     search_bar.send_keys(Keys.BACK_SPACE)
     assert search_bar.get_attribute("value") == ""
 
     # context click and paste the text back
     google_search.context_click(search_bar)
-    with driver.context(driver.CONTEXT_CHROME):
-        context_menu.get_context_item("context-menu-paste").click()
-        google_search.hide_popup("contentAreaContextMenu")
+    context_menu.click_and_hide_menu("context-menu-paste")
 
     # assert the value is correct
     assert search_bar.get_attribute("value") == random_text

tests/menus/test_frequently_used_context_menu.py

@@ -30,9 +30,7 @@ def test_save_page_as(driver: Firefox):
     title_header = example_page.get_element("title-header")
     example_page.context_click(title_header)
 
-    save_page_as = context_menu.get_context_item("context-menu-save-page-as")
-    context_menu.click_context_item(save_page_as)
-    context_menu.hide_popup_by_child_node(save_page_as)
+    context_menu.click_and_hide_menu("context-menu-save-page-as")
 
     downloads_button = nav.get_download_button()
 
@@ -85,9 +83,7 @@ def test_take_screenshot(driver: Firefox):
     example_page.context_click(title_header)
 
     # context click the screenshot option and verify its not hidden
-    take_screenshot = context_menu.get_context_item("context-menu-take-screenshot")
-    context_menu.click_context_item(take_screenshot)
-    context_menu.hide_popup_by_child_node(take_screenshot)
+    context_menu.click_and_hide_menu("context-menu-take-screenshot")
 
     with driver.context(driver.CONTEXT_CHROME):
         screenshot_box = example_page.get_element("take-screenshot-box")
@@ -108,7 +104,6 @@ def test_inspect(driver: Firefox):
     title_header = example_page.get_element("title-header")
     example_page.context_click(title_header)
 
-    inspect_option = context_menu.get_context_item("context-menu-inspect")
-    context_menu.click_context_item(inspect_option)
-    context_menu.hide_popup_by_child_node(inspect_option)
+    context_menu.click_and_hide_menu("context-menu-inspect")
+
     devtools.check_opened()

tests/menus/test_hyperlink_context_menu.py

@@ -1,94 +1,51 @@
 from selenium.webdriver import Firefox
-from selenium.webdriver.common.by import By
-from selenium.webdriver.support import expected_conditions as EC
 
-from modules.browser_object import Navigation, TabBar
-from modules.browser_object_hyperlink_context_menu import HyperlinkContextMenu
+from modules.browser_object import HyperlinkContextMenu, Navigation, TabBar
+from modules.page_object import ExamplePage
 
 
 def test_open_link_in_new_window(driver: Firefox):
     """
     C2637621.2: open link in new window
     """
-    nav = Navigation(driver).open()
     hyperlink_context = HyperlinkContextMenu(driver)
     tabs = TabBar(driver)
+    example = ExamplePage(driver)
+    example.open()
 
     # right click the hyperlink
-    nav.open()
-    driver.get("https://example.com")
-    hyperlink = driver.find_element(By.LINK_TEXT, "More information...")
-    hyperlink_context.context_click(hyperlink)
+    example.context_click("more-information")
 
     # click on the open in new window option
-
-    open_in_new_window = hyperlink_context.get_context_item(
-        "context-menu-open-in-new-window"
-    )
-    hyperlink_context.click_context_item(open_in_new_window)
-    hyperlink_context.hide_popup("contentAreaContextMenu", chrome=True)
+    hyperlink_context.click_and_hide_menu("context-menu-open-in-new-window")
 
     # verify there are two instances (two windows)
     tabs.wait_for_num_tabs(2)
     driver.switch_to.window(driver.window_handles[1])
 
-    with driver.context(driver.CONTEXT_CONTENT):
-        nav.expect(EC.title_contains("Example Domains"))
-        assert driver.current_url == "https://www.iana.org/help/example-domains"
-
-
-def test_open_link_in_private_window(driver: Firefox):
-    """
-    C2637621.3: open link in new window (private)
-    """
-    nav = Navigation(driver).open()
-    hyperlink_context = HyperlinkContextMenu(driver)
-    tabs = TabBar(driver)
-
-    # right click the hyperlink
-    nav.open()
-    driver.get("https://example.com")
-    hyperlink = driver.find_element(By.LINK_TEXT, "More information...")
-    hyperlink_context.context_click(hyperlink)
-
-    # click on the open in new window option
-    open_in_new_window = hyperlink_context.get_context_item(
-        "context-menu-open-in-private-window"
-    )
-    hyperlink_context.click_context_item(open_in_new_window)
-    hyperlink_context.hide_popup("contentAreaContextMenu", chrome=True)
-
-    # verify there are two instances (two windows)
-    tabs.wait_for_num_tabs(2)
-    driver.switch_to.window(driver.window_handles[1])
+    example.title_contains(example.MORE_INFO_TITLE)
+    example.url_contains(example.MORE_INFO_URL)
 
-    with driver.context(driver.CONTEXT_CONTENT):
-        nav.expect(EC.title_contains("Example Domains"))
-        assert driver.current_url == "https://www.iana.org/help/example-domains"
 
-    # verify its in private mode
-    with driver.context(driver.CONTEXT_CHROME):
-        nav.element_exists("private-browsing-icon")
+"""
+C2637621.3: open link in new window (private) already covered
+"""
 
 
 def test_copy_link(driver: Firefox):
     """
     C2264627.4: Copy the link and verify it was copied
     """
-    nav = Navigation(driver).open()
+    nav = Navigation(driver)
     hyperlink_context = HyperlinkContextMenu(driver)
     tabs = TabBar(driver)
+    example = ExamplePage(driver).open()
 
     # right click the hyperlink
-    nav.open()
-    driver.get("https://example.com")
-    hyperlink = driver.find_element(By.LINK_TEXT, "More information...")
-    hyperlink_context.context_click(hyperlink)
+    example.context_click("more-information")
 
     # click on the open in new window option
-    open_in_new_window = hyperlink_context.get_context_item("context-menu-copy-link")
-    hyperlink_context.click_context_item(open_in_new_window)
-    hyperlink_context.hide_popup("contentAreaContextMenu", chrome=True)
+    hyperlink_context.click_and_hide_menu("context-menu-copy-link")
 
     # open a new tab
     tabs.new_tab_by_button()
@@ -100,11 +57,7 @@ def test_copy_link(driver: Firefox):
     nav.context_click(search_bar)
 
     # paste and go
-    with driver.context(driver.CONTEXT_CHROME):
-        paste_and_go = nav.get_element("context-menu-paste-and-go")
-        paste_and_go.click()
-        nav.hide_popup_by_child_node(paste_and_go)
-
-    with driver.context(driver.CONTEXT_CONTENT):
-        nav.expect(EC.title_contains("Example Domains"))
-        assert driver.current_url == "https://www.iana.org/help/example-domains"
+    nav.click_and_hide_menu("context-menu-paste-and-go")
+
+    example.title_contains(example.MORE_INFO_TITLE)
+    example.url_contains(example.MORE_INFO_URL)