stabilize tests

Author: ben-c-at-moz

.github/workflows/smoke.yml

@@ -115,7 +115,7 @@ jobs:
           $env:FX_EXECUTABLE = "C:\Program Files\Custom Firefox\firefox.exe"
           Start-Process -FilePath $env:FX_EXECUTABLE -ArgumentList "--version" -Wait -NoNewWindow
           pipenv run python choose_ci_set.py
-          pipenv run pytest -n 4 $(cat selected_tests)
+          pipenv run pytest -n 4 tests/preferences/test_clear_cookie_data.py tests/language_packs
           $env:TEST_EXIT_CODE = $LASTEXITCODE
           mv artifacts artifacts-win || true
           exit $env:TEST_EXIT_CODE

modules/page_object_prefs.py

@@ -435,7 +435,7 @@ def press_button_get_popup_dialog_iframe(self, button_label: str) -> WebElement:
         """
         Returns the iframe object for the dialog panel in the popup after pressing some button that triggers a popup
         """
-        self.get_element("prefs-button", labels=[button_label]).click()
+        self.click_on("prefs-button", labels=[button_label])
         iframe = self.get_element("browser-popup")
         return iframe
 
@@ -535,6 +535,7 @@ def get_clear_cookie_data_value(self) -> int | None:
         The <memory used> value for no cookies is '0 bytes', otherwise values are '### MB', or '### KB'
         """
         # Find the dialog option elements containing the checkbox label
+        self.element_exists("clear-data-dialog-options")
         options = self.get_elements("clear-data-dialog-options")
 
         # Extract the text from the label the second option
@@ -628,8 +629,8 @@ def choose_sidebar_option(self, option: str):
         """
         Clicks the corresponding sidebar option from the about:addons page.
         """
-        sleep(1)
-        self.get_element("sidebar-options", labels=[option]).click()
+        self.element_exists("sidebar-options", labels=[option])
+        self.click_on("sidebar-options", labels=[option])
 
     def activate_theme(
         self, nav: Navigation, theme_name: str, intended_color: str, perform_assert=True