Merge pull request #632 from mozilla/ben/stabilize-two-bookmarks-tests

Stabilize Bookmark Tests

Author: Tracy-Walker

SELECTOR_INFO.md

@@ -3043,6 +3043,12 @@ Location: Toolbar
 Path to .json: modules/data/panel_ui.components.json
 ```
 ```
+Selector name: panel-main-view
+Description: Main body of Panel UI
+Location: See above
+Path to .json: modules/data/panel_ui.components.json
+```
+```
 Selector name: sync-user-button
 Selector Data: toolbarbutton[id='fxa-toolbar-menu-button']
 Description: Account button
@@ -3148,6 +3154,12 @@ Location: Firefox menu
 Path to .json: modules/data/panel_ui.components.json
 ```
 ```
+Selector name: panel-ui-history-view
+Description: Subview of Panel UI
+Location: See above
+Path to .json: modules/data/panel_ui.components.json
+```
+```
 Selector name: panel-ui-history-recently-closed
 Selector Data: appMenuRecentlyClosedTabs
 Description: Recently closed tabs

modules/browser_object_find_toolbar.py

@@ -21,7 +21,7 @@ def __init__(self, driver: Firefox, **kwargs):
     def open(self) -> BasePage:
         """Use PanelUi to open the Find Toolbar, wait for element to load"""
         self.panel_ui.open_panel_menu()
-        self.panel_ui.select_panel_setting("find-in-page")
+        self.panel_ui.click_on("find-in-page")
         self.wait_for_page_to_load()
         return self
 

modules/browser_object_panel_ui.py

@@ -1,3 +1,4 @@
+from time import sleep
 from typing import List
 
 from pypom import Region
@@ -46,46 +47,27 @@ def open_panel_menu(self) -> BasePage:
         self.menu = self.Menu(self, root=panel_root)
         return self
 
-    def select_panel_setting(self, name: str, *labels) -> BasePage:
-        """
-        Selects a panel setting in PanelUi.
-
-        ...
-
-        Parameters
-        ----------
-
-        name: str
-            Name of setting element
-        labels: *list[str]
-            Labels to pass to get_element()
-        """
-        self.click_on(name, labels=labels)
-        return self
-
     def navigate_to_about_addons(self):
         """
         On the hamburger menu > More Tools > Customize Toolbar > Manage Themes
         """
-        self.select_panel_setting("more-tools")
-        self.select_panel_setting("customize-toolbar")
-        with self.driver.context(self.driver.CONTEXT_CHROME):
-            self.get_element("manage-themes").click()
+        self.click_on("more-tools")
+        self.click_on("customize-toolbar")
+        self.click_on("manage-themes")
 
     def navigate_to_customize_toolbar(self):
         """
         On the hamburger menu > More Tools > Customize Toolbar
         """
-        self.select_panel_setting("more-tools")
-        self.select_panel_setting("customize-toolbar")
+        self.click_on("more-tools")
+        self.click_on("customize-toolbar")
 
     def click_sync_sign_in_button(self) -> BasePage:
         """
         Click FxA sync button.
         """
-        with self.driver.context(self.driver.CONTEXT_CHROME):
-            self.open_panel_menu()
-            self.select_panel_setting("fxa-sign-in")
+        self.open_panel_menu()
+        self.click_on("fxa-sign-in")
         return self
 
     def log_out_fxa(self) -> BasePage:
@@ -147,13 +129,16 @@ def open_private_window(self) -> BasePage:
             self.get_element("panel-ui-new-private-window").click()
         return self
 
+    @BasePage.context_chrome
     def open_history_menu(self) -> BasePage:
         """
         Opens the History menu
         """
         self.open_panel_menu()
-        with self.driver.context(self.driver.CONTEXT_CHROME):
-            self.get_element("panel-ui-history").click()
+        # Bug 1974080
+        if self.sys_platform() == "Windows":
+            sleep(2)
+        self.click_on("panel-ui-history")
         return self
 
     def select_clear_history_option(self, option: str) -> BasePage:
@@ -184,6 +169,9 @@ def redirect_to_about_logins_page(self) -> BasePage:
         Opens the about:logins page by clicking the Password option in Hamburger Menu"
         """
         self.open_panel_menu()
+        # Bug 1974080
+        if self.sys_platform() == "Windows":
+            sleep(2)
         self.get_element("password-button").click()
         return self
 
@@ -195,6 +183,9 @@ def open_bookmarks_panel_from_hamburger_menu(self) -> BasePage:
         Opens the Bookmarks panel from the Hamburger Menu
         """
         self.open_panel_menu()
+        # Bug 1974080
+        if self.sys_platform() == "Windows":
+            sleep(2)
         self.click_on("panel-ui-bookmarks")
         return self
 
@@ -261,3 +252,45 @@ def get_bookmark_tags(self, tags: List[str]) -> List[str]:
             )
             for tag in tags
         ]
+
+    @BasePage.context_chrome
+    def clear_recent_history(self, execute=True) -> BasePage:
+        """Clears recent history. Case of execute=True may not be complete"""
+        self.open_panel_menu()
+        # Bug 1974080
+        if self.sys_platform() == "Windows":
+            sleep(2)
+        self.get_element("panel-ui-history").click()
+
+        self.element_exists("clear-recent-history")
+        self.element_visible("clear-recent-history")
+        self.element_clickable("clear-recent-history")
+        if execute:
+            self.click("clear_recent_history")
+
+        return self
+
+    @BasePage.context_chrome
+    def confirm_history_clear(self):
+        """Confirm that the history is empty"""
+        self.open_history_menu()
+        self.expect_element_attribute_contains(
+            "recent-history-content", "value", "(Empty)"
+        )
+
+    @BasePage.context_chrome
+    def reopen_recently_closed_tabs(self) -> BasePage:
+        """Reopen all recently closed tabs"""
+        self.open_panel_menu()
+        # Bug 1974080
+        if self.sys_platform() == "Windows":
+            sleep(2)
+        self.click_on("panel-ui-history")
+
+        self.click_on("panel-ui-history-recently-closed")
+        if self.sys_platform() == "Linux":
+            sleep(2)
+
+        self.click_on("panel-ui-history-recently-closed-reopen-tabs")
+
+        return self

modules/browser_object_print_preview.py

@@ -21,13 +21,13 @@ class PrintPreview(BasePage):
 
     URL_TEMPLATE = "about:blank"
 
+    @BasePage.context_chrome
     def open(self) -> BasePage:
         """Use PanelUi to open the Print Preview, wait for element to load"""
         panel_ui = PanelUi(self.driver)
-        with self.driver.context(self.driver.CONTEXT_CHROME):
-            panel_ui.open_panel_menu()
-            panel_ui.select_panel_setting("print-option")
-            self.wait_for_page_to_load()
+        panel_ui.open_panel_menu()
+        panel_ui.click_on("print-option")
+        self.wait_for_page_to_load()
         return self
 
     def open_with_key_combo(self) -> BasePage:

modules/data/panel_ui.components.json

@@ -1,14 +1,20 @@
 {
     "context": "chrome",
+    "do-not-cache": true,
     "panel-ui-button": {
         "selectorData": "PanelUI-menu-button",
         "strategy": "id",
         "groups": [
-            "requiredForPage",
-            "doNotCache"
+            "requiredForPage"
         ]
     },
 
+    "panel-main-view": {
+        "selectorData": "appMenu-mainView",
+        "strategy": "id",
+        "groups": []
+    },
+
     "sync-user-button": {
         "selectorData": "toolbarbutton[id='fxa-toolbar-menu-button']",
         "strategy": "css",
@@ -36,9 +42,7 @@
     "fxa-sync-label": {
         "selectorData": "syncnow-label",
         "strategy": "class",
-        "groups": [
-            "doNotCache"
-        ]
+        "groups": []
     },
 
     "new-private-window-option": {
@@ -109,6 +113,12 @@
         "groups": []
     },
 
+    "panel-ui-history-view": {
+        "selectorData": "PanelUI-history",
+        "strategy": "id",
+        "groups": []
+    },
+
     "panel-ui-history-recently-closed": {
         "selectorData": "appMenuRecentlyClosedTabs",
         "strategy": "id",
@@ -324,4 +334,4 @@
         "strategy": "id",
         "groups": []
     }
-}
+}

tests/bookmarks_and_history/test_clear_all_history.py

@@ -3,7 +3,6 @@
 
 from modules.browser_object import PanelUi
 from modules.page_object import GenericPage
-from modules.util import BrowserActions
 
 
 @pytest.fixture()
@@ -20,16 +19,12 @@ def test_clear_all_history(driver: Firefox):
     """
     C172045: Verify that the user can Clear all the History
     """
+    gen_page = GenericPage(driver)
     panel_ui = PanelUi(driver)
     panel_ui.open()
-    gen_page = GenericPage(driver)
     panel_ui.open_history_menu()
-    ba = BrowserActions(driver)
 
     panel_ui.select_clear_history_option("Everything")
 
-    gen_page.get_element("clear-history-button").click()
-    ba.switch_to_content_context()
-
-    panel_ui.open_history_menu()
-    panel_ui.element_does_not_exist("bookmark-item")
+    gen_page.click_on("clear-history-button")
+    panel_ui.confirm_history_clear()

tests/bookmarks_and_history/test_clear_recent_history_displayed.py

@@ -16,10 +16,4 @@ def test_clear_recent_history_displayed(driver: Firefox):
     panel_ui = PanelUi(driver)
     panel_ui.open()
 
-    panel_ui.open_panel_menu()
-    with driver.context(driver.CONTEXT_CHROME):
-        panel_ui.get_element("panel-ui-history").click()
-
-        panel_ui.element_exists("clear-recent-history")
-        panel_ui.element_visible("clear-recent-history")
-        panel_ui.element_clickable("clear-recent-history")
+    panel_ui.clear_recent_history(execute=False)

tests/bookmarks_and_history/test_opened_website_in_new_tab_present_in_toolbar_history.py

@@ -1,8 +1,7 @@
 import pytest
 from selenium.webdriver import Firefox
 
-from modules.browser_object_panel_ui import PanelUi
-from modules.browser_object_tabbar import TabBar
+from modules.browser_object import PanelUi, TabBar
 from modules.page_object_generics import GenericPage
 
 

tests/password_manager/test_primary_password_triggered_on_about_logins_access.py

@@ -1,3 +1,5 @@
+from platform import system
+
 import pytest
 from selenium.webdriver import Firefox, Keys
 
@@ -16,6 +18,9 @@ def test_case():
     return "2245199"
 
 
+@pytest.mark.skipif(
+    system().lower().startswith("linux"), reason="Currently unstable in linux"
+)
 def test_primary_password_triggered_on_about_logins_access_via_hamburger_menu(
     driver: Firefox,
 ):

tests/preferences/test_firefox_home_on_launch.py

@@ -38,7 +38,7 @@ def test_firefox_home_on_launch(driver: Firefox, sys_platform: str):
     # make sure that the option was selected correctly
     assert drop_down.get_attribute("label") == "Firefox Home (Default)"
     panel_ui.open_panel_menu()
-    panel_ui.select_panel_setting("panel-ui-new-window")
+    panel_ui.click_on("panel-ui-new-window")
     # wait for the number of tabs and switch
     tabs.wait_for_num_tabs(2)
     driver.switch_to.window(driver.window_handles[-1])