Skip to content

Commit c1627ec

Browse files
authored
Merge pull request #633 from mozilla/tracy/broaden_fix_for_panelUI
Move sleep
2 parents 621161f + 50bc6c8 commit c1627ec

File tree

1 file changed

+1
-15
lines changed

1 file changed

+1
-15
lines changed

modules/browser_object_panel_ui.py

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ def open_panel_menu(self) -> BasePage:
4545
panel_root = self.get_element("panel-ui-button")
4646
panel_root.click()
4747
self.menu = self.Menu(self, root=panel_root)
48+
sleep(2) # Bug 1974080
4849
return self
4950

5051
def navigate_to_about_addons(self):
@@ -135,9 +136,6 @@ def open_history_menu(self) -> BasePage:
135136
Opens the History menu
136137
"""
137138
self.open_panel_menu()
138-
# Bug 1974080
139-
if self.sys_platform() == "Windows":
140-
sleep(2)
141139
self.click_on("panel-ui-history")
142140
return self
143141

@@ -169,9 +167,6 @@ def redirect_to_about_logins_page(self) -> BasePage:
169167
Opens the about:logins page by clicking the Password option in Hamburger Menu"
170168
"""
171169
self.open_panel_menu()
172-
# Bug 1974080
173-
if self.sys_platform() == "Windows":
174-
sleep(2)
175170
self.get_element("password-button").click()
176171
return self
177172

@@ -183,9 +178,6 @@ def open_bookmarks_panel_from_hamburger_menu(self) -> BasePage:
183178
Opens the Bookmarks panel from the Hamburger Menu
184179
"""
185180
self.open_panel_menu()
186-
# Bug 1974080
187-
if self.sys_platform() == "Windows":
188-
sleep(2)
189181
self.click_on("panel-ui-bookmarks")
190182
return self
191183

@@ -257,9 +249,6 @@ def get_bookmark_tags(self, tags: List[str]) -> List[str]:
257249
def clear_recent_history(self, execute=True) -> BasePage:
258250
"""Clears recent history. Case of execute=True may not be complete"""
259251
self.open_panel_menu()
260-
# Bug 1974080
261-
if self.sys_platform() == "Windows":
262-
sleep(2)
263252
self.get_element("panel-ui-history").click()
264253

265254
self.element_exists("clear-recent-history")
@@ -282,9 +271,6 @@ def confirm_history_clear(self):
282271
def reopen_recently_closed_tabs(self) -> BasePage:
283272
"""Reopen all recently closed tabs"""
284273
self.open_panel_menu()
285-
# Bug 1974080
286-
if self.sys_platform() == "Windows":
287-
sleep(2)
288274
self.click_on("panel-ui-history")
289275

290276
self.click_on("panel-ui-history-recently-closed")

0 commit comments

Comments
 (0)