Skip to content

Commit c38ae20

Browse files
Merge pull request #753 from mozilla/philimon/beta_split_failsafe
Philimon/add fail safe for beta split reporting
2 parents 0777f74 + c8e23dc commit c38ae20

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

choose_l10n_beta_split.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ def distribute_mappings_evenly(mappings):
2424
min_idx = loads.index(min(loads))
2525
balanced_splits[min_idx][site] = list(regions)
2626
loads[min_idx] += len(regions)
27+
for i in range(len(balanced_splits)):
28+
logging.info(f"Beta split: {i}")
29+
current_split = [f"{site} {' '.join(regions)}" for site, regions in balanced_splits[i].items()]
30+
logging.info(f"{'\n'.join(current_split)}")
2731
return balanced_splits
2832

2933

choose_l10n_ci_set.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,15 @@ def valid_l10n_mappings():
3030
region_file = json.load(f)
3131
if region_file.get("sites"):
3232
for site in region_file.get("sites"):
33-
mapping[site].add(region)
33+
report_mapping = True
34+
if site != "demo" and os.path.exists(f"./l10n_CM/constants/{site}/{region}"):
35+
with open(f"./l10n_CM/constants/{site}/{region}/{site}_ad.json", "r+") as ad_file, open(f"./l10n_CM/constants/{site}/{region}/{site}_cc.json", "r+") as cc_file:
36+
ad = json.load(ad_file)
37+
cc = json.load(cc_file)
38+
if ad.get("skip") and cc.get("skip"):
39+
report_mapping = False
40+
if report_mapping:
41+
mapping[site].add(region)
3442
return mapping
3543

3644

0 commit comments

Comments
 (0)