Skip to content

Commit c4c5988

Browse files
Hani YacoubHani Yacoub
authored andcommitted
Modifications
1 parent 1d9f3e7 commit c4c5988

File tree

2 files changed

+5
-32
lines changed

2 files changed

+5
-32
lines changed

modules/data/navigation.components.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,5 @@
152152
"selectorData": "urlbarView-row-body-description",
153153
"strategy": "class",
154154
"groups": []
155-
},
156-
157-
"firefox-suggest": {
158-
"selectorData": "div.urlbarView-row[label=\"Firefox Suggest\"] > span.urlbarView-row-inner",
159-
"strategy": "css",
160-
"groups": []
161155
}
162156
}
Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
1-
21
import time
32

43
import pytest
5-
from selenium.common import NoSuchElementException
64
from selenium.webdriver import Firefox
75

86
from modules.browser_object_navigation import Navigation
9-
from modules.browser_object_tabbar import TabBar
10-
from modules.page_object_about_newtab import AboutNewtab
117
from modules.page_object_about_prefs import AboutPrefs
128
from modules.util import BrowserActions
139

@@ -27,7 +23,6 @@ def test_preferences_all_toggles_enabled(driver: Firefox):
2723
nav = Navigation(driver).open()
2824
about_prefs = AboutPrefs(driver, category="search").open()
2925
u = BrowserActions(driver)
30-
tabs = TabBar(driver)
3126

3227
# Check if toggles are enabled
3328
nonsponsored_checkbox = about_prefs.get_element("firefox-suggest-nonsponsored")
@@ -36,30 +31,14 @@ def test_preferences_all_toggles_enabled(driver: Firefox):
3631
assert sponsors_checkbox.is_selected(), f"Checkbox with selector '{sponsors_checkbox}' is not checked"
3732

3833
# Check if sponsored suggestion is displayed
39-
tabs.new_tab_by_button()
40-
tabs.switch_tab()
4134
time.sleep(20)
4235
u.search("iphone", with_enter=False)
43-
time.sleep(5)
36+
time.sleep(20)
4437
with (driver.context(driver.CONTEXT_CHROME)):
45-
firefox_suggest = nav.get_element("firefox-suggestion")
46-
# .get_attribute("Sponsored")
47-
# sponsored = firefox_suggest.get_attribute("Sponsored")
48-
# expected_attribute = "Sponsored"
49-
assert firefox_suggest.is_displayed()
50-
# sponsored = firefox_suggest.get_attribute("Sponsored")
51-
# assert firefox_suggest.is_displayed()
38+
assert nav.get_elements("firefox-suggestion")
5239

5340
# Check if a non-sponsored suggestion is displayed
54-
nav.clear_awesome_bar()
5541
time.sleep(20)
56-
u.search("wikipedia", with_enter=False)
57-
# nav.type_in_awesome_bar("wikipedia")
58-
time.sleep(20)
59-
try:
60-
with (driver.context(driver.CONTEXT_CHROME)):
61-
firefox_suggest = nav.get_element("firefox-suggestion")
62-
is_displayed = firefox_suggest.is_displayed()
63-
except NoSuchElementException:
64-
is_displayed = False
65-
assert not is_displayed, f"Element with XPath {firefox_suggest} is displayed, but it should not be."
42+
u.search("wiki", with_enter=False)
43+
with (driver.context(driver.CONTEXT_CHROME)):
44+
assert not nav.get_elements("firefox-suggestion")

0 commit comments

Comments
 (0)