Refactor and stabilization on download pdf test

Author: soncuteanca

tests/downloads/test_download_pdf.py

@@ -28,30 +28,41 @@ def test_download_pdf(
 ):
     """
     C1756769: Verify that the user can Download a PDF
+
+    Notes:
+        - Firefox is launched with a new profile that has default download settings.
+        - This means the OS-level "Save File" dialog will appear for every download.
+        - Selenium cannot interact with this native dialog directly, so the test
+          must rely on fixed waits to give the OS time to render the dialog and to
+          finish writing the file.
     """
-    pdf = GenericPdf(driver, pdf_url=fillable_pdf_url).open()
+
+    # Initialize objects
+    pdf = GenericPdf(driver, pdf_url=fillable_pdf_url)
     keyboard = Controller()
 
     # Click the download button
+    pdf.open()
     download_button = pdf.get_element("download-button")
     download_button.click()
 
     # Allow time for the download dialog to appear and pressing handle the prompt
     time.sleep(2)
     pdf.handle_os_download_confirmation(keyboard, sys_platform)
 
-    # Allow time for the download to complete
-    time.sleep(3)
-
     # Set the expected download path and the expected PDF name
     file_name = "i-9.pdf"
     saved_pdf_location = os.path.join(downloads_folder, file_name)
 
-    # Verify if the file exists
-    assert os.path.exists(saved_pdf_location), (
-        f"The file was not downloaded to {saved_pdf_location}."
-    )
+    # Wait up to 10 seconds for the file to appear and finish downloading
+    timeout = 10
+    start = time.time()
+    while time.time() - start < timeout:
+        if os.path.exists(saved_pdf_location):
+            break
+        time.sleep(0.5)
 
-    print(
-        f"Test passed: The file {file_name} has been downloaded and is present at {saved_pdf_location}."
+    # Verify that the file was downloaded
+    assert os.path.exists(saved_pdf_location), (
+        f"The file was not downloaded to {saved_pdf_location} after {timeout} seconds."
     )

tests/preferences/test_clear_cookie_data.py

@@ -10,8 +10,9 @@
 def test_case():
     return "143627"
 
+
 WEBSITE_ADDRESS = "https://www.wikipedia.com"
-#WIN_GHA = environ.get("GITHUB_ACTIONS") == "true" and sys.platform.startswith("win")
+# WIN_GHA = environ.get("GITHUB_ACTIONS") == "true" and sys.platform.startswith("win")
 
 
 def _dialog_options_present(about_prefs: AboutPrefs) -> bool:
@@ -23,7 +24,9 @@ def _dialog_options_present(about_prefs: AboutPrefs) -> bool:
         return False
 
 
-def open_clear_cookies_data_dialog(about_prefs: AboutPrefs, ba: BrowserActions, wait: WebDriverWait):
+def open_clear_cookies_data_dialog(
+    about_prefs: AboutPrefs, ba: BrowserActions, wait: WebDriverWait
+):
     """
     Open about:preferences#privacy, show 'Clear Data' dialog, switch into its iframe,
     wait for its options container to be present, read the value, then switch back.

tests/tabs/test_active_tab.py

@@ -3,7 +3,6 @@
 
 from modules.browser_object import TabBar
 
-
 NUM_TABS = 5
 
 

tests/tabs/test_navigation_multiple_tabs.py

@@ -1,6 +1,8 @@
 import logging
+
 import pytest
 from selenium.webdriver import Firefox
+
 from modules.browser_object import TabBar
 
 NUM_TABS = 20

tests/tabs/test_open_bookmark_in_new_tab.py

@@ -18,7 +18,6 @@ def test_case():
 
 
 def test_open_bookmark_in_new_tab(driver: Firefox):
-
     """
     C134460: Verify that New Tabs can be opened by right clicking and selecting new tab from the bookmarks.
     """

tests/tabs/test_open_new_tab.py

@@ -4,7 +4,6 @@
 
 from modules.browser_object import TabBar
 
-
 URL = "about:robots"
 EXPECTED_TEXT = "Firefox"
 

tests/tabs/test_open_new_tab_keys.py

@@ -1,8 +1,8 @@
 import pytest
 from selenium.webdriver import Firefox
 from selenium.webdriver.support import expected_conditions as EC
-from modules.browser_object import TabBar
 
+from modules.browser_object import TabBar
 
 URL = "about:robots"
 EXPECTED_TEXT = "Firefox"