Skip to content

Commit c828e5d

Browse files
committed
screenshotting temporary
1 parent b7523ed commit c828e5d

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

modules/browser_object_tracker_panel.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import datetime
12
import logging
23
from typing import List
34

@@ -16,7 +17,7 @@ class TrackerPanel(BasePage):
1617
URL_TEMPLATE = ""
1718

1819
def wait_for_blocked_tracking_icon(
19-
self, nav: Navigation, page: BasePage
20+
self, nav: Navigation, page: BasePage, screenshot
2021
) -> BasePage:
2122
"""
2223
Waits for the shield icon to indicate that cookies/trackers are being blocked by continuously refresing the page
@@ -33,6 +34,7 @@ def shield_active() -> bool:
3334
with self.driver.context(self.driver.CONTEXT_CONTENT):
3435
page.wait_for_page_to_load()
3536
shield_icon = nav.get_element("shield-icon")
37+
screenshot(str(datetime.datetime.now()))
3638
if (
3739
shield_icon.get_attribute("data-l10n-id")
3840
== "tracking-protection-icon-active-container"

tests/security_and_privacy/test_third_party_content_blocked_private_browsing.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
SECOND_TRACKER_WEBSITE = "https://www.itisatrap.org/firefox/its-a-tracker.html"
1818

1919

20-
def test_third_party_content_blocked_private_browsing_cross_site(driver: Firefox):
20+
def test_third_party_content_blocked_private_browsing_cross_site(driver: Firefox, screenshot):
2121
"""
2222
C446323.1: Ensure that third party content is blocked correctly
2323
"""
@@ -33,7 +33,7 @@ def test_third_party_content_blocked_private_browsing_cross_site(driver: Firefox
3333

3434
# open the website, ensure the blocking is taking place by continuously refreshing website until indicated
3535
tracker_website.open()
36-
tracker_panel.wait_for_blocked_tracking_icon(nav, tracker_website)
36+
tracker_panel.wait_for_blocked_tracking_icon(nav, tracker_website, screenshot)
3737

3838
# verify the indicator
3939
driver.set_context(driver.CONTEXT_CHROME)
@@ -58,7 +58,7 @@ def test_third_party_content_blocked_private_browsing_cross_site(driver: Firefox
5858
assert found_tracker
5959

6060

61-
def test_third_party_content_blocked_private_browsing_allowed_tracking(driver: Firefox):
61+
def test_third_party_content_blocked_private_browsing_allowed_tracking(driver: Firefox, screenshot):
6262
"""
6363
C446323.2: Ensure that some third party content is allowed
6464
"""
@@ -74,7 +74,7 @@ def test_third_party_content_blocked_private_browsing_allowed_tracking(driver: F
7474

7575
# open the website, ensure the blocking is taking place by continuously refreshing website until indicated
7676
tracker_website.open()
77-
tracker_panel.wait_for_blocked_tracking_icon(nav, tracker_website)
77+
tracker_panel.wait_for_blocked_tracking_icon(nav, tracker_website, screenshot)
7878

7979
# verify the indicator
8080
driver.set_context(driver.CONTEXT_CHROME)
@@ -96,7 +96,7 @@ def test_third_party_content_blocked_private_browsing_allowed_tracking(driver: F
9696
assert item.get_attribute("value") in ALLOWED_TRACKING_URLS
9797

9898

99-
def test_third_party_content_private_browsing_tracking_statuses(driver: Firefox):
99+
def test_third_party_content_private_browsing_tracking_statuses(driver: Firefox, screenshot):
100100
"""
101101
C446323.3: Ensure that the statuses of some third party content are loaded properly
102102
"""
@@ -112,7 +112,7 @@ def test_third_party_content_private_browsing_tracking_statuses(driver: Firefox)
112112

113113
# open the tracker website
114114
tracker_website.open()
115-
tracker_panel.wait_for_blocked_tracking_icon(nav, tracker_website)
115+
tracker_panel.wait_for_blocked_tracking_icon(nav, tracker_website, screenshot)
116116

117117
# verify the indicator
118118
tracker_panel.verify_tracker_shield_indicator(nav)

0 commit comments

Comments
 (0)