Fix up switching to a private browsing window

Author: Tracy-Walker

modules/page_base.py

@@ -691,6 +691,14 @@ def switch_to_new_window(self) -> Page:
         with self.driver.context(self.driver.CONTEXT_CONTENT):
             return self.switch_to_new_tab()
 
+    def switch_to_new_private_window(self) -> Page:
+        "Switch to new private window"
+        non_private_window = self.driver.current_window_handle
+        original_window_idx = self.driver.window_handles.index(non_private_window)
+        private_window = self.driver.window_handles[1 - original_window_idx]
+        self.driver.switch_to.window(private_window)
+        return self
+
     def switch_to_frame(self, frame: str, labels=[]) -> Page:
         """Switch to inline document frame"""
         with self.driver.context(self.driver.CONTEXT_CHROME):

tests/security_and_privacy/test_cookies_not_saved_private_browsing.py

@@ -24,7 +24,7 @@ def test_cookies_not_saved_private_browsing(driver: Firefox):
 
     # Open new private window
     panel_ui.open_private_window()
-    nav.switch_to_new_window()
+    nav.switch_to_new_private_window()
 
     # Open the Google page and perform a search
     google_search.open()

tests/security_and_privacy/test_downloads_from_private_not_leaked.py

@@ -39,10 +39,8 @@ def test_downloads_from_private_not_leaked(driver: Firefox, delete_files, screen
     panelui.select_panel_setting("new-private-window-option")
     panelui.wait_for_num_windows(2)
 
-    # Using this instead of switch_to_new_window, suspect it may be broken
-    original_window_idx = driver.window_handles.index(non_private_window)
-    private_window = driver.window_handles[1 - original_window_idx]
-    driver.switch_to.window(private_window)
+    nav = Navigation(driver)
+    nav.switch_to_new_private_window()
 
     about_downloads = AboutDownloads(driver)
     about_downloads.open()
@@ -51,7 +49,6 @@ def test_downloads_from_private_not_leaked(driver: Firefox, delete_files, screen
         logging.warning("About:Downloads is not registering as empty")
 
     opm_forms = GenericPage(driver, url=TEST_URL)
-    nav = Navigation(driver)
     opm_forms.open()
 
     # Get all links to pdfs on the page

tests/security_and_privacy/test_https_enabled_private_browsing.py

@@ -26,15 +26,8 @@ def test_https_first_mode_in_private_browsing(driver: Firefox):
     hamburger = PanelUi(driver)
     hamburger.open_private_window()
 
-    # nav = Navigation(driver)
-    # nav.switch_to_new_window()
-
-    # Using this instead of switch_to_new_window, suspect that may be unstable
-    # on Linux CI machines. (slow to actually fully load the new Window)
-    non_private_window = driver.current_window_handle
-    original_window_idx = driver.window_handles.index(non_private_window)
-    private_window = driver.window_handles[1 - original_window_idx]
-    driver.switch_to.window(private_window)
+    nav = Navigation(driver)
+    nav.switch_to_new_private_window()
     driver.get(HTTP_SITE)
 
     # Wait for the URL to be redirected to HTTPS

tests/security_and_privacy/test_open_link_in_private_window.py

@@ -25,7 +25,7 @@ def test_open_link_in_private_window(driver: Firefox):
     context_menu.click_and_hide_menu("context-menu-open-link-in-new-private-window")
 
     nav.wait_for_num_windows(2)
-    nav.switch_to_new_window()
+    nav.switch_to_new_private_window()
     sleep(1)
     with driver.context(driver.CONTEXT_CHROME):
         nav.title_contains("Private Browsing")

tests/security_and_privacy/test_private_browser_password_doorhanger.py

@@ -30,7 +30,7 @@ def test_no_password_doorhanger_private_browsing(driver: Firefox):
 
     # Open Private Window
     panel_ui.open_private_window()
-    nav.switch_to_new_window()
+    nav.switch_to_new_private_window()
 
     # Open the form, fill the user and password
     login_auto_fill.open()

tests/security_and_privacy/test_private_session_awesome_bar_exclusion.py

@@ -30,7 +30,7 @@ def test_websites_visited_in_private_browser_not_displayed_in_awesome_bar(
     panel_ui = PanelUi(driver)
 
     panel_ui.open_private_window()
-    panel_ui.switch_to_new_window()
+    panel_ui.switch_to_new_private_window()
 
     for url in WEBSITES:
         driver.get(url)

tests/security_and_privacy/test_private_session_history_exclusion.py

@@ -29,7 +29,7 @@ def test_websites_visited_in_private_browser_not_displayed_in_history(driver: Fi
 
     panel_ui = PanelUi(driver).open()
     panel_ui.open_private_window()
-    panel_ui.switch_to_new_window()
+    panel_ui.switch_to_new_private_window()
 
     driver.get(YOUTUBE_URL)
     driver.get(FACEBOOK_URL)

tests/security_and_privacy/test_private_window_from_panelui.py

@@ -15,5 +15,5 @@ def test_private_window_from_panelui(driver: Firefox):
     panelui = PanelUi(driver).open_panel_menu()
     panelui.select_panel_setting("new-private-window-option")
     panelui.wait_for_num_windows(2)
-    panelui.switch_to_new_window()
+    panelui.switch_to_new_private_window()
     AboutPrivatebrowsing(driver).wait_for_page_to_load()

tests/security_and_privacy/test_third_party_content_blocked_private_browsing.py

@@ -36,7 +36,7 @@ def test_third_party_content_blocked_private_browsing_cross_site(driver: Firefox
 
     # open the new window
     panel_ui.open_private_window()
-    nav.switch_to_new_window()
+    nav.switch_to_new_private_window()
 
     # open the website, ensure the blocking is taking place by continuously refreshing website until indicated
     tracker_website.open()