Add refactored tests 330155 and 330156

Author: soncuteanca

modules/browser_object_tabbar.py

@@ -136,10 +136,13 @@ def get_tab_title(self, tab_element: WebElement) -> str:
         tab_label = tab_element.find_element(*self.get_selector("tab-title"))
         return tab_label.text
 
+    @BasePage.context_chrome
     def expect_tab_sound_status(
         self, identifier: Union[str, int], status: MediaStatus
     ) -> BasePage:
-        """Check to see if the tab has an expected MediaStatus"""
+        """
+        Check to see if the tab has an expected MediaStatus
+        """
         tab = self.get_tab(identifier)
         self.wait.until(lambda _: tab.get_attribute(status) is not None)
         return self

modules/data/navigation.components.json

@@ -501,12 +501,6 @@
         "groups": []
     },
 
-    "autoplay-permission": {
-        "selectorData": "blocked-permissions-container",
-        "strategy": "id",
-        "groups": []
-    },
-
     "permissions-location-icon": {
         "selectorData": "permissions-granted-icon",
         "strategy": "id",

modules/page_object_prefs.py

@@ -1,7 +1,7 @@
 import datetime
 import re
 from time import sleep
-from typing import List
+from typing import List, Literal
 
 from selenium.webdriver import Firefox
 from selenium.webdriver.common.by import By
@@ -561,6 +561,33 @@ def get_manage_data_site_element(self, site: str) -> WebElement:
         element = self.get_element("manage-cookies-site", labels=[site])
         return element
 
+    def set_autoplay_setting(
+        self,
+        settings: Literal[
+            "allow-audio-video",
+            "block-audio-video",
+            "allow-audio-only",
+        ],
+    ) -> "AboutPrefs":
+        """
+        Open the Autoplay settings panel and choose a policy for all sites.
+        Arguments:
+        policy : Literal["allow-audio-video", "block-audio-video", "allow-audio-only"]
+            - "allow-audio-video": Allow both audio and video autoplay
+            - "block-audio-video": Block both audio and video autoplay
+            - "allow-audio-only": Allow audio but block video autoplay
+        """
+        self.open()
+        self.click_on("autoplay-settings-button")
+
+        self.driver.switch_to.frame(self.get_iframe())
+
+        self.click_on("autoplay-settings")
+        self.click_on(settings)
+        self.click_on("spacer")
+        self.click_on("autoplay-save-changes")
+        return self
+
     # Utility Functions
     def import_bookmarks(self, browser_name: str, platform) -> BasePage:
         """

tests/audio_video/test_allow_audio_video_functionality.py

@@ -1,14 +1,12 @@
 import sys
 from os import environ
-from time import sleep
 
 import pytest
 from selenium.webdriver import Firefox
 
 from modules.browser_object_tabbar import TabBar
 from modules.page_object_generics import GenericPage
 from modules.page_object_prefs import AboutPrefs
-from modules.util import BrowserActions
 
 
 @pytest.fixture()
@@ -22,45 +20,21 @@ def test_case():
 TEST_URL = "https://www.mlb.com/video/rockies-black-agree-on-extension"
 
 
-@pytest.mark.skipif(WIN_GHA, reason="Test unstable in Windows Github Actions")
+# @pytest.mark.skipif(WIN_GHA, reason="Test unstable in Windows Github Actions")
 @pytest.mark.audio
 @pytest.mark.noxvfb
 def test_allow_audio_video_functionality(driver: Firefox):
     """
-    C330155 : 'Allow Audio and Video' functionality
+    C330155: 'Allow Audio and Video' functionality
     """
     # Instantiate objects
     about_prefs = AboutPrefs(driver, category="privacy")
-    ba = BrowserActions(driver)
     tabs = TabBar(driver)
+    page = GenericPage(driver, url=TEST_URL)
 
     # Open privacy and click on the "Settings" button from Autoplay
-    about_prefs.open()
-    about_prefs.get_element("autoplay-settings-button").click()
+    about_prefs.set_autoplay_setting("allow-audio-video")
 
-    # Get the web element for the iframe
-    iframe = about_prefs.get_iframe()
-    ba.switch_to_iframe_context(iframe)
-
-    # Click on the autoplay settings for all websites
-    about_prefs.get_element("autoplay-settings").click()
-
-    # Choose allow audio and video and save changes
-    about_prefs.click_on("allow-audio-video")
-    about_prefs.get_element("spacer").click()
-    about_prefs.get_element("autoplay-save-changes").click()
-
-    # Open test website and check the site is loaded and the featured video starts playing with sound
-    GenericPage(driver, url=TEST_URL).open()
-    max_retries = 3
-    for attempt in range(max_retries):
-        try:
-            with driver.context(driver.CONTEXT_CHROME):
-                tabs.expect_tab_sound_status(1, tabs.MEDIA_STATUS.PLAYING)
-            break  # Success!
-        except AssertionError:
-            sleep(2)
-    else:
-        pytest.fail(
-            f"Tab sound status did not reach PLAYING after {max_retries} retries."
-        )
+    # Open the website and check if the video starts playing with sound
+    page.open()
+    tabs.expect_tab_sound_status(1, tabs.MEDIA_STATUS.PLAYING)

tests/audio_video/test_block_audio_video_functionality.py

@@ -4,7 +4,6 @@
 from modules.browser_object_navigation import Navigation
 from modules.page_object_generics import GenericPage
 from modules.page_object_prefs import AboutPrefs
-from modules.util import BrowserActions
 
 
 @pytest.fixture()
@@ -21,26 +20,13 @@ def test_block_audio_video_functionality(driver: Firefox):
     """
     # Instantiate objects
     about_prefs = AboutPrefs(driver, category="privacy")
-    ba = BrowserActions(driver)
     nav = Navigation(driver)
+    page = GenericPage(driver, url=TEST_URL)
 
     # Open privacy and click on the "Settings" button from Autoplay
-    about_prefs.open()
-    about_prefs.get_element("autoplay-settings-button").click()
-
-    # Get the web element for the iframe
-    iframe = about_prefs.get_iframe()
-    ba.switch_to_iframe_context(iframe)
-
-    # Click on the autoplay settings for all websites
-    about_prefs.get_element("autoplay-settings").click()
-
-    # Choose block audio and video and save changes
-    about_prefs.click_on("block-audio-video")
-    about_prefs.get_element("spacer").click()
-    about_prefs.get_element("autoplay-save-changes").click()
+    about_prefs.set_autoplay_setting("block-audio-video")
 
     # Open test website and check the site is loaded and the featured video is not playing
-    GenericPage(driver, url=TEST_URL).open()
-    nav.click_on("autoplay-permission")
+    page.open()
+    nav.click_on("autoplay-icon-blocked")
     nav.element_visible("permission-popup-audio-video-blocked")

tests/audio_video/test_users_actions_saved_on_reload.py

@@ -36,7 +36,7 @@ def test_users_actions_saved_on_reload(driver: Firefox):
     GenericPage(driver, url=TEST_URL).open()
 
     # Open the Site information panel and check "Allow Audio and Video"
-    nav.click_on("autoplay-permission")
+    nav.click_on("autoplay-icon-blocked")
     nav.click_on("permission-popup-audio-blocked")
     nav.click_and_hide_menu("allow-audio-video-menuitem")
 
@@ -61,7 +61,7 @@ def test_users_actions_saved_on_reload(driver: Firefox):
     GenericPage(driver, url=TEST_URL).open()
 
     # Open the Site information panel and check "Block Audio and Video"
-    nav.click_on("autoplay-permission")
+    nav.click_on("autoplay-icon-blocked")
     nav.click_on("permission-popup-audio-video-allowed")
     nav.click_and_hide_menu("block-audio-video-menuitem")