Merge pull request #70 from mozilla/as/search-suggestion-for-engine-selection

As/search suggestion for engine selection

Author: soncuteanca

modules/data/navigation.components.json

@@ -9,6 +9,14 @@
         ]
     },
 
+    "results-dropdown": {
+        "selectorData": "urlbar-results",
+        "strategy": "id",
+        "groups": [
+            "doNotCache"
+        ]
+    },
+
     "tab-to-search-text-span": {
         "selectorData": "urlbarView-dynamic-onboardTabToSearch-text-container",
         "strategy": "class",
@@ -107,7 +115,7 @@
         "groups": []
     },
 
-    
+
     "add-extra-search-engine": {
         "selectorData": "[id*=urlbar-engine-one-off-item-engine--1][tooltiptext*='{0}']",
         "strategy": "css",
@@ -124,6 +132,13 @@
         "selectorData": "downloads-button",
         "strategy": "id",
         "groups": []
-    }
+    },
 
+    "search-suggestion-list": {
+        "selectorData": "div.urlbarView-row[type='search_engine'] span.urlbarView-title",
+        "strategy": "css",
+        "groups": [
+            "doNotCache"
+        ]
+    }
 }

modules/page_base.py

@@ -345,6 +345,15 @@ def element_selected(self, name: str, labels=[]) -> Page:
         )
         return self
 
+    def element_has_text(self, name: str, text: str, labels=[]) -> Page:
+        """Expect helper: wait until element has given text"""
+        self.expect(
+            EC.text_to_be_present_in_element(
+                self.get_selector(name, labels=labels), text
+            )
+        )
+        return self
+
     def url_contains(self, url_part: str) -> Page:
         """Expect helper: wait until driver URL contains given text or timeout"""
         self.expect(EC.url_contains(url_part))

tests/address_bar_and_search/test_suggestion_engine_selection.py

@@ -0,0 +1,37 @@
+import pytest
+from selenium.webdriver import Firefox, Keys
+from selenium.webdriver.support import expected_conditions as EC
+
+from modules.browser_object import Navigation
+
+sites = ["Google", "Amazon", "Bing", "DuckDuckGo", "eBay"]
+
+
+@pytest.fixture()
+def add_prefs():
+    return [
+        ("browser.search.region", "US"),
+    ]
+
+
+@pytest.mark.parametrize("site", sites)
+def test_search_suggestion_for_engine_selection(driver: Firefox, site: str):
+    nav = Navigation(driver).open()
+    nav.type_in_awesome_bar("@")
+    nav.element_has_text("results-dropdown", f"Search with {site}")
+
+    suggestion_list_items = nav.get_elements("search-suggestion-list")
+
+    # Filter elements to find the one that matches the desired site
+    suggestion_list_item = next(
+        (item for item in suggestion_list_items if site in item.text), None
+    )
+
+    if suggestion_list_item:
+        suggestion_list_item.click()
+        nav.type_in_awesome_bar("cobra" + Keys.ENTER)
+        nav.expect_in_content(EC.url_contains(site.lower()))
+    else:
+        pytest.fail(f"No search suggestion found for site: {site}")
+
+    nav.clear_awesome_bar()