Skip to content

Commit d5e89c1

Browse files
authored
Merge pull request #451 from mozilla/philimon/addon_suggestion
[Philimon] Fix for addon suggestion test
2 parents a8ea438 + 73cd135 commit d5e89c1

File tree

3 files changed

+16
-17
lines changed

3 files changed

+16
-17
lines changed

modules/browser_object_navigation.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,3 +330,8 @@ def open_searchmode_switcher_settings(self):
330330
self.click_on("searchmode-switcher")
331331
self.click_on("searchmode-switcher-settings")
332332
return self
333+
334+
def select_element_in_nav(self, element: str) -> BasePage:
335+
with self.driver.context(self.driver.CONTEXT_CHROME):
336+
self.get_element(element).click()
337+
return self

modules/data/navigation.components.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@
150150
},
151151

152152
"addon-suggestion": {
153-
"selectorData": "div.urlbarView-row[type='rust_amo'] span.urlbarView-title.urlbarView-overflowable",
154-
"strategy": "css",
153+
"selectorData": "urlbarView-row-body",
154+
"strategy": "class",
155155
"groups": []
156156
},
157157

tests/address_bar_and_search/test_addon_suggestion.py

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,14 @@ def test_addon_suggestion_based_on_search_input(driver: Firefox):
3535

3636
nav = Navigation(driver)
3737
nav.set_awesome_bar()
38-
sleep(20)
38+
sleep(2)
3939

40-
with driver.context(driver.CONTEXT_CHROME):
41-
nav.awesome_bar.click()
40+
for input_text, addon_name in input_to_addon_name.items():
41+
nav.type_in_awesome_bar(input_text)
42+
nav.element_visible("addon-suggestion")
43+
nav.select_element_in_nav("addon-suggestion")
4244

43-
for input_text, addon_name in input_to_addon_name.items():
44-
nav.awesome_bar.send_keys(input_text)
45-
nav.element_visible("addon-suggestion")
46-
nav.get_element("addon-suggestion").click()
47-
48-
# Construct the expected URL
49-
expected_url = (
50-
f"https://addons.mozilla.org/en-US/firefox/addon/{addon_name}/"
51-
)
52-
nav.expect_in_content(EC.url_contains(expected_url))
53-
54-
nav.awesome_bar.clear()
45+
# Construct the expected URL
46+
expected_url = f"https://addons.mozilla.org/en-US/firefox/addon/{addon_name}/"
47+
nav.expect_in_content(EC.url_contains(expected_url))
48+
nav.clear_awesome_bar()

0 commit comments

Comments
 (0)