fix formatting and on launch:

Author: sarinali

modules/data/panel_ui.components.json

@@ -91,6 +91,12 @@
         ]
     },
 
+    "panel-ui-new-window": {
+        "selectorData": "appMenu-new-window-button2",
+        "strategy": "id",
+        "groups": []
+    },
+
     "panel-ui-history": {
         "selectorData": "appMenu-history-button",
         "strategy": "id",

modules/page_object_about_prefs.py

@@ -46,7 +46,7 @@ def __init__(self, page, **kwargs):
         def loaded(self):
             return self.root if EC.element_to_be_clickable(self.root) else False
 
-        def select_option(self, option_name: str, double_click=False):
+        def select_option(self, option_name: str, double_click=False, wait_for_selection=True):
             """Select an option in the dropdown. Does not return self."""
             if not self.dropmarker.get_attribute("open") == "true":
                 self.root.click()
@@ -64,6 +64,7 @@ def select_option(self, option_name: str, double_click=False):
                     )
                 else:
                     matching_menuitems[0].click()
+                if wait_for_selection:
                     self.wait.until(EC.element_to_be_selected(matching_menuitems[0]))
                 return self
             else:

tests/address_bar_and_search/test_google_search_counts_us.py

@@ -1,6 +1,5 @@
 from time import sleep
 
-import pytest
 from selenium.webdriver import Firefox
 
 from modules.browser_object import Navigation

tests/language_packs/test_language_pack_install_addons.py

@@ -57,7 +57,7 @@ def test_language_pack_install_from_addons(
     about_prefs = AboutPrefs(driver, category="general").open()
     language_dropdown = about_prefs.get_element("language-dropdown")
     dropdown = about_prefs.Dropdown(page=about_prefs, root=language_dropdown)
-    dropdown.select_option(drop_down_name, double_click=True)
+    dropdown.select_option(drop_down_name, double_click=True, wait_for_selection=False)
 
     about_prefs.custom_wait(timeout=15).until(
         lambda _: about_prefs.get_element("html-root").get_attribute("lang")

tests/preferences/test_firefox_home_on_launch.py

@@ -1,13 +1,10 @@
-from time import sleep
 
 import pytest
 from selenium.webdriver import Firefox
 
-from modules.browser_object import TabBar
-
-# from modules.page_object import AboutNewtab, AboutPrefs
-from modules.page_object import AboutPrefs
+from modules.browser_object import TabBar, PanelUi
 
+from modules.page_object import AboutPrefs, AboutNewtab
 
 @pytest.fixture()
 def set_prefs():
@@ -23,22 +20,23 @@ def test_firefox_home_on_launch(driver: Firefox, sys_platform: str):
     C143543: setting the default new window to be Firefox Home
     """
     # instantiate objs
-    # tabs = TabBar(driver)
+    tabs = TabBar(driver)
+    new_tab = AboutNewtab(driver)
     about_prefs = AboutPrefs(driver, category="home").open()
+    panel_ui = PanelUi(driver)
 
     # click the dropdown
     drop_down = about_prefs.get_element("home-new-window-dropdown")
     dropdown = about_prefs.Dropdown(page=about_prefs, root=drop_down)
-    dropdown.select_option("Firefox Home (Default)")
+    dropdown.select_option("Firefox Home (Default)", double_click=True)
 
     # make sure that the option was selected correctly
     assert drop_down.get_attribute("label") == "Firefox Home (Default)"
-    sleep(3)
-    driver.switch_to.new_window("window")
-    sleep(3)
+    panel_ui.open_panel_menu()
+    panel_ui.select_panel_setting("panel-ui-new-window")
     # # wait for the number of tabs and switch
-    # tabs.wait_for_num_tabs(2)
-    # driver.switch_to.window(driver.window_handles[-1])
+    tabs.wait_for_num_tabs(2)
+    driver.switch_to.window(driver.window_handles[-1])
     # sleep(10)
-    # # make sure we are on the correct new tab page
-    # assert about_prefs.get_element("body-logo") is not None
+    # make sure we are on the correct new tab page
+    assert new_tab.get_element("body-logo") is not None