Fix PanelUi instantiations

Author: Tracy-Walker

tests/bookmarks_and_history/test_clear_all_history.py

@@ -20,7 +20,8 @@ def test_clear_all_history(driver: Firefox):
     """
     C172045: Verify that the user can Clear all the History
     """
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
     gen_page = GenericPage(driver)
     panel_ui.open_history_menu()
     ba = BrowserActions(driver)

tests/bookmarks_and_history/test_clear_recent_history_displayed.py

@@ -13,7 +13,8 @@ def test_clear_recent_history_displayed(driver: Firefox):
     """
     C172043: Clear recent history panel displayed
     """
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
 
     panel_ui.open_panel_menu()
     with driver.context(driver.CONTEXT_CHROME):

tests/bookmarks_and_history/test_open_websites_from_history.py

@@ -29,7 +29,8 @@ def test_open_websites_from_history(driver: Firefox):
     """
     C118807: Verify that the user can open websites from the Toolbar History submenu
     """
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
 
     panel_ui.open_history_menu()
 

tests/bookmarks_and_history/test_opened_website_present_in_toolbar_history.py

@@ -26,7 +26,8 @@ def test_the_most_recent_website_is_present_in_history_menu(driver: Firefox):
     for url in WEBSITES:
         GenericPage(driver, url=url).open()
 
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
     panel_ui.open_history_menu()
 
     # Verify YouTube is present in the history menu and is on top of the list as the most recent website visited

tests/security_and_privacy/test_never_remember_browsing_history.py

@@ -57,7 +57,8 @@ def test_never_remember_browsing_history_from_panel(driver: Firefox):
     """
     C102381.2: Ensure that setting the browser to never remember history does not actually save any history
     """
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
     tabs = TabBar(driver)
     # util = Utilities()
 

tests/security_and_privacy/test_private_session_history_exclusion.py

@@ -22,7 +22,8 @@ def test_websites_visited_in_private_browser_not_displayed_in_history(driver: Fi
 
     initial_window_handle = driver.current_window_handle
 
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
     panel_ui.open_and_switch_to_new_window("private")
 
     driver.get(YOUTUBE_URL)

tests/security_and_privacy/test_third_party_content_blocked_private_browsing.py

@@ -29,7 +29,8 @@ def test_third_party_content_blocked_private_browsing_cross_site(driver: Firefox
     C446323.1: Ensure that third party content is blocked correctly
     """
     # Instantiate objects
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
     nav = Navigation(driver)
     tracker_panel = TrackerPanel(driver)
     tracker_website = GenericPage(driver, url=FIRST_TRACKER_WEBSITE)
@@ -69,7 +70,8 @@ def test_third_party_content_blocked_private_browsing_allowed_tracking(driver: F
     C446323.2: Ensure that some third party content is allowed
     """
     # Instantiate objects
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
     nav = Navigation(driver)
     tracker_panel = TrackerPanel(driver)
     tracker_website = GenericPage(driver, url=FIRST_TRACKER_WEBSITE)
@@ -106,7 +108,8 @@ def test_third_party_content_private_browsing_tracking_statuses(driver: Firefox)
     C446323.3: Ensure that the statuses of some third party content are loaded properly
     """
     # Instantiate objects
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
     nav = Navigation(driver)
     tracker_panel = TrackerPanel(driver)
     tracker_website = GenericPage(driver, url=SECOND_TRACKER_WEBSITE)

tests/security_and_privacy/test_undo_close_tab_private_browsing.py

@@ -20,7 +20,8 @@ def test_undo_close_tab_private_browsing(driver: Firefox, sys_platform: str):
     C120118: ensure that you can close a tab in private browsing window
     """
     # instantiate objs
-    panel_ui = PanelUi(driver).open()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
     nav = Navigation(driver)
     tabs = TabBar(driver)
     generic_page = GenericPage(driver, url="about:about")

tests/theme_and_toolbar/test_customize_themes_and_redirect.py

@@ -23,9 +23,10 @@ def test_redirect_to_addons(driver: Firefox):
     """
     C118173, ensures that the user is redirected to about:addons through the ui panel
     """
-    panel = PanelUi(driver).open()
-    panel.open_panel_menu()
-    panel.navigate_to_about_addons()
+    panel_ui = PanelUi(driver)
+    panel_ui.open()
+    panel_ui.open_panel_menu()
+    panel_ui.navigate_to_about_addons()
     windows = driver.window_handles
     driver.switch_to.window(windows[2])
     assert driver.current_url == "about:addons"