Merge pull request #115 from mozilla/sl/notifications-set-change

Verifying Set and Change Notifications

Author: sarinali

modules/data/about_prefs.components.json

@@ -258,6 +258,18 @@
         "groups": []
     },
 
+    "notifications-allow-button": {
+        "selectorData": "button[class='popup-notification-primary-button primary footer-button']",
+        "strategy": "css",
+        "groups": []
+    },
+
+    "notifications-block-button": {
+        "selectorData": "button[class='popup-notification-secondary-button footer-button']",
+        "strategy": "css",
+        "groups": []
+    },
+
     "cookies-shadow-root": {
         "selectorData": "dialog[buttons='accept,cancel']",
         "strategy": "css",
@@ -281,6 +293,30 @@
         ]
     },
 
+    "permissions-notifications-button": {
+        "selectorData": "notificationSettingsButton",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "permissions-notifications-popup-websites": {
+        "selectorData": "permissionsBox",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "permissions-notifications-popup-websites-item": {
+        "selectorData": "richlistitem[origin='{name}']",
+        "strategy": "css",
+        "groups": []
+    },
+
+    "permissions-notifications-popup-websites-item-status": {
+        "selectorData": "website-status",
+        "strategy": "class",
+        "groups": []
+    },
+
     "language-dropdown": {
         "selectorData": "primaryBrowserLocale",
         "strategy": "id",

modules/data/generic_page.components.json

@@ -5,6 +5,18 @@
         "groups": []
     },
 
+    "authorize-notifications-button": {
+        "selectorData": "button[onclick='notify.authorize()']",
+        "strategy": "css",
+        "groups": []
+    },
+
+    "show-notifications-button": {
+        "selectorData": "button[onclick='notify.show()']",
+        "strategy": "css",
+        "groups": []
+    },
+
     "mediawiki-image": {
         "selectorData": "mw-mmv-image",
         "strategy": "class",

modules/page_object_about_prefs.py

@@ -316,3 +316,9 @@ def get_clear_cookie_data_value(self) -> int:
             return number
         else:
             print("No number found in the string")
+
+    def get_iframe(self) -> WebElement:
+        """
+        Gets the webelement for the iframe that commonly appears in about:preferences
+        """
+        return self.get_element("browser-popup")

modules/util.py

@@ -7,6 +7,7 @@
 from os import remove
 from random import shuffle
 from typing import List, Literal, Union
+from urllib.parse import urlparse, urlunparse
 
 from faker import Faker
 from faker.providers import internet, misc
@@ -370,6 +371,16 @@ def assert_json_value(self, json_data, jsonpath_expr, expected_value):
             f"Expected {expected_value}, but got {match[0].value}",
         )
 
+    def get_domain_from_url(self, url: str) -> str:
+        """
+        Given a URL, it will extract the domain of the URL.
+
+        For example, "https://www.example.com/path/to/page?query=123#fragment" will product "https://www.example.com"
+        """
+        parsed_url = urlparse(url)
+        domain_parsed_url = parsed_url._replace(path="")
+        return urlunparse(domain_parsed_url)
+
 
 class BrowserActions:
     """

tests/address_bar_and_search/test_tile_menu_options.py

@@ -38,7 +38,7 @@
 )
 
 # first value in a tuple is the index of the card, second is the status of sponsorship
-card_indices = [(3, False), (0, True)]
+card_indices = [(4, False), (0, True)]
 
 
 def test_default_tile_hover_states(driver: Firefox):

tests/security_and_privacy/test_notifications_change_set.py

@@ -0,0 +1,66 @@
+import logging
+
+import pytest
+from selenium.webdriver import Firefox
+
+from modules.page_object import AboutPrefs, GenericPage
+from modules.util import BrowserActions, Utilities
+
+NOTIFICATIONS_SITE = "https://www.bennish.net/web-notifications.html"
+associated_labels = [
+    ("notifications-allow-button", "Allow", "granted"),
+    ("notifications-block-button", "Block", "denied"),
+]
+
+
+@pytest.fixture()
+def add_prefs():
+    return []
+
+
+@pytest.mark.parametrize("button_data, button_text, permission", associated_labels)
+def test_notifications_allow(
+    driver: Firefox, button_data: str, button_text: str, permission: str
+):
+    """
+    C159150: verifies that changing different settings allows for notifcations to be blocked
+    """
+    # instantiate objects
+    ba = BrowserActions(driver)
+    util = Utilities()
+    alert_page = GenericPage(driver, url=NOTIFICATIONS_SITE).open()
+    about_prefs = AboutPrefs(driver, category="privacy")
+
+    alert_page.get_element("authorize-notifications-button").click()
+    with driver.context(driver.CONTEXT_CHROME):
+        about_prefs.get_element(button_data).click()
+
+    check_notification_script = """
+        return Notification.permission;
+    """
+    permission_status = driver.execute_script(check_notification_script)
+
+    logging.info(f"Notification permission status: {permission_status}")
+    assert permission_status == permission
+
+    about_prefs.open()
+    about_prefs.get_element("permissions-notifications-button").click()
+
+    iframe = about_prefs.get_iframe()
+    ba.switch_to_iframe_context(iframe)
+
+    website_permissions = about_prefs.get_elements(
+        "permissions-notifications-popup-websites"
+    )
+    assert len(website_permissions) == 1
+
+    website_item = about_prefs.get_element(
+        "permissions-notifications-popup-websites-item",
+        labels=[util.get_domain_from_url(NOTIFICATIONS_SITE)],
+    )
+
+    notification_website_status = about_prefs.get_element(
+        "permissions-notifications-popup-websites-item-status",
+        parent_element=website_item,
+    )
+    assert notification_website_status.get_attribute("label") == button_text