Move URL constants

Author: soncuteanca

tests/security_and_privacy/test_phishing_and_malware_warnings.py

@@ -6,6 +6,9 @@
 
 from modules.browser_object_tabbar import TabBar
 
+PHISHING_URL = "http://www.itisatrap.org/firefox/its-a-trap.html"
+MALWARE_URL = "http://www.itisatrap.org/firefox/its-an-attack.html"
+
 
 @pytest.fixture()
 def add_prefs():
@@ -35,10 +38,9 @@ def test_phishing_and_malware_warning_errors(driver: Firefox):
     tabs = TabBar(driver)
 
     # Test phishing warning page
-    phishing_url = "http://www.itisatrap.org/firefox/its-a-trap.html"
-    phishing_error_title = get_error_title(driver, phishing_url)
+    phishing_error_title = get_error_title(driver, PHISHING_URL)
     assert phishing_error_title == "Deceptive site ahead", (
-        f"Expected error title 'Deceptive site ahead' not found at {phishing_url}. "
+        f"Expected error title 'Deceptive site ahead' not found at {PHISHING_URL}. "
         f"Actual: {phishing_error_title}"
     )
 
@@ -48,9 +50,8 @@ def test_phishing_and_malware_warning_errors(driver: Firefox):
     driver.switch_to.window(driver.window_handles[1])
 
     # Test malware warning page
-    malware_url = "http://www.itisatrap.org/firefox/its-an-attack.html"
-    malware_error_title = get_error_title(driver, malware_url)
+    malware_error_title = get_error_title(driver, MALWARE_URL)
     assert malware_error_title == "Visiting this website may harm your computer", (
-        f"Expected error title 'Visiting this website may harm your computer' not found at {malware_url}. "
+        f"Expected error title 'Visiting this website may harm your computer' not found at {MALWARE_URL}. "
         f"Actual: {malware_error_title}"
     )