Skip to content

vs/fix split errors #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsangereanMOZ merged 3 commits into from
Feb 3, 2026
Merged

vs/fix split errors #1031

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8da5a4b
vs/fix split errors
vsangereanMOZ Jan 23, 2026
b77227b
Merge branch 'main' into vs/fix-splits
vsangereanMOZ Jan 28, 2026
2cf06c1
vs/changed to Global
vsangereanMOZ Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions manifests/testkey.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
NUM_FUNCTIONAL_SPLITS = 2
MAX_DEPTH = 5
SUITE_TUPLE_RE = re.compile(r'\s+return \("S?(\d+)", ?".*"\)')
DEFAULT_FUNCTIONAL_SPLIT = "functional1"


def sysname():
Expand Down Expand Up @@ -66,7 +67,7 @@ def get_subtests(entry: dict) -> list:
def clean_prompt(prompt: str) -> str:
"""Clean up prompts"""
if prompt[0].islower():
prompt[0] = prompt[0].upper()
prompt = prompt[0].upper() + prompt[1:]
if "?" not in prompt:
prompt = prompt.strip() + "? "
if not prompt.endswith(" "):
Expand Down Expand Up @@ -383,7 +384,7 @@ def addtests(self, interactive=True):
"Should this test run in a Scheduled Functional split? "
"(Say no if unsure.) "
):
newkey[suite][testfile]["splits"] = ["functional1"]
newkey[suite][testfile]["splits"] = [DEFAULT_FUNCTIONAL_SPLIT]
self.rebalance_functionals()

print(
Expand Down