From 8e7d4eb7a1e6068df5e225ca4ab890d4e4e74c41 Mon Sep 17 00:00:00 2001 From: Tracy Date: Wed, 24 Sep 2025 11:30:35 -0500 Subject: [PATCH 1/3] Find "log" instead of "pro" --- tests/find_toolbar/test_find_toolbar_nav.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/find_toolbar/test_find_toolbar_nav.py b/tests/find_toolbar/test_find_toolbar_nav.py index fbff05790..1a573a3d0 100644 --- a/tests/find_toolbar/test_find_toolbar_nav.py +++ b/tests/find_toolbar/test_find_toolbar_nav.py @@ -16,11 +16,11 @@ def test_case(): TOLERANCE = 3 TARGET_PAGE = "about:about" -PROCESSES_SELECTOR = "a[href='about:processes']" -PROTECTIONS_SELECTOR = "a[href='about:protections']" +LOGGING_SELECTOR = "a[href='about:logging']" +LOGO_SELECTOR = "a[href='about:logo']" -first_match = (By.CSS_SELECTOR, PROCESSES_SELECTOR) -fourth_match = (By.CSS_SELECTOR, PROTECTIONS_SELECTOR) +first_match = (By.CSS_SELECTOR, LOGGING_SELECTOR) +fourth_match = (By.CSS_SELECTOR, LOGO_SELECTOR) def are_lists_different(a: int, b: int) -> bool: @@ -40,9 +40,9 @@ def test_find_toolbar_navigation( driver.get(TARGET_PAGE) find_toolbar.open() - find_toolbar.find("pro") + find_toolbar.find("log") match_status = find_toolbar.match_dict - assert match_status["total"] == 4 + assert match_status["total"] == 5 # Sometimes we get a match that isn't the first # (This also tests that the number is correct) From 5b2b1eb69c64232dc68463051ba2f4d1a42108fc Mon Sep 17 00:00:00 2001 From: Tracy Date: Wed, 24 Sep 2025 11:30:35 -0500 Subject: [PATCH 2/3] Find "log" instead of "pro" --- tests/find_toolbar/test_find_toolbar_nav.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/find_toolbar/test_find_toolbar_nav.py b/tests/find_toolbar/test_find_toolbar_nav.py index fbff05790..1a573a3d0 100644 --- a/tests/find_toolbar/test_find_toolbar_nav.py +++ b/tests/find_toolbar/test_find_toolbar_nav.py @@ -16,11 +16,11 @@ def test_case(): TOLERANCE = 3 TARGET_PAGE = "about:about" -PROCESSES_SELECTOR = "a[href='about:processes']" -PROTECTIONS_SELECTOR = "a[href='about:protections']" +LOGGING_SELECTOR = "a[href='about:logging']" +LOGO_SELECTOR = "a[href='about:logo']" -first_match = (By.CSS_SELECTOR, PROCESSES_SELECTOR) -fourth_match = (By.CSS_SELECTOR, PROTECTIONS_SELECTOR) +first_match = (By.CSS_SELECTOR, LOGGING_SELECTOR) +fourth_match = (By.CSS_SELECTOR, LOGO_SELECTOR) def are_lists_different(a: int, b: int) -> bool: @@ -40,9 +40,9 @@ def test_find_toolbar_navigation( driver.get(TARGET_PAGE) find_toolbar.open() - find_toolbar.find("pro") + find_toolbar.find("log") match_status = find_toolbar.match_dict - assert match_status["total"] == 4 + assert match_status["total"] == 5 # Sometimes we get a match that isn't the first # (This also tests that the number is correct) From ca89babeffeedaec4b579f5656ba8a2849de6daf Mon Sep 17 00:00:00 2001 From: Tracy Date: Wed, 24 Sep 2025 12:07:59 -0500 Subject: [PATCH 3/3] Merge main --- ...est_download_triggered_on_content_disposition_attachment.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/pdf_viewer/test_download_triggered_on_content_disposition_attachment.py b/tests/pdf_viewer/test_download_triggered_on_content_disposition_attachment.py index f27a59bf3..b7ddfa03d 100644 --- a/tests/pdf_viewer/test_download_triggered_on_content_disposition_attachment.py +++ b/tests/pdf_viewer/test_download_triggered_on_content_disposition_attachment.py @@ -39,10 +39,13 @@ def test_download_panel_triggered_on_content_disposition_attachment( nav = Navigation(driver) about_prefs = AboutPrefs(driver, category="general").open() browser_actions = BrowserActions(driver) + # search for Applications section in settings about_prefs.find_in_settings("appl") + # set download option for pdf as always ask about_prefs.select_content_and_action("application/pdf", "Always ask") + # search pdf file tabs.open() nav.search(CONTENT_DISPOSITION_ATTACHMENT_URL)