bug(auth): fix broken @fxa imports

Because:
- Build finalize was clobbering js output produces by build-ts which effectively undid any tsc-aliases applied by typescript compilation

This Commit:
- Creates a script for copying assets and not code
- Removes the build-finalize script that was clobbering assets

Author: dschom

packages/fxa-auth-server/package.json

@@ -10,11 +10,11 @@
   },
   "scripts": {
     "prebuild": "nx l10n-prime && nx install-ejs",
-    "build": "nx build-l10n && nx build-ts && nx build-css && nx build-finalize",
+    "build": "nx build-l10n && nx build-css && nx build-ts && nx build-copy-assets",
     "build-l10n": "nx l10n-merge && nx l10n-merge-test",
+    "build-copy-assets": "./scripts/copy-assets.sh",
     "build-css": "nx emails-scss",
     "build-ts": "tsc --build && tsc-alias",
-    "build-finalize": "cp -R config public lib scripts dist/packages/fxa-auth-server",
     "build-storybook": "NODE_OPTIONS=--openssl-legacy-provider STORYBOOK_BUILD=true storybook build && yarn build-storybook-copy-locales && yarn build-storybook-copy-templates",
     "build-storybook-copy-locales": "mkdir -p ./storybook-static/public/locales && cp -R ./public/locales ./storybook-static/public",
     "build-storybook-copy-templates": "mkdir -p ./storybook-static/lib/senders/emails/templates && cp -R ./lib/senders/emails ./storybook-static/lib/senders",

packages/fxa-auth-server/scripts/copy-assets.sh

@@ -0,0 +1,10 @@
+#!/bin/bash -e
+
+#Make sure all directories exist
+find config lib scripts bin public -type d | \
+xargs -L1 bash -c 'mkdir -p dist/packages/fxa-auth-server/$0'
+
+# Copy all non-code files into the dist. Basically everything except javascript, typescript and shell scripts.
+find config lib scripts bin public -type f | \
+grep --invert -E "\.js$|\.ts$|\.sh" | \
+xargs -L1 bash -c 'cp $0 dist/packages/fxa-auth-server/$0'

packages/fxa-auth-server/tsconfig.json

@@ -14,9 +14,11 @@
     "noImplicitAny": false
   },
   "include": [
-    "bin/*", // Include bin so that it's included in `build-ts`, specifically for "tsc-alias".
-    "lib/**/*.ts",
-    "lib/**/*.js",
-    "scripts/**/*.ts"
+    // Note, we want to include javascript and type script files. This ensures
+    // ts aliases (ie imports for @fxa/...) work.
+    "bin/*",
+    "config/*",
+    "lib/**/*",
+    "scripts/**/*"
   ]
 }