Skip to content

Commit 91a2233

Browse files
committed
fix dependency order for build and fix test
1 parent 153d3f1 commit 91a2233

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

libs/accounts/email-renderer/project.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"tags": ["scope:shared:lib"],
77
"targets": {
88
"build": {
9-
"dependsOn": ["l10n-merge", "build-css", "build-ts"],
9+
"dependsOn": ["build-ts", "l10n-merge", "build-css"],
1010
"executor": "nx:run-commands",
1111
"options": {
1212
"commands": [
@@ -40,7 +40,7 @@
4040
}
4141
},
4242
"test-unit": {
43-
"dependsOn": ["l10n-merge"],
43+
"dependsOn": ["l10n-prime", "l10n-merge"],
4444
"executor": "@nx/jest:jest",
4545
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
4646
"options": {

libs/accounts/email-renderer/src/renderer/email-link-builder.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,14 +177,12 @@ describe('EmailLinkBuilder', () => {
177177
const opts = {
178178
url: 'http://localhost:3030/reset_password',
179179
email: 'test@example.com',
180-
emailToHashWith: 'hash@example.com',
181180
};
182181

183182
const link = linkBuilder.buildPasswordChangeRequiredLink(opts);
184183

185184
expect(link).toContain('http://localhost:3030/reset_password');
186185
expect(link).toContain('email=test%40example.com');
187-
expect(link).toContain('email_to_hash_with=hash%40example.com');
188186
expect(link).toContain('utm_medium=email');
189187
expect(link).toContain('utm_campaign=fx-password-reset-required');
190188
});

0 commit comments

Comments
 (0)