Bug 1919891 - Part 2: Removed redundant parameter calls with default values r=android-reviewers,twhite

andrei popa · andrei popa · commit 008a615d992f · 2025-01-21T08:02:30.000Z
Differential Revision: https://phabricator.services.mozilla.com/D234165
diff --git a/mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksFeature.kt b/mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksFeature.kt
@@ -146,8 +146,6 @@ class AppLinksFeature(
             } else {
                 message
             },
-            positiveButtonText = R.string.mozac_feature_applinks_confirm_dialog_confirm,
-            negativeButtonText = R.string.mozac_feature_applinks_confirm_dialog_deny,
         )
     }
 
diff --git a/mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksInterceptor.kt b/mobile/android/android-components/components/feature/app-links/src/main/java/mozilla/components/feature/app/links/AppLinksInterceptor.kt
@@ -315,8 +315,6 @@ class AppLinksInterceptor(
             dialogTitleText = dialogTitle,
             dialogMessageString = dialogMessage,
             showCheckbox = showCheckbox,
-            positiveButtonText = R.string.mozac_feature_applinks_confirm_dialog_confirm,
-            negativeButtonText = R.string.mozac_feature_applinks_confirm_dialog_deny,
             maxSuccessiveDialogMillisLimit = MAX_SUCCESSIVE_DIALOG_MILLIS_LIMIT,
         )
     }

Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,6 @@ class AppLinksFeature(`
`146`	`146`	`} else {`
`147`	`147`	`message`
`148`	`148`	`},`
`149`		`- positiveButtonText = R.string.mozac_feature_applinks_confirm_dialog_confirm,`
`150`		`- negativeButtonText = R.string.mozac_feature_applinks_confirm_dialog_deny,`
`151`	`149`	`)`
`152`	`150`	`}`
`153`	`151`
Original file line number	Diff line number	Diff line change
`@@ -315,8 +315,6 @@ class AppLinksInterceptor(`
`315`	`315`	`dialogTitleText = dialogTitle,`
`316`	`316`	`dialogMessageString = dialogMessage,`
`317`	`317`	`showCheckbox = showCheckbox,`
`318`		`- positiveButtonText = R.string.mozac_feature_applinks_confirm_dialog_confirm,`
`319`		`- negativeButtonText = R.string.mozac_feature_applinks_confirm_dialog_deny,`
`320`	`318`	`maxSuccessiveDialogMillisLimit = MAX_SUCCESSIVE_DIALOG_MILLIS_LIMIT,`
`321`	`319`	`)`
`322`	`320`	`}`