Bug 1689600 - Making the Drag&Drop downloading be aware of cookieJarSettings on Windows platform. r=smaug, a=pascalc

The channel used on Windows for Drag&Drop downloading doesn't have the correct
cookieJarSettings. The patch fixes this issue that it will pass the
correct cookieJarSettings to the channel.

Differential Revision: https://phabricator.services.mozilla.com/D103678

Author: artines1

widget/windows/nsDataObj.cpp

@@ -13,6 +13,7 @@
 #include "nsArrayUtils.h"
 #include "nsClipboard.h"
 #include "nsReadableUtils.h"
+#include "nsICookieJarSettings.h"
 #include "nsITransferable.h"
 #include "nsISupportsPrimitives.h"
 #include "IEnumFE.h"
@@ -70,16 +71,16 @@ nsDataObj::CStream::~CStream() {}
 // helper - initializes the stream
 nsresult nsDataObj::CStream::Init(nsIURI* pSourceURI,
                                   nsContentPolicyType aContentPolicyType,
-                                  nsIPrincipal* aRequestingPrincipal) {
+                                  nsIPrincipal* aRequestingPrincipal,
+                                  nsICookieJarSettings* aCookieJarSettings) {
   // we can not create a channel without a requestingPrincipal
   if (!aRequestingPrincipal) {
     return NS_ERROR_FAILURE;
   }
   nsresult rv;
   rv = NS_NewChannel(getter_AddRefs(mChannel), pSourceURI, aRequestingPrincipal,
                      nsILoadInfo::SEC_ALLOW_CROSS_ORIGIN_INHERITS_SEC_CONTEXT,
-                     aContentPolicyType,
-                     nullptr,  // nsICookieJarSettings
+                     aContentPolicyType, aCookieJarSettings,
                      nullptr,  // PerformanceStorage
                      nullptr,  // loadGroup
                      nullptr,  // aCallbacks
@@ -313,8 +314,14 @@ HRESULT nsDataObj::CreateStream(IStream** outStream) {
       mTransferable->GetRequestingPrincipal();
   MOZ_ASSERT(requestingPrincipal, "can not create channel without a principal");
 
+  // Note that the cookieJarSettings could be null if the data object is for the
+  // image copy. We will fix this in Bug 1690532.
+  nsCOMPtr<nsICookieJarSettings> cookieJarSettings =
+      mTransferable->GetCookieJarSettings();
+
   nsContentPolicyType contentPolicyType = mTransferable->GetContentPolicyType();
-  rv = pStream->Init(sourceURI, contentPolicyType, requestingPrincipal);
+  rv = pStream->Init(sourceURI, contentPolicyType, requestingPrincipal,
+                     cookieJarSettings);
   if (NS_FAILED(rv)) {
     pStream->Release();
     return E_FAIL;

widget/windows/nsDataObj.h

@@ -19,6 +19,7 @@
 #include "nsCOMArray.h"
 #include "nsITimer.h"
 
+class nsICookieJarSettings;
 class nsIThread;
 class nsIPrincipal;
 class CEnumFormatEtc;
@@ -222,7 +223,8 @@ class nsDataObj : public IDataObject, public IDataObjectAsyncCapability {
    public:
     CStream();
     nsresult Init(nsIURI* pSourceURI, nsContentPolicyType aContentPolicyType,
-                  nsIPrincipal* aRequestingPrincipal);
+                  nsIPrincipal* aRequestingPrincipal,
+                  nsICookieJarSettings* aCookieJarSettings);
 
     NS_DECL_ISUPPORTS
     NS_DECL_NSIREQUESTOBSERVER