Bug 1945083 - [contextual-password-manager] Ensure password is concealed when rebuilding snapshots. r=rsafaeian,credential-management-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D236601

Author: Micah Tigley

toolkit/components/satchel/megalist/aggregator/datasources/DataSourceBase.sys.mjs

@@ -339,6 +339,7 @@ export class DataSourceBase {
             i < this.lines.length &&
             currentRecord == this.lines[i].record
           ) {
+            this.lines[i].concealed = true;
             yield this.lines[i];
             i += 1;
           }
@@ -357,6 +358,7 @@ export class DataSourceBase {
       // No search text is provided - send all lines out, count records
       let currentRecord;
       for (const line of this.lines) {
+        line.concealed = true;
         yield line;
 
         if (line.record != currentRecord) {

toolkit/components/satchel/megalist/content/tests/browser/browser_passwords_create_login.js

@@ -36,17 +36,6 @@ function addLogin(megalist, { origin, username, password }) {
   saveButton.buttonEl.click();
 }
 
-function waitForSnapshots() {
-  info("Wait for headers.");
-  const sidebar = document.getElementById("sidebar");
-  const megalistComponent =
-    sidebar.contentDocument.querySelector("megalist-alpha");
-  return BrowserTestUtils.waitForCondition(
-    () => megalistComponent.header,
-    "Megalist header loaded."
-  );
-}
-
 function waitForPopup(megalist, element) {
   info(`Wait for ${element} popup`);
   const loginForm = megalist.querySelector("login-form");

toolkit/components/satchel/megalist/content/tests/browser/browser_passwords_sidebar.js

@@ -50,6 +50,17 @@ function checkPasswordCardFields(megalist) {
   }
 }
 
+async function waitForPasswordConceal(passwordLine) {
+  const concealedPromise = BrowserTestUtils.waitForMutationCondition(
+    passwordLine,
+    {
+      attributeFilter: ["inputtype"],
+    },
+    () => passwordLine.loginLine.getAttribute("inputtype") === "password"
+  );
+  return concealedPromise;
+}
+
 add_setup(async function () {
   await SpecialPowers.pushPrefEnv({
     set: [
@@ -154,6 +165,7 @@ add_task(async function test_login_line_commands() {
 
 add_task(async function test_passwords_menu_external_links() {
   const passwordsSidebar = await openPasswordsSidebar();
+  await waitForSnapshots();
   const menu = passwordsSidebar.querySelector("panel-list");
   const menuButton = passwordsSidebar.querySelector("#more-options-menubutton");
 
@@ -200,6 +212,7 @@ async function waitForMigrationWizard() {
 
 add_task(async function test_passwords_menu_import_from_browser() {
   const passwordsSidebar = await openPasswordsSidebar();
+  await waitForSnapshots();
   const menu = passwordsSidebar.querySelector("panel-list");
   const menuButton = passwordsSidebar.querySelector("#more-options-menubutton");
 
@@ -214,3 +227,42 @@ add_task(async function test_passwords_menu_import_from_browser() {
   BrowserTestUtils.removeTab(gBrowser.selectedTab);
   SidebarController.hide();
 });
+
+add_task(async function test_passwords_visibility_when_view_shown() {
+  const login = TEST_LOGIN_1;
+  await LoginTestUtils.addLogin(login);
+
+  let megalist = await openPasswordsSidebar();
+  await checkAllLoginsRendered(megalist);
+
+  info("Test that reopening the sidebar should have password concealed.");
+  let passwordCard = megalist.querySelector("password-card");
+  await waitForReauth(async () => {
+    return await waitForPasswordReveal(passwordCard.passwordLine);
+  });
+
+  info("Hide the sidebar");
+  SidebarController.hide();
+  await BrowserTestUtils.waitForCondition(() => {
+    return !SidebarController.isOpen;
+  }, "Sidebar did not close.");
+
+  info("Open sidebar and check visibility of password field");
+  megalist = await openPasswordsSidebar();
+  await checkAllLoginsRendered(megalist);
+  passwordCard = megalist.querySelector("password-card");
+  await waitForPasswordConceal(passwordCard.passwordLine);
+  ok(true, "Password is hidden.");
+
+  info(
+    "Test that switching panels then switching back to Passwords should have password concealed."
+  );
+  await SidebarController.show("viewBookmarksSidebar");
+  megalist = await openPasswordsSidebar();
+  await checkAllLoginsRendered(megalist);
+  passwordCard = megalist.querySelector("password-card");
+  await waitForPasswordConceal(passwordCard.passwordLine);
+  ok(true, "Password is hidden.");
+
+  SidebarController.hide();
+});

toolkit/components/satchel/megalist/content/tests/browser/head.js

@@ -210,3 +210,14 @@ function waitForPasswordReveal(passwordLine) {
   passwordLine.revealBtn.click();
   return revealBtnPromise;
 }
+
+function waitForSnapshots() {
+  info("Wait for headers.");
+  const sidebar = document.getElementById("sidebar");
+  const megalistComponent =
+    sidebar.contentDocument.querySelector("megalist-alpha");
+  return BrowserTestUtils.waitForCondition(
+    () => megalistComponent.header,
+    "Megalist header loaded."
+  );
+}