Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 1eb2c86

Browse files
committed
Bug 1919640 - Avoid expensive check for changed files when bootstrapping. r=taskgraph-reviewers,jcristau
Loading the tasks for the toolchain kind doesn't trigger the optimization passes that use files_changed, so we can just override the parameter to avoid the defaults expensively trying to determine what they are. We also change the default parameters in gecko_taskgraph to apply the same change as taskcluster/taskgraph#624. Differential Revision: https://phabricator.services.mozilla.com/D234628
1 parent 7e79162 commit 1eb2c86

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

python/mozbuild/mozbuild/toolchains.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def toolchain_task_definitions():
1414

1515
# Don't import globally to allow this module being imported without
1616
# the taskgraph module being available (e.g. standalone js)
17-
params = {"level": os.environ.get("MOZ_SCM_LEVEL", "3")}
17+
params = {"level": os.environ.get("MOZ_SCM_LEVEL", "3"), "files_changed": []}
1818
root_dir = os.path.join(os.path.dirname(__file__), "..", "..", "..", "taskcluster")
1919
toolchains = load_tasks_for_kind(params, "toolchain", root_dir=root_dir)
2020
aliased = {}

taskcluster/gecko_taskgraph/parameters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def get_defaults(repo_root=None):
116116
"base_repository": "https://hg.mozilla.org/mozilla-unified",
117117
"build_number": 1,
118118
"enable_always_target": ["docker-image"],
119-
"files_changed": sorted(get_locally_changed_files(repo_root)),
119+
"files_changed": lambda: sorted(get_locally_changed_files(repo_root)),
120120
"head_repository": "https://hg.mozilla.org/mozilla-central",
121121
"hg_branch": "default",
122122
"message": "",

0 commit comments

Comments
 (0)