Bug 1691126 - Save to Pocket button test. r=gvn, a=pascalc

Differential Revision: https://phabricator.services.mozilla.com/D104262

Author: ScottDowne

browser/components/pocket/content/main.js

@@ -143,11 +143,17 @@ var pktUI = (function() {
       var startheight = 490;
       var inOverflowMenu = isInOverflowMenu();
       var controlvariant = pktApi.getSignupPanelTabTestVariant() == "control";
+      var loggedOutVariant = Services.prefs.getCharPref(
+        "extensions.pocket.loggedOutVariant"
+      );
 
       if (inOverflowMenu) {
         startheight = overflowMenuHeight;
       } else {
         startheight = 460;
+        if (loggedOutVariant === "button_variant") {
+          startheight = 406;
+        }
       }
       if (!controlvariant) {
         startheight = 427;
@@ -163,7 +169,7 @@ var pktUI = (function() {
         "about:pocket-signup?pockethost=" +
           Services.prefs.getCharPref("extensions.pocket.site") +
           "&loggedOutVariant=" +
-          Services.prefs.getCharPref("extensions.pocket.loggedOutVariant") +
+          loggedOutVariant +
           "&variant=" +
           variant +
           "&controlvariant=" +

browser/components/pocket/content/panels/js/signup.js

@@ -134,6 +134,8 @@ PKT_SIGNUP_OVERLAY.prototype = {
     this.dictJSON.variant = this.variant ? this.variant : "undefined";
     this.dictJSON.pockethost = this.pockethost;
     this.dictJSON.showlearnmore = true;
+    this.dictJSON.utmCampaign = "logged_out_save_test";
+    this.dictJSON.utmSource = "control";
 
     // extra modifier class for collapsed state
     if (this.inoverflowmenu) {
@@ -155,18 +157,34 @@ PKT_SIGNUP_OVERLAY.prototype = {
         variant_a: "variant_a",
         variant_b: "variant_b",
         variant_c: "variant_c",
+        button_variant: "signupstoryboard_shell",
+        button_control: "signupstoryboard_shell",
       };
 
-      if (this.loggedOutVariant !== `control`) {
+      let loggedOutVariantTemplate = variants[this.loggedOutVariant];
+      if (
+        this.loggedOutVariant === "button_variant" ||
+        this.loggedOutVariant === "button_control"
+      ) {
+        this.dictJSON.buttonVariant = true;
+        this.dictJSON.utmCampaign = "logged_out_button_test";
+        this.dictJSON.utmSource = "button_control";
+        if (this.loggedOutVariant === "button_variant") {
+          this.dictJSON.oneButton = true;
+          this.dictJSON.utmSource = "button_variant";
+        }
+      }
+
+      if (loggedOutVariantTemplate !== `signupstoryboard_shell`) {
         $("body").addClass(`
-          los_variant los_${variants[this.loggedOutVariant]}
+          los_variant los_${loggedOutVariantTemplate}
         `);
       }
 
       $("body").append(
-        Handlebars.templates[
-          variants[this.loggedOutVariant] || variants.control
-        ](this.dictJSON)
+        Handlebars.templates[loggedOutVariantTemplate || variants.control](
+          this.dictJSON
+        )
       );
     }