Bug 1687212 [Wayland] Set mAttached flag before wl_surface_commit() to avoid potential race condition, r=jhorak, a=pascalc

Differential Revision: https://phabricator.services.mozilla.com/D104045

Author: stransky

widget/gtk/WindowSurfaceWayland.cpp

@@ -379,10 +379,10 @@ void WindowBackBuffer::Attach(wl_surface* aSurface) {
 
   wl_buffer* buffer = GetWlBuffer();
   if (buffer) {
+    mAttached = true;
     wl_surface_attach(aSurface, buffer, 0, 0);
     wl_surface_commit(aSurface);
     wl_display_flush(WaylandDisplayGetWLDisplay());
-    SetAttached();
   }
 }
 

widget/gtk/WindowSurfaceWayland.h

@@ -55,7 +55,6 @@ class WindowBackBuffer {
   void Attach(wl_surface* aSurface);
   void Detach(wl_buffer* aBuffer);
   bool IsAttached() { return mAttached; }
-  void SetAttached() { mAttached = true; };
 
   void Clear();
   bool Create(int aWidth, int aHeight);