Bug 1691169 - Remove unused code that indicated "bright titlebar foreground" to the widget. r=spohl

Depends on D104300

Differential Revision: https://phabricator.services.mozilla.com/D104301

Author: mstange

dom/xul/ChromeObserver.cpp

@@ -102,19 +102,6 @@ void ChromeObserver::SetDrawsTitle(bool aState) {
   }
 }
 
-void ChromeObserver::UpdateBrightTitlebarForeground() {
-  nsIWidget* mainWidget = GetWindowWidget();
-  if (mainWidget) {
-    // We can do this synchronously because SetBrightTitlebarForeground doesn't
-    // have any synchronous effects apart from a harmless invalidation.
-    mainWidget->SetUseBrightTitlebarForeground(
-        mDocument->GetDocumentLWTheme() == Document::Doc_Theme_Bright ||
-        mDocument->GetRootElement()->AttrValueIs(
-            kNameSpaceID_None, nsGkAtoms::brighttitlebarforeground, u"true"_ns,
-            eCaseMatters));
-  }
-}
-
 class MarginSetter : public Runnable {
  public:
   explicit MarginSetter(nsIWidget* aWidget)
@@ -196,9 +183,6 @@ void ChromeObserver::AttributeChanged(dom::Element* aElement,
       // if the lwtheme changed, make sure to reset the document lwtheme
       // cache
       mDocument->ResetDocumentLWTheme();
-      UpdateBrightTitlebarForeground();
-    } else if (aName == nsGkAtoms::brighttitlebarforeground) {
-      UpdateBrightTitlebarForeground();
     }
   } else {
     if (aName == nsGkAtoms::hidechrome) {
@@ -213,9 +197,6 @@ void ChromeObserver::AttributeChanged(dom::Element* aElement,
                 aName == nsGkAtoms::lwthemetextcolor)) {
       // if the lwtheme changed, make sure to restyle appropriately
       mDocument->ResetDocumentLWTheme();
-      UpdateBrightTitlebarForeground();
-    } else if (aName == nsGkAtoms::brighttitlebarforeground) {
-      UpdateBrightTitlebarForeground();
     } else if (aName == nsGkAtoms::drawintitlebar) {
       SetDrawsInTitlebar(false);
     } else if (aName == nsGkAtoms::drawtitle) {

dom/xul/ChromeObserver.h

@@ -29,7 +29,6 @@ class ChromeObserver final : public nsStubMutationObserver {
   nsIWidget* GetWindowWidget();
   void SetDrawsInTitlebar(bool aState);
   void SetDrawsTitle(bool aState);
-  void UpdateBrightTitlebarForeground();
   void SetChromeMargins(const nsAttrValue* aValue);
   nsresult HideWindowChrome(bool aShouldHide);
 

widget/cocoa/nsCocoaWindow.h

@@ -49,7 +49,6 @@ typedef struct _nsCocoaWindowList {
 
   BOOL mBeingShown;
   BOOL mDrawTitle;
-  BOOL mBrightTitlebarForeground;
   BOOL mUseMenuStyle;
   BOOL mIsAnimationSuppressed;
 
@@ -98,9 +97,6 @@ typedef struct _nsCocoaWindowList {
 - (void)setWantsTitleDrawn:(BOOL)aDrawTitle;
 - (BOOL)wantsTitleDrawn;
 
-- (void)setUseBrightTitlebarForeground:(BOOL)aBrightForeground;
-- (BOOL)useBrightTitlebarForeground;
-
 - (void)disableSetNeedsDisplay;
 - (void)enableSetNeedsDisplay;
 
@@ -307,7 +303,6 @@ class nsCocoaWindow final : public nsBaseWidget, public nsPIWidgetCocoa {
   virtual void SetSupportsNativeFullscreen(bool aShow) override;
   virtual void SetWindowAnimationType(WindowAnimationType aType) override;
   virtual void SetDrawsTitle(bool aDrawTitle) override;
-  virtual void SetUseBrightTitlebarForeground(bool aBrightForeground) override;
   virtual nsresult SetNonClientMargins(LayoutDeviceIntMargin& aMargins) override;
   virtual void SetDrawsInTitlebar(bool aState) override;
   virtual void UpdateThemeGeometries(const nsTArray<ThemeGeometry>& aThemeGeometries) override;

widget/cocoa/nsCocoaWindow.mm

@@ -2475,14 +2475,6 @@ static inline CGAffineTransform GfxMatrixToCGAffineTransform(const gfx::Matrix&
   NS_OBJC_END_TRY_ABORT_BLOCK;
 }
 
-void nsCocoaWindow::SetUseBrightTitlebarForeground(bool aBrightForeground) {
-  NS_OBJC_BEGIN_TRY_ABORT_BLOCK;
-
-  [mWindow setUseBrightTitlebarForeground:aBrightForeground];
-
-  NS_OBJC_END_TRY_ABORT_BLOCK;
-}
-
 nsresult nsCocoaWindow::SetNonClientMargins(LayoutDeviceIntMargin& margins) {
   NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT;
 
@@ -3162,7 +3154,6 @@ - (id)initWithContentRect:(NSRect)aContentRect
   mDirtyRect = NSZeroRect;
   mBeingShown = NO;
   mDrawTitle = NO;
-  mBrightTitlebarForeground = NO;
   mUseMenuStyle = NO;
   mTouchBar = nil;
   mIsAnimationSuppressed = NO;
@@ -3344,15 +3335,6 @@ - (BOOL)wantsTitleDrawn {
   return mDrawTitle;
 }
 
-- (void)setUseBrightTitlebarForeground:(BOOL)aBrightForeground {
-  mBrightTitlebarForeground = aBrightForeground;
-  [[self standardWindowButton:NSWindowFullScreenButton] setNeedsDisplay:YES];
-}
-
-- (BOOL)useBrightTitlebarForeground {
-  return mBrightTitlebarForeground;
-}
-
 - (NSView*)trackingAreaView {
   NSView* contentView = [self contentView];
   return [contentView superview] ? [contentView superview] : contentView;

widget/nsIWidget.h

@@ -1186,12 +1186,6 @@ class nsIWidget : public nsISupports {
    */
   virtual void SetDrawsTitle(bool aDrawTitle) {}
 
-  /**
-   * Indicates whether the widget should attempt to make titlebar controls
-   * easier to see on dark titlebar backgrounds.
-   */
-  virtual void SetUseBrightTitlebarForeground(bool aBrightForeground) {}
-
   /**
    * Hide window chrome (borders, buttons) for this widget.
    *

xpcom/ds/StaticAtoms.py

@@ -200,7 +200,6 @@
     Atom("browser", "browser"),
     Atom("mozbrowser", "mozbrowser"),
     Atom("button", "button"),
-    Atom("brighttitlebarforeground", "brighttitlebarforeground"),
     Atom("callTemplate", "call-template"),
     Atom("canvas", "canvas"),
     Atom("caption", "caption"),