Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 71d3e0e

Browse files
natechapinmoz-wptsync-bot
authored andcommitted
Bug 1945286 [wpt PR 50422] - Remove special boolean handling in ResolveToConfigResolved::React(), a=testonly
Automatic update from web-platform-tests Remove special boolean handling in ResolveToConfigResolved::React() Instead of following standard JS rules for coercing an aribtary value to a boolean, it was treating non-booleans as false. A use counter shows that this behavior isn't relied upon, so use the standard behavior. Change-Id: I3b4424064f6728b8206166d3df86dd42b71af520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6219805 Commit-Queue: Nate Chapin <[email protected]> Reviewed-by: Maks Orlovich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1414449} -- wpt-commits: 74bb7c02d56981377136ea189b01b94d8dbbdb52 wpt-pr: 50422
1 parent 4852fa0 commit 71d3e0e

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

testing/web-platform/tests/fenced-frame/resolve-to-config-promise.https.html

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,15 @@
6464
promise_test(async(t) => {
6565
const key = token();
6666

67-
// This should still resolve, but resolve to a URN.
6867
const urn = await generateURNFromFledge("resources/embeddee.html", [key],
69-
[], delayValue("invalid", 0));
70-
assert_false(urn instanceof FencedFrameConfig);
68+
[], delayValue("non-boolean", 0));
69+
assert_true(urn instanceof FencedFrameConfig);
7170
const fencedframe = attachFencedFrame(urn);
7271

7372
const page1_resp = await nextValueFromServer(key);
7473
assert_equals(page1_resp, "PASS",
7574
"The page should have loaded.");
76-
}, 'resolveToConfig set to a promise that resolves to an invalid value');
75+
}, 'resolveToConfig set to a promise that resolves to an non-boolean value');
7776

7877
</script>
7978
</body>

0 commit comments

Comments
 (0)