Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit 7e22a43

Browse files
nidhijajumoz-wptsync-bot
authored andcommitted
Bug 1729382 [wpt PR 30366] - Update files in wpt/webtransport, a=testonly
Automatic update from web-platform-tests Update files in wpt/webtransport This CL just updates the formatting of files in wpt/webtransport by using: - test helper functions where possible - single quotations for strings - PEP8 style for python handlers Bug: 1201569 Change-Id: I39f475a9de1522fea8bf5a3fb231bfdff2294878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3142703 Reviewed-by: Kenichi Ishibashi <[email protected]> Commit-Queue: Nidhi Jaju <[email protected]> Cr-Commit-Position: refs/heads/main@{#918675} -- wpt-commits: e9162bcc6fa2449b55004f9b4b040f60b744f1ae wpt-pr: 30366
1 parent 012b1cb commit 7e22a43

File tree

4 files changed

+23
-31
lines changed

4 files changed

+23
-31
lines changed

testing/web-platform/tests/webtransport/constructor.any.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// META: global=window,worker
22
// META: script=/common/get-host-info.sub.js
3-
4-
const HOST = get_host_info().ORIGINAL_HOST;
3+
// META: script=resources/webtransport-test-helpers.sub.js
54

65
const BAD_URLS = [
76
null,
@@ -21,12 +20,10 @@ for (const url of BAD_URLS) {
2120
}, `WebTransport constructor should reject URL '${url}'`);
2221
}
2322

24-
// TODO(bashi): Test CSP.
25-
2623
promise_test(t => {
2724
const wt = new WebTransport(`https://${HOST}:0/`);
2825
return Promise.all([
29-
promise_rejects_js(t, TypeError, wt.ready, 'ready promise rejects'),
30-
promise_rejects_js(t, TypeError, wt.closed, 'closed promise rejects'),
26+
promise_rejects_js(t, TypeError, wt.ready, 'ready promise should be rejected'),
27+
promise_rejects_js(t, TypeError, wt.closed, 'closed promise should be rejected'),
3128
]);
32-
}, 'connection to port 0 should fail');
29+
}, 'Connection to port 0 should fail');
Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
// META: global=window,worker
22
// META: script=/common/get-host-info.sub.js
3-
4-
const HOST = get_host_info().ORIGINAL_HOST;
5-
const PORT = '{{ports[webtransport-h3][0]}}';
6-
const BASE = `https://${HOST}:${PORT}`;
3+
// META: script=resources/webtransport-test-helpers.sub.js
74

85
function set_csp(destination) {
9-
let meta = document.createElement("meta");
10-
meta.httpEquiv = "Content-Security-Policy";
6+
let meta = document.createElement('meta');
7+
meta.httpEquiv = 'Content-Security-Policy';
118
meta.content = `connect-src ${destination}`;
129
return meta;
1310
}
@@ -16,7 +13,7 @@ promise_test(async t => {
1613
let meta = set_csp("'none'");
1714
document.head.appendChild(meta);
1815

19-
let wt = new WebTransport(`${BASE}/handlers/custom-response.py?:status=200`);
16+
let wt = new WebTransport(webtransport_url('custom-response.py?:status=200'));
2017
await promise_rejects_dom(t, 'SecurityError', wt.ready, 'ready promise should be rejected');
2118
await promise_rejects_dom(t, 'SecurityError', wt.closed, 'closed promise should be rejected');
22-
}, "WebTransport connection should fail when CSP connect-src is set to none and reject the promises");
19+
}, 'WebTransport connection should fail when CSP connect-src is set to none and reject the promises');
Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
// META: global=window,worker
22
// META: script=/common/get-host-info.sub.js
3-
4-
const HOST = get_host_info().ORIGINAL_HOST;
5-
const PORT = '{{ports[webtransport-h3][0]}}';
6-
const BASE = `https://${HOST}:${PORT}`;
3+
// META: script=resources/webtransport-test-helpers.sub.js
74

85
function set_csp(destination) {
9-
let meta = document.createElement("meta");
10-
meta.httpEquiv = "Content-Security-Policy";
6+
let meta = document.createElement('meta');
7+
meta.httpEquiv = 'Content-Security-Policy';
118
meta.content = `connect-src ${destination}`;
129
return meta;
1310
}
@@ -16,6 +13,6 @@ promise_test(async t => {
1613
let meta = set_csp(`${BASE}`);
1714
document.head.appendChild(meta);
1815

19-
let wt = new WebTransport(`${BASE}/webtransport/handlers/custom-response.py?:status=200`);
16+
let wt = new WebTransport(webtransport_url('custom-response.py?:status=200'));
2017
await wt.ready;
21-
}, "WebTransport connection should succeed when CSP connect-src destination is set to the page");
18+
}, 'WebTransport connection should succeed when CSP connect-src destination is set to the page');
Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
from urllib.parse import urlsplit, parse_qsl
22

3+
34
def connect_received(request_headers, response_headers):
4-
for data in request_headers:
5-
if data[0] == b':path':
6-
path = data[1].decode('utf-8')
5+
for data in request_headers:
6+
if data[0] == b':path':
7+
path = data[1].decode('utf-8')
78

8-
qs = dict(parse_qsl(urlsplit(path).query))
9-
for key, value in qs.items():
10-
response_headers.append((key.encode('utf-8'), value.encode('utf-8')))
9+
qs = dict(parse_qsl(urlsplit(path).query))
10+
for key, value in qs.items():
11+
response_headers.append((key.encode('utf-8'), value.encode('utf-8')))
1112

12-
break
13-
return
13+
break
14+
return

0 commit comments

Comments
 (0)