Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit cf60c8c

Browse files
committed
Bug 1883721 - Move the support_class modify_class call inside the _compose_cmd r=kshampur,perftest-reviewers
Previously modify_class call was right outside of the _compose_cmd call. Because of that this wasn't shared between the main and extra-profiler runs. After moving the modify_class call inside of this function, it's now shared between these two runs since we call this method explicitly for both of these runs. Differential Revision: https://phabricator.services.mozilla.com/D207577
1 parent dab8ea9 commit cf60c8c

File tree

1 file changed

+7
-5
lines changed
  • testing/raptor/raptor/browsertime

1 file changed

+7
-5
lines changed

testing/raptor/raptor/browsertime/base.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -599,13 +599,19 @@ def _compose_cmd(self, test, timeout, extra_profiler_run=False):
599599
browsertime_options=browsertime_options, test=test
600600
)
601601

602-
return (
602+
cmd = (
603603
[self.browsertime_node, self.browsertime_browsertimejs]
604604
+ self.driver_paths
605605
+ [browsertime_script]
606606
+ browsertime_options
607607
)
608608

609+
if test.get("support_class", None):
610+
LOG.info("Test support class is modifying the command...")
611+
test.get("support_class").modify_command(cmd, test)
612+
613+
return cmd
614+
609615
def _compose_gecko_profiler_cmds(self, test, priority1_options):
610616
"""Modify the command line options for running the gecko profiler
611617
in the Firefox application"""
@@ -917,10 +923,6 @@ def output_timeout_handler(proc):
917923
# this will be used for btime --timeouts.pageLoad
918924
cmd = self._compose_cmd(test, timeout)
919925

920-
if test.get("support_class", None):
921-
LOG.info("Test support class is modifying the command...")
922-
test.get("support_class").modify_command(cmd, test)
923-
924926
output_timeout = BROWSERTIME_PAGELOAD_OUTPUT_TIMEOUT
925927
if test.get("type", "") == "scenario":
926928
# Change the timeout for scenarios since they

0 commit comments

Comments
 (0)