Bug 1938452 - Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount

This doesn't move test_AboutNewTab.js, as this test exercises the AboutNewTab
module under browser/modules/ and the AboutNewTabService component under
browser/components/newtab.

Differential Revision: https://phabricator.services.mozilla.com/D233873

Author: mikeconley

.gitignore

@@ -77,13 +77,13 @@ devtools/**/node_modules/
 tools/browsertime/node_modules/
 tools/lint/eslint/eslint-plugin-mozilla/node_modules/
 browser/components/asrouter/node_modules/
-browser/components/newtab/node_modules/
 browser/components/aboutwelcome/node_modules/
+browser/extensions/newtab/node_modules/
 tools/ts/node_modules/
 testing/xpcshell/moz-http2/node_modules/
 
 # Ignore newtab component build assets
-browser/components/newtab/logs/
+browser/extensions/newtab/logs/
 
 # Ignore about:welcome component build assets
 browser/components/aboutwelcome/logs/

.hgignore

@@ -73,13 +73,13 @@
 ^tools/browsertime/node_modules/
 ^tools/lint/eslint/eslint-plugin-mozilla/node_modules/
 ^browser/components/asrouter/node_modules/
-^browser/components/newtab/node_modules/
 ^browser/components/aboutwelcome/node_modules/
+^browser/extensions/newtab/node_modules/
 ^tools/ts/node_modules/
 ^testing/xpcshell/moz-http2/node_modules/
 
 # Ignore newtab component build assets
-^browser/components/newtab/logs/
+^browser/extensions/newtab/logs/
 
 # Ignore about:welcome component build assets
 ^browser/components/aboutwelcome/logs/

.prettierignore

@@ -1019,8 +1019,8 @@ browser/components/pocket/content/panels/js/main.bundle.js
 !browser/components/storybook/.storybook/*.js
 
 # Ignore newtab files
-browser/components/newtab/data/
-browser/components/newtab/logs/
+browser/extensions/newtab/data/
+browser/extensions/newtab/logs/
 
 # Ignore about:welcome files
 browser/components/aboutwelcome/logs/
@@ -1466,9 +1466,9 @@ browser/components/asrouter/content-src/schemas/BackgroundTaskMessagingExperimen
 browser/components/asrouter/content-src/schemas/MessagingExperiment.schema.json
 browser/components/asrouter/tests/InflightAssetsMessageProvider.sys.mjs
 browser/components/asrouter/tests/NimbusRolloutMessageProvider.sys.mjs
-browser/components/newtab/logs/
-browser/components/newtab/node_modules/
 browser/components/storybook/storybook-static/
+browser/extensions/newtab/logs/
+browser/extensions/newtab/node_modules/
 browser/locales/l10n-changesets.json
 browser/locales/l10n-onchange-changesets.json
 devtools/client/aboutdebugging/test/jest/node_modules/

browser/components/asrouter/tests/browser/browser.toml

@@ -1,6 +1,6 @@
 [DEFAULT]
 support-files = [
-  "../../../newtab/test/browser/blue_page.html",
+  "../../../../extensions/newtab/test/browser/blue_page.html",
   "head.js",
 ]
 

browser/components/asrouter/tests/browser/browser_asrouter_cfr.js

@@ -585,7 +585,7 @@ add_task(async function test_onLocationChange_cb() {
   let count = 0;
   const triggerHandler = () => ++count;
   const TEST_URL =
-    "https://example.com/browser/browser/components/newtab/test/browser/blue_page.html";
+    "https://example.com/browser/browser/extensions/newtab/test/browser/blue_page.html";
   const browser = gBrowser.selectedBrowser;
 
   await ASRouterTriggerListeners.get("openURL").init(triggerHandler, [

browser/components/asrouter/tests/unit/ASRouterStorage.test.js

@@ -1,5 +1,5 @@
 import { ASRouterStorage } from "modules/ASRouterStorage.sys.mjs";
-import { GlobalOverrider } from "../../../newtab/test/unit/utils";
+import { GlobalOverrider } from "tests/unit/utils";
 
 let overrider = new GlobalOverrider();
 

browser/components/newtab/moz.build

@@ -7,15 +7,6 @@
 with Files("**"):
     BUG_COMPONENT = ("Firefox", "New Tab Page")
 
-BROWSER_CHROME_MANIFESTS += [
-    "test/browser/abouthomecache/browser.toml",
-    "test/browser/browser.toml",
-]
-
-XPCSHELL_TESTS_MANIFESTS += [
-    "test/xpcshell/xpcshell.toml",
-]
-
 XPIDL_SOURCES += [
     "nsIAboutNewTabService.idl",
 ]
@@ -29,3 +20,7 @@ EXTRA_JS_MODULES += [
 XPCOM_MANIFESTS += [
     "components.conf",
 ]
+
+XPCSHELL_TESTS_MANIFESTS += [
+    "test/xpcshell/xpcshell.toml",
+]

browser/components/newtab/test/browser/annotation_second.html

@@ -1,38 +1,5 @@
 [DEFAULT]
 firefox-appdir = "browser"
 skip-if = ["os == 'android'"] # bug 1730213
-prefs = [
-  "browser.startup.homepage.abouthome_cache.enabled=true",
-  "browser.startup.homepage.abouthome_cache.testing=true",
-]
-
-["test_AboutHomeStartupCacheChild.js"]
-
-["test_AboutHomeStartupCacheWorker.js"]
-support-files = ["topstories.json"]
-skip-if = ["socketprocess_networking"] # Bug 1759035
 
 ["test_AboutNewTab.js"]
-
-["test_AdsFeed.js"]
-
-["test_FaviconFeed.js"]
-support-files = ["favicon.png"]
-
-["test_HighlightsFeed.js"]
-
-["test_PlacesFeed.js"]
-
-["test_Store.js"]
-
-["test_TelemetryFeed.js"]
-support-files = ["../schemas/*.schema.json"]
-
-["test_TopSitesFeed.js"]
-
-["test_TopSitesFeed_glean.js"]
-
-["test_WallpaperFeed.js"]
-tags = "remote-settings"
-
-["test_WeatherFeed.js"]

browser/components/newtab/test/xpcshell/xpcshell.toml

@@ -300,11 +300,11 @@ module.exports = function (config) {
             ],
             [
               new RegExp("^resource:///modules/asrouter/"),
-              path.join(__dirname, "../asrouter/modules/"),
+              path.join(__dirname, "../../components/asrouter/modules/"),
             ],
             [
               new RegExp("^resource:///modules/topsites/"),
-              path.join(__dirname, "../topsites/"),
+              path.join(__dirname, "../../components/topsites/"),
             ],
             [
               new RegExp("^resource://gre/modules/SearchShortcuts.sys.mjs"),