Bug 1945294 [wpt PR 50424] - Don't clear ForceReattachLayoutTree state on <slot> with display lock., a=testonly

dbaron · moz-wptsync-bot · commit fa816d5b5b55 · 2025-02-02T20:50:08.000Z
Automatic update from web-platform-tests Don't clear ForceReattachLayoutTree state on <slot> with display lock. This fixes a regression that started occurring frequently with text between MathJax elements inside of a <details> element (which uses content-visibility, and thus display lock). The regression resulted from changes to the internals of the <details> element. When detaching the layout tree for this particular case of <slot> elements with display lock, this restores the ForceReattachLayoutTree state that existed before so that it's still set when the display lock is no longer present. Fixed: 383593255 Change-Id: Ib1dab4da0b1211ecf35dd6e11201cc35064e466a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6220858 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1414486} -- wpt-commits: 1630698f22d6f9b631733118a01a95928d4a7342 wpt-pr: 50424
diff --git a/testing/web-platform/tests/css/css-contain/content-visibility/dynamic-change-with-slotted-text-ref.html b/testing/web-platform/tests/css/css-contain/content-visibility/dynamic-change-with-slotted-text-ref.html
@@ -0,0 +1,8 @@
+<!DOCTYPE HTML>
+<html>
+
+<div>
+<div>math</div>
+after
+<p></p>
+</div>
diff --git a/testing/web-platform/tests/css/css-contain/content-visibility/dynamic-change-with-slotted-text.html b/testing/web-platform/tests/css/css-contain/content-visibility/dynamic-change-with-slotted-text.html
@@ -0,0 +1,32 @@
+<!DOCTYPE HTML>
+<html class="reftest-wait">
+<link rel="help" href="https://issues.chromium.org/383593255">
+<link rel="match" href="dynamic-change-with-slotted-text-ref.html">
+
+<div>
+$$\text{math}$$
+after
+<p></p>
+</div>
+
+<script>
+
+let div = document.querySelector("div");
+let shadow = div.attachShadow({mode: "open"});
+shadow.innerHTML = "<slot style='display:block;content-visibility: hidden'></slot>";
+let slot = shadow.querySelector("slot");
+
+requestAnimationFrame(() => {
+  getComputedStyle(div.querySelector("p")).width;
+  let t1 = div.firstChild;
+  let t2 = t1.splitText(1);
+  let t3 = t2.splitText(15);
+  let d = document.createElement("div");
+  d.innerText = "math";
+  t2.replaceWith(d);
+  requestAnimationFrame(() => {
+    slot.style.contentVisibility = "";
+    document.documentElement.classList.remove("reftest-wait");
+  });
+});
+</script>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,8 @@ @@
 +<!DOCTYPE HTML>
 +<html>
++
 +<div>
 +<div>math</div>
 +after
 +<p></p>
 +</div>