Run formatting and remove ruff warnings (#890)

Run formatting and remove ruff warnings

Author: leplatrem

bin/lint.sh

@@ -11,8 +11,8 @@ FORMAT_CMD="$POETRY_RUN ruff format ."
 # Scan only files fixed into the repo, omit poetry.lock
 DETECT_SECRETS_FILES="$(git ls-tree --full-tree -r --name-only HEAD | grep -v poetry.lock)"
 DETECT_SECRETS_CMD="$POETRY_RUN detect-secrets-hook $DETECT_SECRETS_FILES --baseline .secrets.baseline"
-  
-LINT_CMD="$POETRY_RUN ruff ."
+
+LINT_CMD="$POETRY_RUN ruff check ."
 
 MYPY_CMD="$POETRY_RUN mypy jbi"
 
@@ -50,7 +50,7 @@ if [ -z "$1" ]; then
 else
   subcommand=$1; shift
   case $subcommand in
-    "format") 
+    "format")
       if [ -n "$1" ] && [ "$1" != "--fix" ]; then
         usage
       else
@@ -78,7 +78,7 @@ else
     "detect-secrets")
       $DETECT_SECRETS_CMD
       ;;
-    *) 
+    *)
       usage
       ;;
   esac

jbi/__init__.py

@@ -3,6 +3,7 @@
 
 This part of the code is not aware of the HTTP context it runs in.
 """
+
 from enum import Enum
 
 

jbi/app.py

@@ -1,6 +1,7 @@
 """
 Core FastAPI app (setup, middleware)
 """
+
 import logging
 import time
 from pathlib import Path

jbi/common/instrument.py

@@ -3,6 +3,7 @@
 ServiceHealth: Return type that service health checks should use
 InstrumentedClient: wraps service clients so that we can track their usage
 """
+
 import logging
 from functools import wraps
 from typing import Sequence, Type

jbi/configuration.py

@@ -1,6 +1,7 @@
 """
 Parsing and validating the YAML configuration occurs within this module
 """
+
 import logging
 
 from pydantic import ValidationError

jbi/environment.py

@@ -1,6 +1,7 @@
 """
 Module dedicated to interacting with the environment (variables, version.json)
 """
+
 import json
 
 # https://github.com/python/mypy/issues/12841

jbi/jira/service.py

@@ -570,9 +570,9 @@ def check_jira_all_project_issue_types_exist(actions, _get_service):
         action_issue_types = set(action.parameters.issue_type_map.values())
         project_issue_types = issue_types_by_project.get(action.jira_project_key, set())
         if missing_issue_types := action_issue_types - project_issue_types:
-            missing_issue_types_by_project[
-                action.jira_project_key
-            ] = missing_issue_types
+            missing_issue_types_by_project[action.jira_project_key] = (
+                missing_issue_types
+            )
     if missing_issue_types_by_project:
         return [
             checks.Warning(

jbi/log.py

@@ -1,6 +1,7 @@
 """
 Dedicated module for logging configuration and setup
 """
+
 import logging
 import logging.config
 import sys

jbi/models.py

@@ -1,6 +1,7 @@
 """
 Python Module for Pydantic Models and validation
 """
+
 import functools
 import logging
 import warnings

jbi/router.py

@@ -1,6 +1,7 @@
 """
 Core FastAPI app (setup, middleware)
 """
+
 import secrets
 from pathlib import Path
 from typing import Annotated, Optional