Skip to content

Commit 2178e8a

Browse files
authored
Flip default config value enabled to true (#359)
One of the config values for each project is `enabled`. This value controls whether actions are run when a matching webhook is encountered. At the time of this commit, each project set `enabled: true`. So, in this commit, we flip the default so that actions are enabled by default and can optionally be disabled by setting `enabled: false`. * Update .secrets.baseline
1 parent 0df5e76 commit 2178e8a

File tree

7 files changed

+3
-26
lines changed

7 files changed

+3
-26
lines changed

.secrets.baseline

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,9 @@
122122
"filename": "README.md",
123123
"hashed_secret": "04e78d6e804f2b59e6cb282cb9ed2c7bfd8a9737",
124124
"is_verified": false,
125-
"line_number": 245
125+
"line_number": 243
126126
}
127127
]
128128
},
129-
"generated_at": "2022-10-07T13:12:35Z"
129+
"generated_at": "2023-01-10T19:43:27Z"
130130
}

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ Below is a full example of an action configuration:
2121
allow_private: false
2222
2323
description: example configuration
24-
enabled: true
2524
module: jbi.actions.default
2625
parameters:
2726
jira_project_key: EXMPL
@@ -111,7 +110,6 @@ Full configuration, that will set assignee, change the Jira issue status and res
111110
- whiteboard_tag: fidefe
112111
113112
description: full configuration
114-
enabled: true
115113
module: jbi.actions.default
116114
parameters:
117115
jira_project_key: FIDEFE

config/config.local.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
- whiteboard_tag: devtest
44
contact: tbd
55
description: DevTest whiteboard tag
6-
enabled: true
76
parameters:
87
jira_project_key: DevTest
98
jira_components:

config/config.nonprod.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
- whiteboard_tag: nonprodtest
44
55
description: Nonprod testing whiteboard tag (JBI Bin Project)
6-
enabled: true
76
parameters:
87
jira_project_key: JB
98

109
- whiteboard_tag: flowstate
1110
allow_private: true
1211
1312
description: Flowstate whiteboard tag
14-
enabled: true
1513
parameters:
1614
jira_project_key: MR2
1715
steps:
@@ -36,7 +34,6 @@
3634
- whiteboard_tag: fxcm
3735
3836
description: Firefox Credential Management Team whiteboard tag
39-
enabled: true
4037
parameters:
4138
jira_project_key: FXCM
4239
steps:
@@ -70,7 +67,6 @@
7067
- whiteboard_tag: fxdroid
7168
7269
description: Firefox Android Team Tag
73-
enabled: true
7470
parameters:
7571
jira_project_key: FXDROID
7672
steps:

config/config.prod.yaml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,19 @@
33
- whiteboard_tag: addons
44
contact: tbd
55
description: Addons whiteboard tag for AMO Team
6-
enabled: true
76
# module: jbi.actions.default
87
parameters:
98
jira_project_key: WEBEXT
109

1110
- whiteboard_tag: fidedi
1211
contact: tbd
1312
description: Firefox Desktop Integration whiteboard tag
14-
enabled: true
1513
parameters:
1614
jira_project_key: FIDEDI
1715

1816
- whiteboard_tag: fidefe
1917
2018
description: Firefox Front End whiteboard tag
21-
enabled: true
2219
parameters:
2320
jira_project_key: FIDEFE
2421
steps:
@@ -48,7 +45,6 @@
4845
- whiteboard_tag: flowstate
4946
5047
description: Flowstate whiteboard tag
51-
enabled: true
5248
parameters:
5349
jira_project_key: MR2
5450
steps:
@@ -74,14 +70,12 @@
7470
- whiteboard_tag: fxatps
7571
contact: tbd
7672
description: Privacy & Security and Anti-Tracking Team whiteboard tag
77-
enabled: true
7873
parameters:
7974
jira_project_key: FXATPS
8075

8176
- whiteboard_tag: fxcm
8277
8378
description: Firefox Credential Management Team whiteboard tag
84-
enabled: true
8579
parameters:
8680
jira_project_key: FXCM
8781
steps:
@@ -115,7 +109,6 @@
115109
- whiteboard_tag: fxdroid
116110
117111
description: Firefox Android Team Tag
118-
enabled: true
119112
parameters:
120113
jira_project_key: FXDROID
121114
steps:
@@ -149,49 +142,42 @@
149142
- whiteboard_tag: fxsync
150143
contact: tbd
151144
description: Firefox Sync Team whiteboard tag
152-
enabled: true
153145
parameters:
154146
jira_project_key: SYNC
155147

156148
- whiteboard_tag: mv3
157149
contact: tbd
158150
description: MV3 whiteboard tag
159-
enabled: true
160151
parameters:
161152
jira_project_key: WEBEXT
162153

163154
- whiteboard_tag: nimbus
164155
contact: tbd
165156
description: Nimbus whiteboard tag
166-
enabled: true
167157
parameters:
168158
jira_project_key: EXP
169159

170160
- whiteboard_tag: prodtest
171161
172162
description: Prod testing whiteboard tag (JBI Bin Project)
173-
enabled: true
174163
parameters:
175164
jira_project_key: JB
176165

177166
- whiteboard_tag: proton
178167
contact: tbd
179168
description: Proton whiteboard tag for Firefox Frontend
180-
enabled: true
181169
parameters:
182170
jira_project_key: FIDEFE
183171

184172
- whiteboard_tag: relops
185173
contact: tbd
186174
description: Release Operations Team Tag
187-
enabled: true
188175
parameters:
189176
jira_project_key: RELOPS
190177

191178
- whiteboard_tag: remote-settings
192179
193180
description: Remote Settings Server issues
194-
enabled: true
195181
parameters:
196182
jira_project_key: SE
197183
jira_components:
@@ -200,6 +186,5 @@
200186
- whiteboard_tag: snt
201187
202188
description: Search/NewTab Team Tag
203-
enabled: true
204189
parameters:
205190
jira_project_key: SNT

jbi/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class Action(YamlModel):
3939
# TODO: Remove the tbd literal option when all actions have contact info # pylint: disable=fixme
4040
contact: EmailStr | list[EmailStr] | Literal["tbd"]
4141
description: str
42-
enabled: bool = False
42+
enabled: bool = True
4343
allow_private: bool = False
4444
parameters: dict = {}
4545
_caller: Optional[Callable] = PrivateAttr(default=None)

tests/fixtures/bad-config.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
- whiteboard_tag: A
44
contact: foobar
55
description: test config
6-
enabled: true
76
module: jbi.actions.default
87
parameters:
98
jira_project_key: KEY

0 commit comments

Comments
 (0)