Use get_project to retrieve project issue types (#583)

The method we were trying to use to fetch issue types appears to not work for Jira Cloud instances. So, we transitioned to getting project metadata and pulling issue types from there.

Author: grahamalama

jbi/services/jira.py

@@ -85,7 +85,7 @@ def raise_for_status(self, *args, **kwargs):
     set_issue_status = instrumented_method(Jira.set_issue_status)
     issue_add_comment = instrumented_method(Jira.issue_add_comment)
     create_issue = instrumented_method(Jira.create_issue)
-    issue_createmeta_issuetypes = instrumented_method(Jira.issue_createmeta_issuetypes)
+    get_project = instrumented_method(Jira.get_project)
 
 
 @lru_cache(maxsize=1)
@@ -228,8 +228,8 @@ def _all_project_issue_types_exist(actions: Actions):
     }
     success = True
     for project, specified_issue_types in issue_types_by_project.items():
-        all_issue_types = get_client().issue_createmeta_issuetypes(project)
-        all_issue_types_names = set(it["name"] for it in all_issue_types)
+        response = get_client().get_project(project)
+        all_issue_types_names = set(it["name"] for it in response["issueTypes"])
         unknown = set(specified_issue_types) - all_issue_types_names
         if unknown:
             logger.error(

tests/unit/test_router.py

@@ -259,10 +259,12 @@ def test_read_heartbeat_success(anon_client, mocked_jira, mocked_bugzilla):
             "DELETE_ISSUES": {"havePermission": True},
         },
     }
-    mocked_jira.issue_createmeta_issuetypes.return_value = [
-        {"name": "Task"},
-        {"name": "Bug"},
-    ]
+    mocked_jira.get_project.return_value = {
+        "issueTypes": [
+            {"name": "Task"},
+            {"name": "Bug"},
+        ]
+    }
 
     resp = anon_client.get("/__heartbeat__")
 
@@ -324,10 +326,12 @@ def test_jira_heartbeat_unknown_components(anon_client, mocked_jira):
 
 def test_jira_heartbeat_unknown_issue_types(anon_client, mocked_jira):
     mocked_jira.get_server_info.return_value = {}
-    mocked_jira.issue_createmeta_issuetypes.return_value = [
-        {"name": "Task"},
-        # missing Bug
-    ]
+    mocked_jira.get_project.return_value = {
+        "issueTypes": [
+            {"name": "Task"},
+            # missing "Bug"
+        ]
+    }
 
     resp = anon_client.get("/__heartbeat__")
 
@@ -351,10 +355,12 @@ def test_head_heartbeat_success(anon_client, mocked_jira, mocked_bugzilla):
             "DELETE_ISSUES": {"havePermission": True},
         },
     }
-    mocked_jira.issue_createmeta_issuetypes.return_value = [
-        {"name": "Task"},
-        {"name": "Bug"},
-    ]
+    mocked_jira.get_project.return_value = {
+        "issueTypes": [
+            {"name": "Task"},
+            {"name": "Bug"},
+        ]
+    }
 
     resp = anon_client.head("/__heartbeat__")