Skip to content

Commit 46764f0

Browse files
authored
Temporarily disable API key verification (#1181)
1 parent 84cf84c commit 46764f0

File tree

2 files changed

+49
-49
lines changed

2 files changed

+49
-49
lines changed

jbi/router.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ def api_key_auth(
6767

6868
@router.post(
6969
"/bugzilla_webhook",
70-
dependencies=[Depends(api_key_auth)],
70+
# TODO:
71+
# dependencies=[Depends(api_key_auth)],
7172
)
7273
async def bugzilla_webhook(
7374
request: Request,

tests/unit/test_router.py

Lines changed: 47 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import base64
21
import json
32
import os
43
from datetime import datetime
@@ -20,34 +19,34 @@ def test_read_root(anon_client):
2019
assert get_settings().jira_base_url in infos["configuration"]["jira_base_url"]
2120

2221

23-
@pytest.mark.parametrize(
24-
"endpoint",
25-
[
26-
"/whiteboard_tags",
27-
"/dl_queue/",
28-
"/jira_projects/",
29-
"/powered_by_jbi/",
30-
"/bugzilla_webhooks/",
31-
],
32-
)
33-
def test_get_protected_endpoints(
34-
endpoint, webhook_request_factory, mocked_bugzilla, anon_client, test_api_key
35-
):
36-
resp = anon_client.get(endpoint)
37-
assert resp.status_code == 401
38-
39-
# Supports authentication via `X-Api-Key` header
40-
resp = anon_client.get(endpoint, headers={"X-Api-Key": test_api_key})
41-
assert resp.status_code == 200
42-
43-
# Supports authentication via Basic Auth header
44-
username_password = ":" + test_api_key
45-
credentials_b64 = base64.b64encode(username_password.encode("utf8")).decode("utf8")
46-
resp = anon_client.get(
47-
endpoint,
48-
headers={"Authorization": f"Basic {credentials_b64}"},
49-
)
50-
assert resp.status_code == 200
22+
# @pytest.mark.parametrize(
23+
# "endpoint",
24+
# [
25+
# "/whiteboard_tags",
26+
# "/dl_queue/",
27+
# "/jira_projects/",
28+
# "/powered_by_jbi/",
29+
# "/bugzilla_webhooks/",
30+
# ],
31+
# )
32+
# def test_get_protected_endpoints(
33+
# endpoint, webhook_request_factory, mocked_bugzilla, anon_client, test_api_key
34+
# ):
35+
# resp = anon_client.get(endpoint)
36+
# assert resp.status_code == 401
37+
38+
# # Supports authentication via `X-Api-Key` header
39+
# resp = anon_client.get(endpoint, headers={"X-Api-Key": test_api_key})
40+
# assert resp.status_code == 200
41+
42+
# # Supports authentication via Basic Auth header
43+
# username_password = ":" + test_api_key
44+
# credentials_b64 = base64.b64encode(username_password.encode("utf8")).decode("utf8")
45+
# resp = anon_client.get(
46+
# endpoint,
47+
# headers={"Authorization": f"Basic {credentials_b64}"},
48+
# )
49+
# assert resp.status_code == 200
5150

5251

5352
def test_whiteboard_tags(authenticated_client):
@@ -261,25 +260,25 @@ def test_webhook_is_500_if_queue_raises_Exception(
261260
assert response.status_code == 500
262261

263262

264-
def test_webhook_is_401_if_unathenticated(
265-
webhook_request_factory, mocked_bugzilla, anon_client
266-
):
267-
response = anon_client.post(
268-
"/bugzilla_webhook",
269-
data={},
270-
)
271-
assert response.status_code == 401
272-
273-
274-
def test_webhook_is_401_if_wrong_key(
275-
webhook_request_factory, mocked_bugzilla, anon_client
276-
):
277-
response = anon_client.post(
278-
"/bugzilla_webhook",
279-
headers={"X-Api-Key": "not the right key"},
280-
data={},
281-
)
282-
assert response.status_code == 401
263+
# def test_webhook_is_401_if_unathenticated(
264+
# webhook_request_factory, mocked_bugzilla, anon_client
265+
# ):
266+
# response = anon_client.post(
267+
# "/bugzilla_webhook",
268+
# data={},
269+
# )
270+
# assert response.status_code == 401
271+
272+
273+
# def test_webhook_is_401_if_wrong_key(
274+
# webhook_request_factory, mocked_bugzilla, anon_client
275+
# ):
276+
# response = anon_client.post(
277+
# "/bugzilla_webhook",
278+
# headers={"X-Api-Key": "not the right key"},
279+
# data={},
280+
# )
281+
# assert response.status_code == 401
283282

284283

285284
def test_webhook_is_422_if_bug_information_missing(

0 commit comments

Comments
 (0)