Skip to content

Commit 7ad1eba

Browse files
authored
Log object dicts instead of JSON strings (#85)
1 parent 68a2ff0 commit 7ad1eba

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/jbi/runner.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def execute_action(
3636
"bug": {
3737
"id": request.bug.id if request.bug else None,
3838
},
39-
"request": request.json(),
39+
"request": request.dict(),
4040
}
4141
try:
4242
logger.debug(
@@ -53,7 +53,7 @@ def execute_action(
5353
raise IgnoreInvalidRequestError(
5454
"bug not accessible or bugzilla down"
5555
) from ex
56-
log_context["bug"] = bug_obj.json()
56+
log_context["bug"] = bug_obj.dict()
5757

5858
try:
5959
action_name, current_action = bug_obj.lookup_action(actions)

src/jbi/whiteboard_actions/default.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def __call__( # pylint: disable=inconsistent-return-statements
4848
"Ignore event target %r",
4949
target,
5050
extra={
51-
"request": payload.json(),
51+
"request": payload.dict(),
5252
},
5353
)
5454

@@ -58,8 +58,8 @@ def comment_create_or_noop(self, payload: BugzillaWebhookRequest):
5858
linked_issue_key = bug_obj.extract_from_see_also()
5959

6060
log_context = {
61-
"request": payload.json(),
62-
"bug": bug_obj.json(),
61+
"request": payload.dict(),
62+
"bug": bug_obj.dict(),
6363
}
6464
if not linked_issue_key:
6565
logger.debug(
@@ -106,8 +106,8 @@ def bug_create_or_update(
106106
return self.create_and_link_issue(payload, bug_obj)
107107

108108
log_context = {
109-
"request": payload.json(),
110-
"bug": bug_obj.json(),
109+
"request": payload.dict(),
110+
"bug": bug_obj.dict(),
111111
}
112112
logger.debug(
113113
"Update fields of Jira issue %s for Bug %s",
@@ -146,8 +146,8 @@ def create_and_link_issue(
146146
): # pylint: disable=too-many-locals
147147
"""create jira issue and establish link between bug and issue; rollback/delete if required"""
148148
log_context = {
149-
"request": payload.json(),
150-
"bug": bug_obj.json(),
149+
"request": payload.dict(),
150+
"bug": bug_obj.dict(),
151151
}
152152
logger.debug(
153153
"Create new Jira issue for Bug %s",

0 commit comments

Comments
 (0)